Linux ARM-MSM sub-architecture
 help / color / mirror / Atom feed
* Re: [RFC 14/21] drm/amdgpu: Remove FB_KMS_HELPER and FB related config options
@ 2015-07-13  7:08 Koenig, Christian
  2015-07-13 14:05 ` Christian König
  0 siblings, 1 reply; 3+ messages in thread
From: Koenig, Christian @ 2015-07-13  7:08 UTC (permalink / raw)
  To: Archit Taneja
  Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org,
	Deucher, Alexander


[-- Attachment #1.1: Type: text/plain, Size: 1512 bytes --]

Hi Jammy,

I suggested to make the feature optional because of the unit test's.

There we don't need this feature and actually want to test the kernel functionality.

Regards,
Christian.

Am 13.07.2015 08:45 schrieb Archit Taneja <architt@codeaurora.org>:
Remove FB_* config options since the driver doesn't call any fbdev
functions directly.

Remove FB_KMS_HELPER as this would now be selected by the top level
FBDEV_EMULATION config option. If the fbdev emulation isn't selected,
the drm_fb_helper functions will be stubbed out.

Cc: Alex Deucher <alexander.deucher@amd.com>
Cc: Oded Gabbay <oded.gabbay@gmail.com>
Cc: "Christian König" <christian.koenig@amd.com>

Signed-off-by: Archit Taneja <architt@codeaurora.org>
---
 drivers/gpu/drm/amd/amdgpu/Kconfig | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/Kconfig b/drivers/gpu/drm/amd/amdgpu/Kconfig
index da7dcbf..2396482 100644
--- a/drivers/gpu/drm/amd/amdgpu/Kconfig
+++ b/drivers/gpu/drm/amd/amdgpu/Kconfig
@@ -1,12 +1,8 @@
 config DRM_AMDGPU
         tristate "AMD GPU"
         depends on DRM && PCI
-       select FB_CFB_FILLRECT
-       select FB_CFB_COPYAREA
-       select FB_CFB_IMAGEBLIT
         select FW_LOADER
         select DRM_KMS_HELPER
-       select DRM_KMS_FB_HELPER
         select DRM_TTM
         select POWER_SUPPLY
         select HWMON
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
hosted by The Linux Foundation


[-- Attachment #1.2: Type: text/html, Size: 2589 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply related	[flat|nested] 3+ messages in thread
* [RFC 00/21] drm: fb emulation: Step 3: Remove FB_KMS_HELPER config from drivers
@ 2015-07-13  6:43 Archit Taneja
  2015-07-13  6:44 ` [RFC 14/21] drm/amdgpu: Remove FB_KMS_HELPER and FB related config options Archit Taneja
  0 siblings, 1 reply; 3+ messages in thread
From: Archit Taneja @ 2015-07-13  6:43 UTC (permalink / raw)
  To: dri-devel, daniel; +Cc: linux-arm-msm, airlied, Archit Taneja

With the top level DRM_FBDEV_EMULATION option, drivers don't need to
select DRM_FB_KMS_HELPER or other FB related config options in the
driver.

Even if FBDEV_EMULATION isn't select, the stubbed out versions of
the drm_fb_helper functions will be called.

There are some drivers which still need some FB stuff even after
these changes. They are qxl, udl and nouveau. These are handled a bit
differently compared to the other patches.

Archit Taneja (21):
  drm/cirrus: Remove FB_KMS_HELPER and FB related config options
  drm/rockchip: Remove FB_KMS_HELPER and FB related config options
  drm/armada: Remove FB_KMS_HELPER and FB related config options
  drm/ast: Remove FB_KMS_HELPER and FB related config options
  drm/omap: Remove FB_KMS_HELPER and FB related config options
  drm/exynos: Remove FB_KMS_HELPER and FB related config options
  drm/gma500: Remove FB_KMS_HELPER and FB related config options
  drm/mgag200: Remove FB_KMS_HELPER and FB related config options
  drm/radeon: Remove FB_KMS_HELPER and FB related config options
  drm/qxl: Remove FB_KMS_HELPER and FB related config options
  drm/nouveau: Remove FB_KMS_HELPER and FB related config options
  drm/udl: Remove FB_KMS_HELPER and FB related config options
  drm/bochs: Remove FB_KMS_HELPER and FB related config options
  drm/amdgpu: Remove FB_KMS_HELPER and FB related config options
  drm/virtio: Remove FB_KMS_HELPER and FB related config options
  drm/fb_cma_helper: Remove FB_KMS_HELPER and FB related config options
  drm/atmel-hlcdc: Remove FB_KMS_HELPER config option
  drm/imx: Remove FB_KMS_HELPER config option
  drm/rcar-du: Remove FB_KMS_HELPER config option
  drm/shmobile: Remove FB_KMS_HELPER config option
  drm/tilcdc: Remove FB_KMS_HELPER config option

 drivers/gpu/drm/Kconfig             |  4 ----
 drivers/gpu/drm/amd/amdgpu/Kconfig  |  4 ----
 drivers/gpu/drm/armada/Kconfig      |  4 ----
 drivers/gpu/drm/ast/Kconfig         |  4 ----
 drivers/gpu/drm/atmel-hlcdc/Kconfig |  1 -
 drivers/gpu/drm/bochs/Kconfig       |  4 ----
 drivers/gpu/drm/cirrus/Kconfig      |  4 ----
 drivers/gpu/drm/exynos/Kconfig      |  6 ------
 drivers/gpu/drm/gma500/Kconfig      |  4 ----
 drivers/gpu/drm/imx/Kconfig         |  1 -
 drivers/gpu/drm/mgag200/Kconfig     |  4 ----
 drivers/gpu/drm/nouveau/Kconfig     |  7 +------
 drivers/gpu/drm/omapdrm/Kconfig     |  5 -----
 drivers/gpu/drm/qxl/Kconfig         |  5 -----
 drivers/gpu/drm/qxl/qxl_fb.c        |  4 ++++
 drivers/gpu/drm/radeon/Kconfig      |  4 ----
 drivers/gpu/drm/rcar-du/Kconfig     |  1 -
 drivers/gpu/drm/rockchip/Kconfig    |  4 ----
 drivers/gpu/drm/shmobile/Kconfig    |  1 -
 drivers/gpu/drm/tilcdc/Kconfig      |  1 -
 drivers/gpu/drm/udl/Kconfig         |  5 -----
 drivers/gpu/drm/udl/udl_fb.c        | 10 ++++++++++
 drivers/gpu/drm/virtio/Kconfig      |  4 ----
 23 files changed, 15 insertions(+), 76 deletions(-)

-- 
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
hosted by The Linux Foundation

^ permalink raw reply	[flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-07-13 14:05 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-07-13  7:08 [RFC 14/21] drm/amdgpu: Remove FB_KMS_HELPER and FB related config options Koenig, Christian
2015-07-13 14:05 ` Christian König
  -- strict thread matches above, loose matches on Subject: below --
2015-07-13  6:43 [RFC 00/21] drm: fb emulation: Step 3: Remove FB_KMS_HELPER config from drivers Archit Taneja
2015-07-13  6:44 ` [RFC 14/21] drm/amdgpu: Remove FB_KMS_HELPER and FB related config options Archit Taneja

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox