Linux ARM-MSM sub-architecture
 help / color / mirror / Atom feed
From: Praveen Talari <quic_ptalari@quicinc.com>
To: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Jiri Slaby <jirislaby@kernel.org>, Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konradybcio@kernel.org>,
	Viresh Kumar <vireshk@kernel.org>, Nishanth Menon <nm@ti.com>,
	Stephen Boyd <sboyd@kernel.org>,
	"Rafael J. Wysocki" <rafael@kernel.org>,
	<linux-arm-msm@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<linux-serial@vger.kernel.org>, <devicetree@vger.kernel.org>,
	<linux-pm@vger.kernel.org>
Cc: <psodagud@quicinc.com>, <djaggi@quicinc.com>,
	<quic_msavaliy@quicinc.com>, <quic_vtanuku@quicinc.com>,
	<quic_arandive@quicinc.com>, <quic_mnaresh@quicinc.com>,
	<quic_shazhuss@quicinc.com>
Subject: Re: [PATCH v2 0/9] Enable QUPs and Serial on SA8255p Qualcomm platforms
Date: Fri, 25 Apr 2025 19:48:50 +0530	[thread overview]
Message-ID: <3ffe00fd-1fbe-41c6-b82d-030bcf6d76d8@quicinc.com> (raw)
In-Reply-To: <6662b275-6b8e-40be-b62f-c17ae8e63dfa@oss.qualcomm.com>

Hi

On 4/23/2025 6:31 PM, Konrad Dybcio wrote:
> On 4/18/25 5:12 PM, Praveen Talari wrote:
>> The Qualcomm automotive SA8255p SoC relies on firmware to configure
>> platform resources, including clocks, interconnects and TLMM. The device
>> drivers request resources operations over SCMI using power and
>> performance protocols.
>>
>> The SCMI power protocol enables or disables resources like clocks,
>> interconnect paths, and TLMM (GPIOs) using runtime PM framework APIs,
>> such as resume/suspend, to control power states(on/off).
>>
>> The SCMI performance protocol manages UART baud rates, with each baud
>> rate represented by a performance level. Drivers use the
>> dev_pm_opp_set_level() API to request the desired baud rate by
>> specifying the performance level.
>>
>> The QUP drivers are SCMI clients, with clocks, interconnects, pinctrl
>> and power-domains abstracted by a SCMI server.
> So I recently started working on abstracting away power controls from
> the SE protocol drivers into a single place, among other improvements
>
> A snapshot of this work is available here
>
> https://github.com/quic-kdybcio/linux/commits/topic/single_node_genise/
>
> (not yet 100% ready..)
>
> I think it'd make sense to get it done first, so that we can condense
> most of your changes in the common driver, where we'd swap out the clock
> handling for perf level setting instead
Thank you for the update and for sharing the snapshot of your work. The 
improvements you're working on sound promising, especially the 
abstraction of power controls into a single place.
While we appreciate the direction you're taking, our patch has already 
been pushed upstream with V2.
To maintain our momentum, we would prefer to continue with our current 
cleanups rather than waiting for your post if it's planned for a few 
weeks from now.

It would be greatly appreciated if you could take this patch and build 
your ongoing work on top of it, as it would be somewhat similar to 
optimize it from SE's protocol driver to the common geni driver for 
power management.

That being said, could you please provide an estimated completion date 
for your work?


Thanks,

Praveen

>
> Konrad

      reply	other threads:[~2025-04-25 14:19 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-18 15:12 [PATCH v2 0/9] Enable QUPs and Serial on SA8255p Qualcomm platforms Praveen Talari
2025-04-18 15:12 ` [PATCH v2 1/9] opp: add new helper API dev_pm_opp_set_level() Praveen Talari
2025-04-21  7:40   ` Viresh Kumar
2025-04-22 17:07     ` Praveen Talari
2025-04-23  5:36       ` Viresh Kumar
2025-04-23  6:28         ` Praveen Talari
2025-04-18 15:12 ` [PATCH v2 2/9] dt-bindings: serial: describe SA8255p Praveen Talari
2025-04-25 10:12   ` Krzysztof Kozlowski
2025-04-25 11:01     ` Praveen Talari
2025-04-18 15:12 ` [PATCH v2 3/9] dt-bindings: qcom: geni-se: " Praveen Talari
2025-04-25 10:16   ` Krzysztof Kozlowski
2025-04-25 11:00     ` Praveen Talari
2025-04-18 15:12 ` [PATCH v2 4/9] soc: qcom: geni-se: Enable QUPs on SA8255p Qualcomm platforms Praveen Talari
2025-04-18 15:12 ` [PATCH v2 5/9] serial: qcom-geni: move resource initialization to separate function Praveen Talari
2025-04-18 15:12 ` [PATCH v2 6/9] serial: qcom-geni: move resource control logic to separate functions Praveen Talari
2025-04-18 15:12 ` [PATCH v2 7/9] serial: qcom-geni: move clock-rate logic to separate function Praveen Talari
2025-04-18 15:12 ` [PATCH v2 8/9] serial: qcom-geni: Enable PM runtime for serial driver Praveen Talari
2025-04-18 15:12 ` [PATCH v2 9/9] serial: qcom-geni: Enable Serial on SA8255p Qualcomm platforms Praveen Talari
2025-04-23 13:01 ` [PATCH v2 0/9] Enable QUPs and " Konrad Dybcio
2025-04-25 14:18   ` Praveen Talari [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3ffe00fd-1fbe-41c6-b82d-030bcf6d76d8@quicinc.com \
    --to=quic_ptalari@quicinc.com \
    --cc=andersson@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=djaggi@quicinc.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=jirislaby@kernel.org \
    --cc=konrad.dybcio@oss.qualcomm.com \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=nm@ti.com \
    --cc=psodagud@quicinc.com \
    --cc=quic_arandive@quicinc.com \
    --cc=quic_mnaresh@quicinc.com \
    --cc=quic_msavaliy@quicinc.com \
    --cc=quic_shazhuss@quicinc.com \
    --cc=quic_vtanuku@quicinc.com \
    --cc=rafael@kernel.org \
    --cc=robh@kernel.org \
    --cc=sboyd@kernel.org \
    --cc=vireshk@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox