From: Praveen Talari <quic_ptalari@quicinc.com>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jirislaby@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Viresh Kumar <vireshk@kernel.org>, Nishanth Menon <nm@ti.com>,
Stephen Boyd <sboyd@kernel.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
<linux-arm-msm@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-serial@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-pm@vger.kernel.org>, <psodagud@quicinc.com>,
<djaggi@quicinc.com>, <quic_msavaliy@quicinc.com>,
<quic_vtanuku@quicinc.com>, <quic_arandive@quicinc.com>,
<quic_mnaresh@quicinc.com>, <quic_shazhuss@quicinc.com>,
Nikunj Kela <quic_nkela@quicinc.com>
Subject: Re: [PATCH v2 2/9] dt-bindings: serial: describe SA8255p
Date: Fri, 25 Apr 2025 16:31:19 +0530 [thread overview]
Message-ID: <5d3033e7-0798-4246-a6ea-74ead8485053@quicinc.com> (raw)
In-Reply-To: <20250425-graceful-psychedelic-leopard-0da7fe@kuoka>
Hi
On 4/25/2025 3:42 PM, Krzysztof Kozlowski wrote:
> On Fri, Apr 18, 2025 at 08:42:28PM GMT, Praveen Talari wrote:
>> + interrupts:
>> + minItems: 1
>> + items:
>> + - description: UART core irq
>> + - description: Wakeup irq (RX GPIO)
>> +
>> + interrupt-names:
>> + description:
>> + The UART interrupt and optionally the RX in-band wakeup interrupt.
> Drop description. It is not even accurate because you do not allow
> wakeup to be optional.
Will update in next version.
>
>> + items:
>> + - const: uart
>> + - const: wakeup
>> +
>> + power-domains:
>> + minItems: 2
>> + maxItems: 2
>> +
>> + power-domain-names:
>> + items:
>> + - const: power
>> + - const: perf
>> +
>> +required:
>> + - compatible
>> + - interrupts
>> + - reg
> Keep the same order as in properties. You already got comment about
> placement of 'reg'.
I agree, will update in next version
>
> Best regards,
> Krzysztof
>
next prev parent reply other threads:[~2025-04-25 11:01 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-18 15:12 [PATCH v2 0/9] Enable QUPs and Serial on SA8255p Qualcomm platforms Praveen Talari
2025-04-18 15:12 ` [PATCH v2 1/9] opp: add new helper API dev_pm_opp_set_level() Praveen Talari
2025-04-21 7:40 ` Viresh Kumar
2025-04-22 17:07 ` Praveen Talari
2025-04-23 5:36 ` Viresh Kumar
2025-04-23 6:28 ` Praveen Talari
2025-04-18 15:12 ` [PATCH v2 2/9] dt-bindings: serial: describe SA8255p Praveen Talari
2025-04-25 10:12 ` Krzysztof Kozlowski
2025-04-25 11:01 ` Praveen Talari [this message]
2025-04-18 15:12 ` [PATCH v2 3/9] dt-bindings: qcom: geni-se: " Praveen Talari
2025-04-25 10:16 ` Krzysztof Kozlowski
2025-04-25 11:00 ` Praveen Talari
2025-04-18 15:12 ` [PATCH v2 4/9] soc: qcom: geni-se: Enable QUPs on SA8255p Qualcomm platforms Praveen Talari
2025-04-18 15:12 ` [PATCH v2 5/9] serial: qcom-geni: move resource initialization to separate function Praveen Talari
2025-04-18 15:12 ` [PATCH v2 6/9] serial: qcom-geni: move resource control logic to separate functions Praveen Talari
2025-04-18 15:12 ` [PATCH v2 7/9] serial: qcom-geni: move clock-rate logic to separate function Praveen Talari
2025-04-18 15:12 ` [PATCH v2 8/9] serial: qcom-geni: Enable PM runtime for serial driver Praveen Talari
2025-04-18 15:12 ` [PATCH v2 9/9] serial: qcom-geni: Enable Serial on SA8255p Qualcomm platforms Praveen Talari
2025-04-23 13:01 ` [PATCH v2 0/9] Enable QUPs and " Konrad Dybcio
2025-04-25 14:18 ` Praveen Talari
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5d3033e7-0798-4246-a6ea-74ead8485053@quicinc.com \
--to=quic_ptalari@quicinc.com \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=djaggi@quicinc.com \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=nm@ti.com \
--cc=psodagud@quicinc.com \
--cc=quic_arandive@quicinc.com \
--cc=quic_mnaresh@quicinc.com \
--cc=quic_msavaliy@quicinc.com \
--cc=quic_nkela@quicinc.com \
--cc=quic_shazhuss@quicinc.com \
--cc=quic_vtanuku@quicinc.com \
--cc=rafael@kernel.org \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
--cc=vireshk@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox