From: Tengfei Fan <quic_tengfan@quicinc.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
<agross@kernel.org>, <andersson@kernel.org>,
<konrad.dybcio@linaro.org>, <robh+dt@kernel.org>,
<krzysztof.kozlowski+dt@linaro.org>, <conor+dt@kernel.org>,
<tglx@linutronix.de>
Cc: <linux-arm-msm@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <-cc=kernel@quicinc.com>
Subject: Re: [PATCH 12/16] arm64: dts: qcom: sm8550-aim300: enable PMIC Volume and Power buttons
Date: Tue, 21 Nov 2023 09:03:39 +0800 [thread overview]
Message-ID: <40b86f99-3d55-4237-8638-de7efacfc307@quicinc.com> (raw)
In-Reply-To: <a9cac494-08df-4a0d-9071-b91b04622052@linaro.org>
在 11/17/2023 6:32 PM, Krzysztof Kozlowski 写道:
> On 17/11/2023 11:18, Tengfei Fan wrote:
>> The Volume Down & Power buttons are controlled by the PMIC via the PON
>> hardware, and the Volume Up is connected to a PMIC gpio.
>>
>> Enable the necessary hardware and setup the GPIO state for the Volume Up
>> gpio key.
>>
>> Signed-off-by: Tengfei Fan <quic_tengfan@quicinc.com>
>> ---
>
> No, really, necessary hardware? So why it is missing in the previous patch?
>
> Stop useless splitting of work which is done. You cannot have "release
> late, release often". The rule is: "release early, release often".
>
> NAK.
>
> Best regards,
> Krzysztof
>
Hi Krzysztof,
In next version patch series, I'm going to combine all the splited
functions into one patch.
--
Thx and BRs,
Tengfei Fan
next prev parent reply other threads:[~2023-11-21 1:03 UTC|newest]
Thread overview: 65+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-17 10:18 [PATCH 00/16] arm64: qcom: add sm8550-aim300 board support Tengfei Fan
2023-11-17 10:18 ` [PATCH 01/16] dt-bindings: arm: qcom: add SM8550 AIM300 Tengfei Fan
2023-11-17 10:22 ` Krzysztof Kozlowski
2023-11-20 8:53 ` Krzysztof Kozlowski
2023-11-21 0:30 ` Tengfei Fan
2023-11-21 7:18 ` Krzysztof Kozlowski
2023-11-22 19:35 ` Konrad Dybcio
2023-11-24 2:31 ` Tengfei Fan
2023-11-24 7:47 ` Krzysztof Kozlowski
2023-11-24 10:11 ` Tengfei Fan
2023-11-17 10:18 ` [PATCH 02/16] dt-bindings: interrupt-controller: qcom,pdc: document qcom,sm8550-pdc Tengfei Fan
2023-11-17 10:23 ` Krzysztof Kozlowski
2023-11-21 0:33 ` Tengfei Fan
2023-11-17 10:18 ` [PATCH 03/16] arm64: dts: qcom: sm8550: update Soundwire node name Tengfei Fan
2023-11-17 10:24 ` Krzysztof Kozlowski
2023-11-21 0:35 ` Tengfei Fan
2023-11-17 10:18 ` [PATCH 04/16] arm64: dts: qcom: sm8550: remove address/size-cells from pwm Tengfei Fan
2023-11-17 10:25 ` Dmitry Baryshkov
2023-11-17 10:18 ` [PATCH 05/16] arm64: dts: qcom: sm8550: remove address/size-cells from mdss_dsi1 Tengfei Fan
2023-11-17 10:24 ` Dmitry Baryshkov
2023-11-17 10:28 ` Dmitry Baryshkov
2023-11-17 10:18 ` [PATCH 06/16] arm64: dts: qcom: sm8550-aim300: add SM8550 AIM300 Tengfei Fan
2023-11-17 10:28 ` Dmitry Baryshkov
2023-11-21 0:38 ` Tengfei Fan
2023-11-21 2:52 ` Tengfei Fan
2023-11-17 10:18 ` [PATCH 07/16] arm64: dts: qcom: sm8550-aim300: add PCIe0 Tengfei Fan
2023-11-17 10:29 ` Dmitry Baryshkov
2023-11-17 10:41 ` neil.armstrong
2023-11-18 0:08 ` Konrad Dybcio
2023-11-19 17:59 ` Neil Armstrong
2023-11-21 0:40 ` Tengfei Fan
2023-11-17 10:30 ` Krzysztof Kozlowski
2023-11-21 0:51 ` Tengfei Fan
2023-11-17 10:18 ` [PATCH 08/16] arm64: dts: qcom: sm8550-aim300: add WCD9385 audio-codec Tengfei Fan
2023-11-17 10:31 ` Krzysztof Kozlowski
2023-11-21 0:54 ` Tengfei Fan
2023-11-17 10:18 ` [PATCH 09/16] arm64: dts: qcom: sm8550-aim300: add flash LEDs Tengfei Fan
2023-11-17 10:34 ` Krzysztof Kozlowski
2023-11-21 0:54 ` Tengfei Fan
2023-11-17 10:18 ` [PATCH 10/16] arm64: dts: qcom: sm8550-aim300: add display and panel Tengfei Fan
2023-11-17 10:30 ` Dmitry Baryshkov
2023-11-21 0:56 ` Tengfei Fan
2023-11-17 10:31 ` Krzysztof Kozlowski
2023-11-21 1:01 ` Tengfei Fan
2023-11-17 10:18 ` [PATCH 11/16] arm64: dts: qcom: sm8550-aim300: add notification RGB LED Tengfei Fan
2023-11-17 10:31 ` Krzysztof Kozlowski
2023-11-21 1:01 ` Tengfei Fan
2023-11-17 10:18 ` [PATCH 12/16] arm64: dts: qcom: sm8550-aim300: enable PMIC Volume and Power buttons Tengfei Fan
2023-11-17 10:32 ` Krzysztof Kozlowski
2023-11-21 1:03 ` Tengfei Fan [this message]
2023-11-17 10:18 ` [PATCH 13/16] arm64: dts: qcom: sm8550-aim300: add WSA8845 speakers Tengfei Fan
2023-11-17 10:33 ` Krzysztof Kozlowski
2023-11-21 1:04 ` Tengfei Fan
2023-11-17 10:18 ` [PATCH 14/16] arm64: dts: qcom: sm8550-aim300: add sound card Tengfei Fan
2023-11-17 10:33 ` Krzysztof Kozlowski
2023-11-21 1:04 ` Tengfei Fan
2023-11-17 10:18 ` [PATCH 15/16] arm64: dts: qcom: sm8550-aim300: add pmic glink port/endpoints Tengfei Fan
2023-11-17 10:32 ` Dmitry Baryshkov
2023-11-21 1:06 ` Tengfei Fan
2023-11-28 8:11 ` Tengfei Fan
2023-12-13 10:04 ` Dmitry Baryshkov
2024-02-21 7:48 ` Tengfei Fan
2023-11-17 10:18 ` [PATCH 16/16] arm64: dts: qcom: sm8550-aim300: add bluetooth support Tengfei Fan
2023-11-17 10:33 ` Krzysztof Kozlowski
2023-11-21 1:06 ` Tengfei Fan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=40b86f99-3d55-4237-8638-de7efacfc307@quicinc.com \
--to=quic_tengfan@quicinc.com \
--cc=-cc=kernel@quicinc.com \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox