From: Konrad Dybcio <konrad.dybcio@linaro.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] ARM: dts: qcom: msm8974: remove superfluous "input-enable"
Date: Tue, 11 Apr 2023 21:59:51 +0200 [thread overview]
Message-ID: <45ce0cf4-b00a-6309-616f-d8dd8cb91c2e@linaro.org> (raw)
In-Reply-To: <20230410181005.25853-3-krzysztof.kozlowski@linaro.org>
On 10.04.2023 20:10, Krzysztof Kozlowski wrote:
> Pin configuration property "input-enable" was used with the intention to
> disable the output, but this is done by default by Linux drivers. Since
> patch ("dt-bindings: pinctrl: qcom: tlmm should use output-disable, not
> input-enable") the property is not accepted anymore.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Konrad
> arch/arm/boot/dts/qcom-msm8974-lge-nexus5-hammerhead.dts | 2 --
> arch/arm/boot/dts/qcom-msm8974-sony-xperia-rhine.dtsi | 1 -
> arch/arm/boot/dts/qcom-msm8974pro-oneplus-bacon.dts | 1 -
> arch/arm/boot/dts/qcom-msm8974pro-samsung-klte.dts | 4 ----
> .../boot/dts/qcom-msm8974pro-sony-xperia-shinano-castor.dts | 1 -
> 5 files changed, 9 deletions(-)
>
> diff --git a/arch/arm/boot/dts/qcom-msm8974-lge-nexus5-hammerhead.dts b/arch/arm/boot/dts/qcom-msm8974-lge-nexus5-hammerhead.dts
> index ab35f2d644c0..861695cecf84 100644
> --- a/arch/arm/boot/dts/qcom-msm8974-lge-nexus5-hammerhead.dts
> +++ b/arch/arm/boot/dts/qcom-msm8974-lge-nexus5-hammerhead.dts
> @@ -592,7 +592,6 @@ mpu6515_pin: mpu6515-state {
> pins = "gpio73";
> function = "gpio";
> bias-disable;
> - input-enable;
> };
>
> touch_pin: touch-state {
> @@ -602,7 +601,6 @@ int-pins {
>
> drive-strength = <2>;
> bias-disable;
> - input-enable;
> };
>
> reset-pins {
> diff --git a/arch/arm/boot/dts/qcom-msm8974-sony-xperia-rhine.dtsi b/arch/arm/boot/dts/qcom-msm8974-sony-xperia-rhine.dtsi
> index d3bec03b126c..68a2f9094e53 100644
> --- a/arch/arm/boot/dts/qcom-msm8974-sony-xperia-rhine.dtsi
> +++ b/arch/arm/boot/dts/qcom-msm8974-sony-xperia-rhine.dtsi
> @@ -433,7 +433,6 @@ ts_int_pin: touch-int-state {
> function = "gpio";
> drive-strength = <2>;
> bias-disable;
> - input-enable;
> };
>
> sdc1_on: sdc1-on-state {
> diff --git a/arch/arm/boot/dts/qcom-msm8974pro-oneplus-bacon.dts b/arch/arm/boot/dts/qcom-msm8974pro-oneplus-bacon.dts
> index 8d2a054d8fee..8230d0e1d95d 100644
> --- a/arch/arm/boot/dts/qcom-msm8974pro-oneplus-bacon.dts
> +++ b/arch/arm/boot/dts/qcom-msm8974pro-oneplus-bacon.dts
> @@ -461,7 +461,6 @@ int-pins {
> function = "gpio";
> drive-strength = <2>;
> bias-disable;
> - input-enable;
> };
>
> reset-pins {
> diff --git a/arch/arm/boot/dts/qcom-msm8974pro-samsung-klte.dts b/arch/arm/boot/dts/qcom-msm8974pro-samsung-klte.dts
> index b9698ffb66ca..eb505d6d7f31 100644
> --- a/arch/arm/boot/dts/qcom-msm8974pro-samsung-klte.dts
> +++ b/arch/arm/boot/dts/qcom-msm8974pro-samsung-klte.dts
> @@ -704,7 +704,6 @@ hostwake-pins {
> pins = "gpio75";
> function = "gpio";
> drive-strength = <16>;
> - input-enable;
> };
>
> devwake-pins {
> @@ -760,14 +759,12 @@ cmd-data-pins {
> i2c_touchkey_pins: i2c-touchkey-state {
> pins = "gpio95", "gpio96";
> function = "gpio";
> - input-enable;
> bias-pull-up;
> };
>
> i2c_led_gpioex_pins: i2c-led-gpioex-state {
> pins = "gpio120", "gpio121";
> function = "gpio";
> - input-enable;
> bias-pull-down;
> };
>
> @@ -781,7 +778,6 @@ gpioex_pin: gpioex-state {
> wifi_pin: wifi-state {
> pins = "gpio92";
> function = "gpio";
> - input-enable;
> bias-pull-down;
> };
>
> diff --git a/arch/arm/boot/dts/qcom-msm8974pro-sony-xperia-shinano-castor.dts b/arch/arm/boot/dts/qcom-msm8974pro-sony-xperia-shinano-castor.dts
> index 04bc58d87abf..0f650ed31005 100644
> --- a/arch/arm/boot/dts/qcom-msm8974pro-sony-xperia-shinano-castor.dts
> +++ b/arch/arm/boot/dts/qcom-msm8974pro-sony-xperia-shinano-castor.dts
> @@ -631,7 +631,6 @@ ts_int_pin: ts-int-pin-state {
> function = "gpio";
> drive-strength = <2>;
> bias-disable;
> - input-enable;
> };
>
> bt_host_wake_pin: bt-host-wake-state {
next prev parent reply other threads:[~2023-04-11 20:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-10 18:10 [PATCH 1/3] ARM: dts: qcom: apq8026: remove superfluous "input-enable" Krzysztof Kozlowski
2023-04-10 18:10 ` [PATCH 2/3] ARM: dts: qcom: mdm9615: " Krzysztof Kozlowski
2023-04-11 19:59 ` Konrad Dybcio
2023-04-10 18:10 ` [PATCH 3/3] ARM: dts: qcom: msm8974: " Krzysztof Kozlowski
2023-04-11 19:59 ` Konrad Dybcio [this message]
2023-04-11 11:05 ` [PATCH 1/3] ARM: dts: qcom: apq8026: " Konrad Dybcio
2023-05-23 3:03 ` (subset) " Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45ce0cf4-b00a-6309-616f-d8dd8cb91c2e@linaro.org \
--to=konrad.dybcio@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox