* [PATCH 2/3] ARM: dts: qcom: mdm9615: remove superfluous "input-enable"
2023-04-10 18:10 [PATCH 1/3] ARM: dts: qcom: apq8026: remove superfluous "input-enable" Krzysztof Kozlowski
@ 2023-04-10 18:10 ` Krzysztof Kozlowski
2023-04-11 19:59 ` Konrad Dybcio
2023-04-10 18:10 ` [PATCH 3/3] ARM: dts: qcom: msm8974: " Krzysztof Kozlowski
` (2 subsequent siblings)
3 siblings, 1 reply; 7+ messages in thread
From: Krzysztof Kozlowski @ 2023-04-10 18:10 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, linux-arm-msm, devicetree, linux-kernel
Cc: Krzysztof Kozlowski
Pin configuration property "input-enable" was used with the intention to
disable the output, but this is done by default by Linux drivers. Since
patch ("dt-bindings: pinctrl: qcom: tlmm should use output-disable, not
input-enable") the property is not accepted anymore.
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
arch/arm/boot/dts/qcom-mdm9615-wp8548-mangoh-green.dts | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/arm/boot/dts/qcom-mdm9615-wp8548-mangoh-green.dts b/arch/arm/boot/dts/qcom-mdm9615-wp8548-mangoh-green.dts
index a8304769b509..b269fdca1460 100644
--- a/arch/arm/boot/dts/qcom-mdm9615-wp8548-mangoh-green.dts
+++ b/arch/arm/boot/dts/qcom-mdm9615-wp8548-mangoh-green.dts
@@ -49,7 +49,6 @@ gpioext1_pins: gpioext1-state {
gpioext1-pins {
pins = "gpio2";
function = "gpio";
- input-enable;
bias-disable;
};
};
--
2.34.1
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH 2/3] ARM: dts: qcom: mdm9615: remove superfluous "input-enable"
2023-04-10 18:10 ` [PATCH 2/3] ARM: dts: qcom: mdm9615: " Krzysztof Kozlowski
@ 2023-04-11 19:59 ` Konrad Dybcio
0 siblings, 0 replies; 7+ messages in thread
From: Konrad Dybcio @ 2023-04-11 19:59 UTC (permalink / raw)
To: Krzysztof Kozlowski, Andy Gross, Bjorn Andersson, Rob Herring,
Krzysztof Kozlowski, linux-arm-msm, devicetree, linux-kernel
On 10.04.2023 20:10, Krzysztof Kozlowski wrote:
> Pin configuration property "input-enable" was used with the intention to
> disable the output, but this is done by default by Linux drivers. Since
> patch ("dt-bindings: pinctrl: qcom: tlmm should use output-disable, not
> input-enable") the property is not accepted anymore.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Konrad
> arch/arm/boot/dts/qcom-mdm9615-wp8548-mangoh-green.dts | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/qcom-mdm9615-wp8548-mangoh-green.dts b/arch/arm/boot/dts/qcom-mdm9615-wp8548-mangoh-green.dts
> index a8304769b509..b269fdca1460 100644
> --- a/arch/arm/boot/dts/qcom-mdm9615-wp8548-mangoh-green.dts
> +++ b/arch/arm/boot/dts/qcom-mdm9615-wp8548-mangoh-green.dts
> @@ -49,7 +49,6 @@ gpioext1_pins: gpioext1-state {
> gpioext1-pins {
> pins = "gpio2";
> function = "gpio";
> - input-enable;
> bias-disable;
> };
> };
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH 3/3] ARM: dts: qcom: msm8974: remove superfluous "input-enable"
2023-04-10 18:10 [PATCH 1/3] ARM: dts: qcom: apq8026: remove superfluous "input-enable" Krzysztof Kozlowski
2023-04-10 18:10 ` [PATCH 2/3] ARM: dts: qcom: mdm9615: " Krzysztof Kozlowski
@ 2023-04-10 18:10 ` Krzysztof Kozlowski
2023-04-11 19:59 ` Konrad Dybcio
2023-04-11 11:05 ` [PATCH 1/3] ARM: dts: qcom: apq8026: " Konrad Dybcio
2023-05-23 3:03 ` (subset) " Bjorn Andersson
3 siblings, 1 reply; 7+ messages in thread
From: Krzysztof Kozlowski @ 2023-04-10 18:10 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, linux-arm-msm, devicetree, linux-kernel
Cc: Krzysztof Kozlowski
Pin configuration property "input-enable" was used with the intention to
disable the output, but this is done by default by Linux drivers. Since
patch ("dt-bindings: pinctrl: qcom: tlmm should use output-disable, not
input-enable") the property is not accepted anymore.
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
arch/arm/boot/dts/qcom-msm8974-lge-nexus5-hammerhead.dts | 2 --
arch/arm/boot/dts/qcom-msm8974-sony-xperia-rhine.dtsi | 1 -
arch/arm/boot/dts/qcom-msm8974pro-oneplus-bacon.dts | 1 -
arch/arm/boot/dts/qcom-msm8974pro-samsung-klte.dts | 4 ----
.../boot/dts/qcom-msm8974pro-sony-xperia-shinano-castor.dts | 1 -
5 files changed, 9 deletions(-)
diff --git a/arch/arm/boot/dts/qcom-msm8974-lge-nexus5-hammerhead.dts b/arch/arm/boot/dts/qcom-msm8974-lge-nexus5-hammerhead.dts
index ab35f2d644c0..861695cecf84 100644
--- a/arch/arm/boot/dts/qcom-msm8974-lge-nexus5-hammerhead.dts
+++ b/arch/arm/boot/dts/qcom-msm8974-lge-nexus5-hammerhead.dts
@@ -592,7 +592,6 @@ mpu6515_pin: mpu6515-state {
pins = "gpio73";
function = "gpio";
bias-disable;
- input-enable;
};
touch_pin: touch-state {
@@ -602,7 +601,6 @@ int-pins {
drive-strength = <2>;
bias-disable;
- input-enable;
};
reset-pins {
diff --git a/arch/arm/boot/dts/qcom-msm8974-sony-xperia-rhine.dtsi b/arch/arm/boot/dts/qcom-msm8974-sony-xperia-rhine.dtsi
index d3bec03b126c..68a2f9094e53 100644
--- a/arch/arm/boot/dts/qcom-msm8974-sony-xperia-rhine.dtsi
+++ b/arch/arm/boot/dts/qcom-msm8974-sony-xperia-rhine.dtsi
@@ -433,7 +433,6 @@ ts_int_pin: touch-int-state {
function = "gpio";
drive-strength = <2>;
bias-disable;
- input-enable;
};
sdc1_on: sdc1-on-state {
diff --git a/arch/arm/boot/dts/qcom-msm8974pro-oneplus-bacon.dts b/arch/arm/boot/dts/qcom-msm8974pro-oneplus-bacon.dts
index 8d2a054d8fee..8230d0e1d95d 100644
--- a/arch/arm/boot/dts/qcom-msm8974pro-oneplus-bacon.dts
+++ b/arch/arm/boot/dts/qcom-msm8974pro-oneplus-bacon.dts
@@ -461,7 +461,6 @@ int-pins {
function = "gpio";
drive-strength = <2>;
bias-disable;
- input-enable;
};
reset-pins {
diff --git a/arch/arm/boot/dts/qcom-msm8974pro-samsung-klte.dts b/arch/arm/boot/dts/qcom-msm8974pro-samsung-klte.dts
index b9698ffb66ca..eb505d6d7f31 100644
--- a/arch/arm/boot/dts/qcom-msm8974pro-samsung-klte.dts
+++ b/arch/arm/boot/dts/qcom-msm8974pro-samsung-klte.dts
@@ -704,7 +704,6 @@ hostwake-pins {
pins = "gpio75";
function = "gpio";
drive-strength = <16>;
- input-enable;
};
devwake-pins {
@@ -760,14 +759,12 @@ cmd-data-pins {
i2c_touchkey_pins: i2c-touchkey-state {
pins = "gpio95", "gpio96";
function = "gpio";
- input-enable;
bias-pull-up;
};
i2c_led_gpioex_pins: i2c-led-gpioex-state {
pins = "gpio120", "gpio121";
function = "gpio";
- input-enable;
bias-pull-down;
};
@@ -781,7 +778,6 @@ gpioex_pin: gpioex-state {
wifi_pin: wifi-state {
pins = "gpio92";
function = "gpio";
- input-enable;
bias-pull-down;
};
diff --git a/arch/arm/boot/dts/qcom-msm8974pro-sony-xperia-shinano-castor.dts b/arch/arm/boot/dts/qcom-msm8974pro-sony-xperia-shinano-castor.dts
index 04bc58d87abf..0f650ed31005 100644
--- a/arch/arm/boot/dts/qcom-msm8974pro-sony-xperia-shinano-castor.dts
+++ b/arch/arm/boot/dts/qcom-msm8974pro-sony-xperia-shinano-castor.dts
@@ -631,7 +631,6 @@ ts_int_pin: ts-int-pin-state {
function = "gpio";
drive-strength = <2>;
bias-disable;
- input-enable;
};
bt_host_wake_pin: bt-host-wake-state {
--
2.34.1
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH 3/3] ARM: dts: qcom: msm8974: remove superfluous "input-enable"
2023-04-10 18:10 ` [PATCH 3/3] ARM: dts: qcom: msm8974: " Krzysztof Kozlowski
@ 2023-04-11 19:59 ` Konrad Dybcio
0 siblings, 0 replies; 7+ messages in thread
From: Konrad Dybcio @ 2023-04-11 19:59 UTC (permalink / raw)
To: Krzysztof Kozlowski, Andy Gross, Bjorn Andersson, Rob Herring,
Krzysztof Kozlowski, linux-arm-msm, devicetree, linux-kernel
On 10.04.2023 20:10, Krzysztof Kozlowski wrote:
> Pin configuration property "input-enable" was used with the intention to
> disable the output, but this is done by default by Linux drivers. Since
> patch ("dt-bindings: pinctrl: qcom: tlmm should use output-disable, not
> input-enable") the property is not accepted anymore.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Konrad
> arch/arm/boot/dts/qcom-msm8974-lge-nexus5-hammerhead.dts | 2 --
> arch/arm/boot/dts/qcom-msm8974-sony-xperia-rhine.dtsi | 1 -
> arch/arm/boot/dts/qcom-msm8974pro-oneplus-bacon.dts | 1 -
> arch/arm/boot/dts/qcom-msm8974pro-samsung-klte.dts | 4 ----
> .../boot/dts/qcom-msm8974pro-sony-xperia-shinano-castor.dts | 1 -
> 5 files changed, 9 deletions(-)
>
> diff --git a/arch/arm/boot/dts/qcom-msm8974-lge-nexus5-hammerhead.dts b/arch/arm/boot/dts/qcom-msm8974-lge-nexus5-hammerhead.dts
> index ab35f2d644c0..861695cecf84 100644
> --- a/arch/arm/boot/dts/qcom-msm8974-lge-nexus5-hammerhead.dts
> +++ b/arch/arm/boot/dts/qcom-msm8974-lge-nexus5-hammerhead.dts
> @@ -592,7 +592,6 @@ mpu6515_pin: mpu6515-state {
> pins = "gpio73";
> function = "gpio";
> bias-disable;
> - input-enable;
> };
>
> touch_pin: touch-state {
> @@ -602,7 +601,6 @@ int-pins {
>
> drive-strength = <2>;
> bias-disable;
> - input-enable;
> };
>
> reset-pins {
> diff --git a/arch/arm/boot/dts/qcom-msm8974-sony-xperia-rhine.dtsi b/arch/arm/boot/dts/qcom-msm8974-sony-xperia-rhine.dtsi
> index d3bec03b126c..68a2f9094e53 100644
> --- a/arch/arm/boot/dts/qcom-msm8974-sony-xperia-rhine.dtsi
> +++ b/arch/arm/boot/dts/qcom-msm8974-sony-xperia-rhine.dtsi
> @@ -433,7 +433,6 @@ ts_int_pin: touch-int-state {
> function = "gpio";
> drive-strength = <2>;
> bias-disable;
> - input-enable;
> };
>
> sdc1_on: sdc1-on-state {
> diff --git a/arch/arm/boot/dts/qcom-msm8974pro-oneplus-bacon.dts b/arch/arm/boot/dts/qcom-msm8974pro-oneplus-bacon.dts
> index 8d2a054d8fee..8230d0e1d95d 100644
> --- a/arch/arm/boot/dts/qcom-msm8974pro-oneplus-bacon.dts
> +++ b/arch/arm/boot/dts/qcom-msm8974pro-oneplus-bacon.dts
> @@ -461,7 +461,6 @@ int-pins {
> function = "gpio";
> drive-strength = <2>;
> bias-disable;
> - input-enable;
> };
>
> reset-pins {
> diff --git a/arch/arm/boot/dts/qcom-msm8974pro-samsung-klte.dts b/arch/arm/boot/dts/qcom-msm8974pro-samsung-klte.dts
> index b9698ffb66ca..eb505d6d7f31 100644
> --- a/arch/arm/boot/dts/qcom-msm8974pro-samsung-klte.dts
> +++ b/arch/arm/boot/dts/qcom-msm8974pro-samsung-klte.dts
> @@ -704,7 +704,6 @@ hostwake-pins {
> pins = "gpio75";
> function = "gpio";
> drive-strength = <16>;
> - input-enable;
> };
>
> devwake-pins {
> @@ -760,14 +759,12 @@ cmd-data-pins {
> i2c_touchkey_pins: i2c-touchkey-state {
> pins = "gpio95", "gpio96";
> function = "gpio";
> - input-enable;
> bias-pull-up;
> };
>
> i2c_led_gpioex_pins: i2c-led-gpioex-state {
> pins = "gpio120", "gpio121";
> function = "gpio";
> - input-enable;
> bias-pull-down;
> };
>
> @@ -781,7 +778,6 @@ gpioex_pin: gpioex-state {
> wifi_pin: wifi-state {
> pins = "gpio92";
> function = "gpio";
> - input-enable;
> bias-pull-down;
> };
>
> diff --git a/arch/arm/boot/dts/qcom-msm8974pro-sony-xperia-shinano-castor.dts b/arch/arm/boot/dts/qcom-msm8974pro-sony-xperia-shinano-castor.dts
> index 04bc58d87abf..0f650ed31005 100644
> --- a/arch/arm/boot/dts/qcom-msm8974pro-sony-xperia-shinano-castor.dts
> +++ b/arch/arm/boot/dts/qcom-msm8974pro-sony-xperia-shinano-castor.dts
> @@ -631,7 +631,6 @@ ts_int_pin: ts-int-pin-state {
> function = "gpio";
> drive-strength = <2>;
> bias-disable;
> - input-enable;
> };
>
> bt_host_wake_pin: bt-host-wake-state {
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 1/3] ARM: dts: qcom: apq8026: remove superfluous "input-enable"
2023-04-10 18:10 [PATCH 1/3] ARM: dts: qcom: apq8026: remove superfluous "input-enable" Krzysztof Kozlowski
2023-04-10 18:10 ` [PATCH 2/3] ARM: dts: qcom: mdm9615: " Krzysztof Kozlowski
2023-04-10 18:10 ` [PATCH 3/3] ARM: dts: qcom: msm8974: " Krzysztof Kozlowski
@ 2023-04-11 11:05 ` Konrad Dybcio
2023-05-23 3:03 ` (subset) " Bjorn Andersson
3 siblings, 0 replies; 7+ messages in thread
From: Konrad Dybcio @ 2023-04-11 11:05 UTC (permalink / raw)
To: Krzysztof Kozlowski, Andy Gross, Bjorn Andersson, Rob Herring,
Krzysztof Kozlowski, linux-arm-msm, devicetree, linux-kernel
On 10.04.2023 20:10, Krzysztof Kozlowski wrote:
> Pin configuration property "input-enable" was used with the intention to
> disable the output, but this is done by default by Linux drivers. Since
> patch ("dt-bindings: pinctrl: qcom: tlmm should use output-disable, not
> input-enable") the property is not accepted anymore.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Konrad
> arch/arm/boot/dts/qcom-apq8026-asus-sparrow.dts | 2 --
> arch/arm/boot/dts/qcom-apq8026-huawei-sturgeon.dts | 1 -
> arch/arm/boot/dts/qcom-apq8026-lg-lenok.dts | 3 ---
> 3 files changed, 6 deletions(-)
>
> diff --git a/arch/arm/boot/dts/qcom-apq8026-asus-sparrow.dts b/arch/arm/boot/dts/qcom-apq8026-asus-sparrow.dts
> index 7a80e1c9f126..aa0e0e8d2a97 100644
> --- a/arch/arm/boot/dts/qcom-apq8026-asus-sparrow.dts
> +++ b/arch/arm/boot/dts/qcom-apq8026-asus-sparrow.dts
> @@ -268,7 +268,6 @@ bluetooth_default_state: bluetooth-default-state {
> function = "gpio";
> drive-strength = <8>;
> bias-disable;
> - input-enable;
> };
>
> wlan_hostwake_default_state: wlan-hostwake-default-state {
> @@ -276,7 +275,6 @@ wlan_hostwake_default_state: wlan-hostwake-default-state {
> function = "gpio";
> drive-strength = <2>;
> bias-disable;
> - input-enable;
> };
>
> wlan_regulator_default_state: wlan-regulator-default-state {
> diff --git a/arch/arm/boot/dts/qcom-apq8026-huawei-sturgeon.dts b/arch/arm/boot/dts/qcom-apq8026-huawei-sturgeon.dts
> index d64096028ab1..5593a3a60d6c 100644
> --- a/arch/arm/boot/dts/qcom-apq8026-huawei-sturgeon.dts
> +++ b/arch/arm/boot/dts/qcom-apq8026-huawei-sturgeon.dts
> @@ -352,7 +352,6 @@ wlan_hostwake_default_state: wlan-hostwake-default-state {
> function = "gpio";
> drive-strength = <2>;
> bias-disable;
> - input-enable;
> };
>
> wlan_regulator_default_state: wlan-regulator-default-state {
> diff --git a/arch/arm/boot/dts/qcom-apq8026-lg-lenok.dts b/arch/arm/boot/dts/qcom-apq8026-lg-lenok.dts
> index b82381229adf..b887e5361ec3 100644
> --- a/arch/arm/boot/dts/qcom-apq8026-lg-lenok.dts
> +++ b/arch/arm/boot/dts/qcom-apq8026-lg-lenok.dts
> @@ -307,7 +307,6 @@ bluetooth_default_state: bluetooth-default-state {
> function = "gpio";
> drive-strength = <2>;
> bias-disable;
> - input-enable;
> };
>
> touch_pins: touch-state {
> @@ -317,7 +316,6 @@ irq-pins {
>
> drive-strength = <8>;
> bias-pull-down;
> - input-enable;
> };
>
> reset-pins {
> @@ -335,7 +333,6 @@ wlan_hostwake_default_state: wlan-hostwake-default-state {
> function = "gpio";
> drive-strength = <2>;
> bias-disable;
> - input-enable;
> };
>
> wlan_regulator_default_state: wlan-regulator-default-state {
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: (subset) [PATCH 1/3] ARM: dts: qcom: apq8026: remove superfluous "input-enable"
2023-04-10 18:10 [PATCH 1/3] ARM: dts: qcom: apq8026: remove superfluous "input-enable" Krzysztof Kozlowski
` (2 preceding siblings ...)
2023-04-11 11:05 ` [PATCH 1/3] ARM: dts: qcom: apq8026: " Konrad Dybcio
@ 2023-05-23 3:03 ` Bjorn Andersson
3 siblings, 0 replies; 7+ messages in thread
From: Bjorn Andersson @ 2023-05-23 3:03 UTC (permalink / raw)
To: linux-kernel, Krzysztof Kozlowski, Krzysztof Kozlowski,
Konrad Dybcio, Andy Gross, devicetree, linux-arm-msm, Rob Herring
On Mon, 10 Apr 2023 20:10:03 +0200, Krzysztof Kozlowski wrote:
> Pin configuration property "input-enable" was used with the intention to
> disable the output, but this is done by default by Linux drivers. Since
> patch ("dt-bindings: pinctrl: qcom: tlmm should use output-disable, not
> input-enable") the property is not accepted anymore.
>
>
Applied, thanks!
[1/3] ARM: dts: qcom: apq8026: remove superfluous "input-enable"
commit: 18f341061262a7a63bc8b5c9ef94a342ac2673a2
[2/3] ARM: dts: qcom: mdm9615: remove superfluous "input-enable"
commit: da50416fb1fa7502a52ad38c0e9ff196d9f56ac9
[3/3] ARM: dts: qcom: msm8974: remove superfluous "input-enable"
commit: 033553c04b02b450261f60d5f1b0e5948cd197bb
Best regards,
--
Bjorn Andersson <andersson@kernel.org>
^ permalink raw reply [flat|nested] 7+ messages in thread