* [PATCH -next] drm/msm: Use devm_platform_ioremap_resource_byname()
@ 2024-08-28 8:48 Jinjie Ruan
2024-08-28 20:42 ` Abhinav Kumar
2024-08-29 10:06 ` Dmitry Baryshkov
0 siblings, 2 replies; 3+ messages in thread
From: Jinjie Ruan @ 2024-08-28 8:48 UTC (permalink / raw)
To: robdclark, quic_abhinavk, dmitry.baryshkov, sean, marijn.suijten,
airlied, daniel, linux-arm-msm, dri-devel, freedreno,
linux-kernel
Cc: ruanjinjie
platform_get_resource_byname() and devm_ioremap_resource() can be
replaced by devm_platform_ioremap_resource_byname(), which can
simplify the code logic a bit, No functional change here.
Signed-off-by: Jinjie Ruan <ruanjinjie@huawei.com>
---
drivers/gpu/drm/msm/msm_io_utils.c | 8 +-------
1 file changed, 1 insertion(+), 7 deletions(-)
diff --git a/drivers/gpu/drm/msm/msm_io_utils.c b/drivers/gpu/drm/msm/msm_io_utils.c
index afedd61c3e28..6f7933f01ae6 100644
--- a/drivers/gpu/drm/msm/msm_io_utils.c
+++ b/drivers/gpu/drm/msm/msm_io_utils.c
@@ -54,13 +54,7 @@ void __iomem *msm_ioremap_mdss(struct platform_device *mdss_pdev,
struct platform_device *pdev,
const char *name)
{
- struct resource *res;
-
- res = platform_get_resource_byname(mdss_pdev, IORESOURCE_MEM, name);
- if (!res)
- return ERR_PTR(-EINVAL);
-
- return devm_ioremap_resource(&pdev->dev, res);
+ return devm_platform_ioremap_resource_byname(mdss_pdev, name);
}
static void __iomem *_msm_ioremap(struct platform_device *pdev, const char *name,
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH -next] drm/msm: Use devm_platform_ioremap_resource_byname()
2024-08-28 8:48 [PATCH -next] drm/msm: Use devm_platform_ioremap_resource_byname() Jinjie Ruan
@ 2024-08-28 20:42 ` Abhinav Kumar
2024-08-29 10:06 ` Dmitry Baryshkov
1 sibling, 0 replies; 3+ messages in thread
From: Abhinav Kumar @ 2024-08-28 20:42 UTC (permalink / raw)
To: Jinjie Ruan, robdclark, dmitry.baryshkov, sean, marijn.suijten,
airlied, daniel, linux-arm-msm, dri-devel, freedreno,
linux-kernel
On 8/28/2024 1:48 AM, Jinjie Ruan wrote:
> platform_get_resource_byname() and devm_ioremap_resource() can be
> replaced by devm_platform_ioremap_resource_byname(), which can
> simplify the code logic a bit, No functional change here.
>
> Signed-off-by: Jinjie Ruan <ruanjinjie@huawei.com>
> ---
> drivers/gpu/drm/msm/msm_io_utils.c | 8 +-------
> 1 file changed, 1 insertion(+), 7 deletions(-)
>
Reviewed-by: Abhinav Kumar <quic_abhinavk@quicinc.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH -next] drm/msm: Use devm_platform_ioremap_resource_byname()
2024-08-28 8:48 [PATCH -next] drm/msm: Use devm_platform_ioremap_resource_byname() Jinjie Ruan
2024-08-28 20:42 ` Abhinav Kumar
@ 2024-08-29 10:06 ` Dmitry Baryshkov
1 sibling, 0 replies; 3+ messages in thread
From: Dmitry Baryshkov @ 2024-08-29 10:06 UTC (permalink / raw)
To: Jinjie Ruan
Cc: robdclark, quic_abhinavk, sean, marijn.suijten, airlied, daniel,
linux-arm-msm, dri-devel, freedreno, linux-kernel
On Wed, Aug 28, 2024 at 04:48:49PM GMT, Jinjie Ruan wrote:
> platform_get_resource_byname() and devm_ioremap_resource() can be
> replaced by devm_platform_ioremap_resource_byname(), which can
> simplify the code logic a bit, No functional change here.
NAK.
platform_get_resource_byname gets mdss_pdev, while devm_ function
uses pdev->dev. Passing mdss_pdev to
devm_platform_ioremap_resource_byname() means that the resource will get
lifetime management attached to the lifecycle of the other driver.
>
> Signed-off-by: Jinjie Ruan <ruanjinjie@huawei.com>
> ---
> drivers/gpu/drm/msm/msm_io_utils.c | 8 +-------
> 1 file changed, 1 insertion(+), 7 deletions(-)
>
> diff --git a/drivers/gpu/drm/msm/msm_io_utils.c b/drivers/gpu/drm/msm/msm_io_utils.c
> index afedd61c3e28..6f7933f01ae6 100644
> --- a/drivers/gpu/drm/msm/msm_io_utils.c
> +++ b/drivers/gpu/drm/msm/msm_io_utils.c
> @@ -54,13 +54,7 @@ void __iomem *msm_ioremap_mdss(struct platform_device *mdss_pdev,
> struct platform_device *pdev,
> const char *name)
> {
> - struct resource *res;
> -
> - res = platform_get_resource_byname(mdss_pdev, IORESOURCE_MEM, name);
> - if (!res)
> - return ERR_PTR(-EINVAL);
> -
> - return devm_ioremap_resource(&pdev->dev, res);
> + return devm_platform_ioremap_resource_byname(mdss_pdev, name);
> }
>
> static void __iomem *_msm_ioremap(struct platform_device *pdev, const char *name,
> --
> 2.34.1
>
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-08-29 10:07 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-08-28 8:48 [PATCH -next] drm/msm: Use devm_platform_ioremap_resource_byname() Jinjie Ruan
2024-08-28 20:42 ` Abhinav Kumar
2024-08-29 10:06 ` Dmitry Baryshkov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox