Re: [PATCH net-next v2 08/14] net: ethernet: qualcomm: Initialize PPE service code settings

[Jie Luo <quic_luoj@quicinc.com>]

On 1/10/2025 1:58 AM, Simon Horman wrote:
> On Wed, Jan 08, 2025 at 09:47:15PM +0800, Luo Jie wrote:
>> PPE service code is a special code (0-255) that is defined by PPE for
>> PPE's packet processing stages, as per the network functions required
>> for the packet.
>>
>> For packet being sent out by ARM cores on Ethernet ports, The service
>> code 1 is used as the default service code. This service code is used
>> to bypass most of packet processing stages of the PPE before the packet
>> transmitted out PPE port, since the software network stack has already
>> processed the packet.
>>
>> Signed-off-by: Luo Jie <quic_luoj@quicinc.com>
> 
> ...
> 
>> diff --git a/drivers/net/ethernet/qualcomm/ppe/ppe_config.h b/drivers/net/ethernet/qualcomm/ppe/ppe_config.h
> 
> ...
> 
>> +/**
>> + * struct ppe_sc_bypss - PPE service bypass bitmaps
> 
> nit: struct ppe_sc_bypass

OK. Will correct it.

> 
>> + * @ingress: Bitmap of features that can be bypassed on the ingress packet.
>> + * @egress: Bitmap of features that can be bypassed on the egress packet.
>> + * @counter: Bitmap of features that can be bypassed on the counter type.
>> + * @tunnel: Bitmap of features that can be bypassed on the tunnel packet.
>> + */
>> +struct ppe_sc_bypass {
>> +	DECLARE_BITMAP(ingress, PPE_SC_BYPASS_INGRESS_SIZE);
>> +	DECLARE_BITMAP(egress, PPE_SC_BYPASS_EGRESS_SIZE);
>> +	DECLARE_BITMAP(counter, PPE_SC_BYPASS_COUNTER_SIZE);
>> +	DECLARE_BITMAP(tunnel, PPE_SC_BYPASS_TUNNEL_SIZE);
>> +};
> 
> ...