* [PATCH] arm64: dts: qcom: sm8250-samsung-common: correct reserved pins
@ 2025-09-21 13:56 Eric Gonçalves
2025-09-22 9:51 ` Dmitry Baryshkov
0 siblings, 1 reply; 3+ messages in thread
From: Eric Gonçalves @ 2025-09-21 13:56 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Conor Dooley, Krzysztof Kozlowski,
Rob Herring
Cc: devicetree, linux-arm-msm, linux-kernel
The S20 series has additional reserved pins for the fingerprint sensor,
GPIO 20-23. Correct it by adding them into gpio-reserved-ranges.
Signed-off-by: Eric Gonçalves <ghatto404@gmail.com>
---
arch/arm64/boot/dts/qcom/sm8250-samsung-common.dtsi | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/qcom/sm8250-samsung-common.dtsi b/arch/arm64/boot/dts/qcom/sm8250-samsung-common.dtsi
index 96662bf9e527..1680be67e733 100644
--- a/arch/arm64/boot/dts/qcom/sm8250-samsung-common.dtsi
+++ b/arch/arm64/boot/dts/qcom/sm8250-samsung-common.dtsi
@@ -159,7 +159,8 @@ &pon_resin {
};
&tlmm {
- gpio-reserved-ranges = <40 4>; /* I2C (Unused) */
+ gpio-reserved-ranges = <20 4>, /* SPI (Fingerprint scanner) */
+ <40 4>; /* I2C (Unused) */
};
&usb_1 {
--
2.51.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] arm64: dts: qcom: sm8250-samsung-common: correct reserved pins
2025-09-21 13:56 [PATCH] arm64: dts: qcom: sm8250-samsung-common: correct reserved pins Eric Gonçalves
@ 2025-09-22 9:51 ` Dmitry Baryshkov
2025-09-28 4:49 ` Eric Gonçalves
0 siblings, 1 reply; 3+ messages in thread
From: Dmitry Baryshkov @ 2025-09-22 9:51 UTC (permalink / raw)
To: Eric Gonçalves
Cc: Bjorn Andersson, Konrad Dybcio, Conor Dooley, Krzysztof Kozlowski,
Rob Herring, devicetree, linux-arm-msm, linux-kernel
On Sun, Sep 21, 2025 at 01:56:23PM +0000, Eric Gonçalves wrote:
> The S20 series has additional reserved pins for the fingerprint sensor,
> GPIO 20-23. Correct it by adding them into gpio-reserved-ranges.
>
> Signed-off-by: Eric Gonçalves <ghatto404@gmail.com>
> ---
> arch/arm64/boot/dts/qcom/sm8250-samsung-common.dtsi | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sm8250-samsung-common.dtsi b/arch/arm64/boot/dts/qcom/sm8250-samsung-common.dtsi
> index 96662bf9e527..1680be67e733 100644
> --- a/arch/arm64/boot/dts/qcom/sm8250-samsung-common.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sm8250-samsung-common.dtsi
> @@ -159,7 +159,8 @@ &pon_resin {
> };
>
> &tlmm {
> - gpio-reserved-ranges = <40 4>; /* I2C (Unused) */
> + gpio-reserved-ranges = <20 4>, /* SPI (Fingerprint scanner) */
> + <40 4>; /* I2C (Unused) */
Typically Tab size is 8 spaces, not 4.
Also:
Fixes: 6657fe9e9f23 ("arm64: dts: qcom: add initial support for Samsung Galaxy S20 FE")
> };
>
> &usb_1 {
> --
> 2.51.0
>
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] arm64: dts: qcom: sm8250-samsung-common: correct reserved pins
2025-09-22 9:51 ` Dmitry Baryshkov
@ 2025-09-28 4:49 ` Eric Gonçalves
0 siblings, 0 replies; 3+ messages in thread
From: Eric Gonçalves @ 2025-09-28 4:49 UTC (permalink / raw)
To: Dmitry Baryshkov
Cc: Bjorn Andersson, Konrad Dybcio, Conor Dooley, Krzysztof Kozlowski,
Rob Herring, devicetree, linux-arm-msm, linux-kernel
On September 22, 2025 6:51:30 AM GMT-03:00, Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com> wrote:
>On Sun, Sep 21, 2025 at 01:56:23PM +0000, Eric Gonçalves wrote:
>> The S20 series has additional reserved pins for the fingerprint sensor,
>> GPIO 20-23. Correct it by adding them into gpio-reserved-ranges.
>>
>> Signed-off-by: Eric Gonçalves <ghatto404@gmail.com>
>> ---
>> arch/arm64/boot/dts/qcom/sm8250-samsung-common.dtsi | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/sm8250-samsung-common.dtsi b/arch/arm64/boot/dts/qcom/sm8250-samsung-common.dtsi
>> index 96662bf9e527..1680be67e733 100644
>> --- a/arch/arm64/boot/dts/qcom/sm8250-samsung-common.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/sm8250-samsung-common.dtsi
>> @@ -159,7 +159,8 @@ &pon_resin {
>> };
>>
>> &tlmm {
>> - gpio-reserved-ranges = <40 4>; /* I2C (Unused) */
>> + gpio-reserved-ranges = <20 4>, /* SPI (Fingerprint scanner) */
>> + <40 4>; /* I2C (Unused) */
>
>Typically Tab size is 8 spaces, not 4.
I'll change that, thanks
>
>
>Also:
>
>Fixes: 6657fe9e9f23 ("arm64: dts: qcom: add initial support for Samsung Galaxy S20 FE")
>
>
>> };
>>
>> &usb_1 {
>> --
>> 2.51.0
>>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-09-28 4:49 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-09-21 13:56 [PATCH] arm64: dts: qcom: sm8250-samsung-common: correct reserved pins Eric Gonçalves
2025-09-22 9:51 ` Dmitry Baryshkov
2025-09-28 4:49 ` Eric Gonçalves
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox