* [PATCH] clk: qcom: gcc-qcs404: fix duplicate initializer warning
@ 2023-01-30 13:55 Arnd Bergmann
2023-01-30 13:56 ` Konrad Dybcio
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Arnd Bergmann @ 2023-01-30 13:55 UTC (permalink / raw)
To: Bjorn Andersson, Andy Gross, Michael Turquette, Stephen Boyd,
Dmitry Baryshkov, Konrad Dybcio
Cc: Arnd Bergmann, linux-arm-msm, linux-clk, linux-kernel
From: Arnd Bergmann <arnd@arndb.de>
In one of the clocks, a redundant initialization for .num_parents
got left behind by a recent patch:
drivers/clk/qcom/gcc-qcs404.c:63:32: error: initialized field overwritten [-Werror=override-init]
63 | .num_parents = 1,
| ^
Fixes: 2ce81afa0c7c ("clk: qcom: gcc-qcs404: sort out the cxo clock")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/clk/qcom/gcc-qcs404.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/clk/qcom/gcc-qcs404.c b/drivers/clk/qcom/gcc-qcs404.c
index 5f58dd82d3fe..a39c4990b29d 100644
--- a/drivers/clk/qcom/gcc-qcs404.c
+++ b/drivers/clk/qcom/gcc-qcs404.c
@@ -60,7 +60,6 @@ static struct clk_fixed_factor cxo = {
.name = "cxo",
.parent_data = gcc_parent_data_1,
.num_parents = ARRAY_SIZE(gcc_parent_data_1),
- .num_parents = 1,
.ops = &clk_fixed_factor_ops,
},
};
--
2.39.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] clk: qcom: gcc-qcs404: fix duplicate initializer warning
2023-01-30 13:55 [PATCH] clk: qcom: gcc-qcs404: fix duplicate initializer warning Arnd Bergmann
@ 2023-01-30 13:56 ` Konrad Dybcio
2023-01-30 22:30 ` Stephen Boyd
2023-01-30 23:46 ` Bjorn Andersson
2 siblings, 0 replies; 4+ messages in thread
From: Konrad Dybcio @ 2023-01-30 13:56 UTC (permalink / raw)
To: Arnd Bergmann, Bjorn Andersson, Andy Gross, Michael Turquette,
Stephen Boyd, Dmitry Baryshkov
Cc: Arnd Bergmann, linux-arm-msm, linux-clk, linux-kernel
On 30.01.2023 14:55, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> In one of the clocks, a redundant initialization for .num_parents
> got left behind by a recent patch:
>
> drivers/clk/qcom/gcc-qcs404.c:63:32: error: initialized field overwritten [-Werror=override-init]
> 63 | .num_parents = 1,
> | ^
>
> Fixes: 2ce81afa0c7c ("clk: qcom: gcc-qcs404: sort out the cxo clock")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Konrad
> drivers/clk/qcom/gcc-qcs404.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/clk/qcom/gcc-qcs404.c b/drivers/clk/qcom/gcc-qcs404.c
> index 5f58dd82d3fe..a39c4990b29d 100644
> --- a/drivers/clk/qcom/gcc-qcs404.c
> +++ b/drivers/clk/qcom/gcc-qcs404.c
> @@ -60,7 +60,6 @@ static struct clk_fixed_factor cxo = {
> .name = "cxo",
> .parent_data = gcc_parent_data_1,
> .num_parents = ARRAY_SIZE(gcc_parent_data_1),
> - .num_parents = 1,
> .ops = &clk_fixed_factor_ops,
> },
> };
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] clk: qcom: gcc-qcs404: fix duplicate initializer warning
2023-01-30 13:55 [PATCH] clk: qcom: gcc-qcs404: fix duplicate initializer warning Arnd Bergmann
2023-01-30 13:56 ` Konrad Dybcio
@ 2023-01-30 22:30 ` Stephen Boyd
2023-01-30 23:46 ` Bjorn Andersson
2 siblings, 0 replies; 4+ messages in thread
From: Stephen Boyd @ 2023-01-30 22:30 UTC (permalink / raw)
To: Andy Gross, Arnd Bergmann, Bjorn Andersson, Dmitry Baryshkov,
Konrad Dybcio, Michael Turquette
Cc: Arnd Bergmann, linux-arm-msm, linux-clk, linux-kernel
Quoting Arnd Bergmann (2023-01-30 05:55:47)
> From: Arnd Bergmann <arnd@arndb.de>
>
> In one of the clocks, a redundant initialization for .num_parents
> got left behind by a recent patch:
>
> drivers/clk/qcom/gcc-qcs404.c:63:32: error: initialized field overwritten [-Werror=override-init]
> 63 | .num_parents = 1,
> | ^
>
> Fixes: 2ce81afa0c7c ("clk: qcom: gcc-qcs404: sort out the cxo clock")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
This is https://lore.kernel.org/r/20230123201812.1230039-2-krzysztof.kozlowski@linaro.org
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] clk: qcom: gcc-qcs404: fix duplicate initializer warning
2023-01-30 13:55 [PATCH] clk: qcom: gcc-qcs404: fix duplicate initializer warning Arnd Bergmann
2023-01-30 13:56 ` Konrad Dybcio
2023-01-30 22:30 ` Stephen Boyd
@ 2023-01-30 23:46 ` Bjorn Andersson
2 siblings, 0 replies; 4+ messages in thread
From: Bjorn Andersson @ 2023-01-30 23:46 UTC (permalink / raw)
To: dmitry.baryshkov, Andy Gross, konrad.dybcio, mturquette, arnd,
sboyd
Cc: linux-clk, linux-kernel, linux-arm-msm, Arnd Bergmann
On Mon, 30 Jan 2023 14:55:47 +0100, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> In one of the clocks, a redundant initialization for .num_parents
> got left behind by a recent patch:
>
> drivers/clk/qcom/gcc-qcs404.c:63:32: error: initialized field overwritten [-Werror=override-init]
> 63 | .num_parents = 1,
> | ^
>
> [...]
Applied, thanks!
[1/1] clk: qcom: gcc-qcs404: fix duplicate initializer warning
commit: d4cb3e7113f82f7378527890aa7b4006234665fe
Best regards,
--
Bjorn Andersson <andersson@kernel.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-01-30 23:46 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-01-30 13:55 [PATCH] clk: qcom: gcc-qcs404: fix duplicate initializer warning Arnd Bergmann
2023-01-30 13:56 ` Konrad Dybcio
2023-01-30 22:30 ` Stephen Boyd
2023-01-30 23:46 ` Bjorn Andersson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox