Re: [PATCH v5 0/6] soc: qcom: add in-kernel pd-mapper implementation

[Krzysztof Kozlowski <krzk@kernel.org>]

On 19/04/2024 16:00, Dmitry Baryshkov wrote:
> Protection domain mapper is a QMI service providing mapping between
> 'protection domains' and services supported / allowed in these domains.
> For example such mapping is required for loading of the WiFi firmware or
> for properly starting up the UCSI / altmode / battery manager support.
> 
> The existing userspace implementation has several issue. It doesn't play
> well with CONFIG_EXTRA_FIRMWARE, it doesn't reread the JSON files if the
> firmware location is changed (or if the firmware was not available at
> the time pd-mapper was started but the corresponding directory is
> mounted later), etc.
> 
> However this configuration is largely static and common between
> different platforms. Provide in-kernel service implementing static
> per-platform data.
> 
> Unlike previous revisions of the patchset, this iteration uses static
> configuration per platform, rather than building it dynamically from the
> list of DSPs being started.
> 

I applied this patchset and... it does not compile.

drivers/remoteproc/qcom_q6v5_wcss.c:243:15: error: implicit declaration
of function ‘qcom_pdm_get’; did you mean ‘em_pd_get’?
[-Werror=implicit-function-declaration]


That's just defconfig, so I have doubts this was tested.

Best regards,
Krzysztof