From: Krzysztof Kozlowski <krzk@kernel.org>
To: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Cc: Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Mathieu Poirier <mathieu.poirier@linaro.org>,
Sibi Sankar <quic_sibis@quicinc.com>,
Bartosz Golaszewski <bartosz.golaszewski@linaro.org>,
linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org,
Johan Hovold <johan+linaro@kernel.org>,
Xilin Wu <wuxilin123@gmail.com>
Subject: Re: [PATCH v5 5/6] soc: qcom: add pd-mapper implementation
Date: Sat, 20 Apr 2024 13:40:09 +0200 [thread overview]
Message-ID: <5d054c36-a082-4484-bab1-746b7b30c71b@kernel.org> (raw)
In-Reply-To: <c255c9d5-f3fc-438c-abbe-64995823e80c@kernel.org>
On 19/04/2024 20:45, Krzysztof Kozlowski wrote:
>>
>>>
>>>> Remoteproc module depends on this symbol. Once q6v5 remoteproc modules
>>>> are unloaded this module can be unloaded too.
>>>
>>> I am pretty sure you can unload this and get crashes.
>>
>> If for some reason somebody has called qcom_pdm_get() without
>> qcom_pdm_release(), then yes. To make it 100% safe, I can cleanup
>> actions to module_exit(), but for me it looks like an overkill.
>
> I'll come with some more concrete example if you are not convinced.
It's not possible, this code does not compile. I fixed one thing but
then it fails in other places. This was probably never built and for
sure never really compile-tested in few more configurations.
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-04-20 11:40 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-19 14:00 [PATCH v5 0/6] soc: qcom: add in-kernel pd-mapper implementation Dmitry Baryshkov
2024-04-19 14:00 ` [PATCH v5 1/6] soc: qcom: pdr: protect locator_addr with the main mutex Dmitry Baryshkov
2024-04-19 14:00 ` [PATCH v5 2/6] soc: qcom: pdr: fix parsing of domains lists Dmitry Baryshkov
2024-04-19 14:00 ` [PATCH v5 3/6] soc: qcom: pdr: extract PDR message marshalling data Dmitry Baryshkov
2024-04-20 23:42 ` Bryan O'Donoghue
2024-04-21 13:16 ` Dmitry Baryshkov
2024-04-19 14:00 ` [PATCH v5 4/6] soc: qcom: qmi: add a way to remove running service Dmitry Baryshkov
2024-04-19 14:00 ` [PATCH v5 5/6] soc: qcom: add pd-mapper implementation Dmitry Baryshkov
2024-04-19 17:07 ` Krzysztof Kozlowski
2024-04-19 18:10 ` Dmitry Baryshkov
2024-04-19 18:15 ` Krzysztof Kozlowski
2024-04-19 18:24 ` Dmitry Baryshkov
2024-04-19 18:45 ` Krzysztof Kozlowski
2024-04-19 19:02 ` Dmitry Baryshkov
2024-04-20 11:40 ` Krzysztof Kozlowski [this message]
2024-04-19 14:00 ` [PATCH v5 6/6] remoteproc: qcom: enable in-kernel PD mapper Dmitry Baryshkov
2024-04-20 11:32 ` [PATCH v5 0/6] soc: qcom: add in-kernel pd-mapper implementation Krzysztof Kozlowski
2024-04-22 10:00 ` Dmitry Baryshkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5d054c36-a082-4484-bab1-746b7b30c71b@kernel.org \
--to=krzk@kernel.org \
--cc=andersson@kernel.org \
--cc=bartosz.golaszewski@linaro.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=johan+linaro@kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=quic_sibis@quicinc.com \
--cc=wuxilin123@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox