From: Konrad Dybcio <konradybcio@kernel.org>
To: Rob Clark <robdclark@gmail.com>, Konrad Dybcio <konradybcio@kernel.org>
Cc: dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org,
freedreno@lists.freedesktop.org,
Akhil P Oommen <quic_akhilpo@quicinc.com>,
Connor Abbott <cwabbott0@gmail.com>,
Rob Clark <robdclark@chromium.org>, Sean Paul <sean@poorly.run>,
Abhinav Kumar <quic_abhinavk@quicinc.com>,
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
Marijn Suijten <marijn.suijten@somainline.org>,
David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] drm/msm/a6xx+: Insert a fence wait before SMMU table update
Date: Wed, 18 Sep 2024 01:37:10 +0200 [thread overview]
Message-ID: <59974e61-13f8-4080-850a-55e599c41cb5@kernel.org> (raw)
In-Reply-To: <CAF6AEGvgS-DD0+qGX_Mud75aES4AQQjmWx2j2gyz7uakTpnp0w@mail.gmail.com>
On 17.09.2024 5:30 PM, Rob Clark wrote:
> On Tue, Sep 17, 2024 at 6:47 AM Konrad Dybcio <konradybcio@kernel.org> wrote:
>>
>> On 13.09.2024 9:51 PM, Rob Clark wrote:
>>> From: Rob Clark <robdclark@chromium.org>
>>>
>>> The CP_SMMU_TABLE_UPDATE _should_ be waiting for idle, but on some
>>> devices (x1-85, possibly others), it seems to pass that barrier while
>>> there are still things in the event completion FIFO waiting to be
>>> written back to memory.
>>
>> Can we try to force-fault around here on other GPUs and perhaps
>> limit this workaround?
>
> not sure what you mean by "force-fault"...
I suppose 'reproduce' is what I meant
> we could probably limit
> this to certain GPUs, the only reason I didn't is (a) it should be
> harmless when it is not needed,
Do we have any realistic perf hits here?
> and (b) I have no real good way to get
> an exhaustive list of where it is needed. Maybe/hopefully it is only
> x1-85, but idk.
>
> It does bring up an interesting question about preemption, though
Yeah..
Do we know what windows does here?
Konrad
next prev parent reply other threads:[~2024-09-17 23:37 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-13 19:51 [PATCH] drm/msm/a6xx+: Insert a fence wait before SMMU table update Rob Clark
2024-09-17 13:47 ` Konrad Dybcio
2024-09-17 14:52 ` Akhil P Oommen
2024-09-17 15:30 ` Rob Clark
2024-09-17 23:37 ` Konrad Dybcio [this message]
2024-09-18 1:30 ` Rob Clark
2024-09-18 16:51 ` Connor Abbott
2024-09-24 16:11 ` Rob Clark
2024-09-26 15:56 ` Akhil P Oommen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=59974e61-13f8-4080-850a-55e599c41cb5@kernel.org \
--to=konradybcio@kernel.org \
--cc=airlied@gmail.com \
--cc=cwabbott0@gmail.com \
--cc=daniel@ffwll.ch \
--cc=dmitry.baryshkov@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marijn.suijten@somainline.org \
--cc=quic_abhinavk@quicinc.com \
--cc=quic_akhilpo@quicinc.com \
--cc=robdclark@chromium.org \
--cc=robdclark@gmail.com \
--cc=sean@poorly.run \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox