From: Abhinav Kumar <quic_abhinavk@quicinc.com>
To: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
Rob Clark <robdclark@gmail.com>, Sean Paul <sean@poorly.run>,
Marijn Suijten <marijn.suijten@somainline.org>
Cc: Stephen Boyd <swboyd@chromium.org>,
David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>,
Bjorn Andersson <andersson@kernel.org>,
<linux-arm-msm@vger.kernel.org>,
<dri-devel@lists.freedesktop.org>,
<freedreno@lists.freedesktop.org>
Subject: Re: [PATCH v4 07/13] drm/msm/dpu: move rot90 checking to dpu_plane_atomic_check_pipe()
Date: Wed, 5 Jun 2024 16:34:06 -0700 [thread overview]
Message-ID: <5e4f6e36-d9b3-a3dd-1f0d-22d4d7c287d3@quicinc.com> (raw)
In-Reply-To: <20240314000216.392549-8-dmitry.baryshkov@linaro.org>
On 3/13/2024 5:02 PM, Dmitry Baryshkov wrote:
> Move a call to dpu_plane_check_inline_rotation() to the
> dpu_plane_atomic_check_pipe() function, so that the rot90 constraints
> are checked for both pipes. Also move rotation field from struct
> dpu_plane_state to struct dpu_sw_pipe_cfg.
>
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> ---
> drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.h | 2 +
> drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c | 55 +++++++++++----------
> drivers/gpu/drm/msm/disp/dpu1/dpu_plane.h | 2 -
> 3 files changed, 31 insertions(+), 28 deletions(-)
>
From the first glance, no major comments, I will give my R-b on this
once its re-spun on msm-next.
next prev parent reply other threads:[~2024-06-05 23:34 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-14 0:02 [PATCH v4 00/13] drm/msm/dpu: support virtual wide planes Dmitry Baryshkov
2024-03-14 0:02 ` [PATCH v4 01/13] drm/msm/dpu: take plane rotation into account for " Dmitry Baryshkov
2024-05-30 22:51 ` Abhinav Kumar
2024-03-14 0:02 ` [PATCH v4 02/13] drm/msm/dpu: use drm_rect_fp_to_int() Dmitry Baryshkov
2024-05-30 23:14 ` Abhinav Kumar
2024-03-14 0:02 ` [PATCH v4 03/13] drm/msm/dpu: move pstate->pipe initialization to dpu_plane_atomic_check Dmitry Baryshkov
2024-05-31 0:28 ` Abhinav Kumar
2024-03-14 0:02 ` [PATCH v4 04/13] drm/msm/dpu: drop virt_formats from SSPP subblock configuration Dmitry Baryshkov
2024-05-31 0:32 ` Abhinav Kumar
2024-03-14 0:02 ` [PATCH v4 05/13] drm/msm/dpu: move scaling limitations out of the hw_catalog Dmitry Baryshkov
2024-05-31 1:02 ` Abhinav Kumar
2024-05-31 8:16 ` Dmitry Baryshkov
2024-05-31 19:20 ` Abhinav Kumar
2024-05-31 19:45 ` Dmitry Baryshkov
2024-03-14 0:02 ` [PATCH v4 06/13] drm/msm/dpu: split dpu_plane_atomic_check() Dmitry Baryshkov
2024-06-05 23:19 ` Abhinav Kumar
2024-06-05 23:32 ` Dmitry Baryshkov
2024-06-05 23:47 ` Abhinav Kumar
2024-06-06 8:53 ` Dmitry Baryshkov
2024-06-06 8:54 ` Dmitry Baryshkov
2024-03-14 0:02 ` [PATCH v4 07/13] drm/msm/dpu: move rot90 checking to dpu_plane_atomic_check_pipe() Dmitry Baryshkov
2024-06-05 23:34 ` Abhinav Kumar [this message]
2024-03-14 0:02 ` [PATCH v4 08/13] drm/msm/dpu: add support for virtual planes Dmitry Baryshkov
2024-03-14 8:04 ` [v4,08/13] " Sui Jingfeng
2024-06-06 22:21 ` [PATCH v4 08/13] " Abhinav Kumar
2024-06-07 7:16 ` Dmitry Baryshkov
2024-06-07 19:22 ` Abhinav Kumar
2024-06-07 21:10 ` Dmitry Baryshkov
2024-06-07 21:39 ` Abhinav Kumar
2024-06-07 22:26 ` Dmitry Baryshkov
2024-06-07 23:55 ` Abhinav Kumar
2024-06-08 0:57 ` Dmitry Baryshkov
2024-06-08 2:45 ` Abhinav Kumar
2024-06-10 21:01 ` Abhinav Kumar
2024-03-14 0:02 ` [PATCH v4 09/13] drm/msm/dpu: allow using two SSPP blocks for a single plane Dmitry Baryshkov
2024-06-10 20:19 ` Abhinav Kumar
2024-03-14 0:02 ` [PATCH v4 10/13] drm/msm/dpu: allow sharing SSPP between planes Dmitry Baryshkov
2024-06-11 23:12 ` Abhinav Kumar
2024-06-12 9:08 ` Dmitry Baryshkov
2024-06-13 1:17 ` Abhinav Kumar
2024-06-13 10:05 ` Dmitry Baryshkov
2024-06-13 20:02 ` Abhinav Kumar
2024-03-14 0:02 ` [PATCH v4 11/13] drm/msm/dpu: create additional virtual planes Dmitry Baryshkov
2024-06-11 23:26 ` Abhinav Kumar
2024-03-14 0:02 ` [PATCH v4 12/13] drm/msm/dpu: allow sharing of blending stages Dmitry Baryshkov
2024-06-12 1:47 ` Abhinav Kumar
2024-06-12 8:50 ` Dmitry Baryshkov
2024-03-14 0:02 ` [PATCH v4 13/13] drm/msm/dpu: include SSPP allocation state into the dumped state Dmitry Baryshkov
2024-06-11 23:43 ` Abhinav Kumar
2024-03-14 0:04 ` [PATCH v4 00/13] drm/msm/dpu: support virtual wide planes Dmitry Baryshkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5e4f6e36-d9b3-a3dd-1f0d-22d4d7c287d3@quicinc.com \
--to=quic_abhinavk@quicinc.com \
--cc=airlied@gmail.com \
--cc=andersson@kernel.org \
--cc=daniel@ffwll.ch \
--cc=dmitry.baryshkov@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=marijn.suijten@somainline.org \
--cc=robdclark@gmail.com \
--cc=sean@poorly.run \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox