From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: Alexandru Gagniuc <mr.nuke.me@gmail.com>,
andersson@kernel.org, mathieu.poirier@linaro.org,
linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org,
p.zabel@pengutronix.de, Govind Singh <govinds@codeaurora.org>,
Gokul Sriram Palanisamy <quic_gokulsri@quicinc.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/2] remoteproc: qcom_q6v5_wcss: fix parsing of qcom,halt-regs
Date: Wed, 3 Dec 2025 12:24:22 +0100 [thread overview]
Message-ID: <62911215-1211-4cd7-ac9f-232e3f585249@oss.qualcomm.com> (raw)
In-Reply-To: <20251202162626.1135615-1-mr.nuke.me@gmail.com>
On 12/2/25 5:26 PM, Alexandru Gagniuc wrote:
> The "qcom,halt-regs" consists of a phandle reference followed by the
> three offsets within syscon for halt registers. Thus, we need to
> request 4 integers from of_property_read_variable_u32_array(), with
> the halt_reg ofsets at indexes 1, 2, and 3. Offset 0 is the phandle.
>
> With MAX_HALT_REG at 3, of_property_read_variable_u32_array() returns
> -EOVERFLOW, causing .probe() to fail.
>
> Increase MAX_HALT_REG to 4, and update the indexes accordingly.
>
> Fixes: 0af65b9b915e ("remoteproc: qcom: wcss: Add non pas wcss Q6 support for QCS404")
>
> Signed-off-by: Alexandru Gagniuc <mr.nuke.me@gmail.com>
> ---
Hm, that surely could have never worked
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Konrad
prev parent reply other threads:[~2025-12-03 11:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-02 16:26 [PATCH v2 1/2] remoteproc: qcom_q6v5_wcss: fix parsing of qcom,halt-regs Alexandru Gagniuc
2025-12-02 16:26 ` [PATCH v2 2/2] remoteproc: qcom_q6v5_wcss: drop redundant wcss_q6_bcr_reset Alexandru Gagniuc
2025-12-03 12:09 ` Konrad Dybcio
2025-12-03 11:24 ` Konrad Dybcio [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=62911215-1211-4cd7-ac9f-232e3f585249@oss.qualcomm.com \
--to=konrad.dybcio@oss.qualcomm.com \
--cc=andersson@kernel.org \
--cc=govinds@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=mr.nuke.me@gmail.com \
--cc=p.zabel@pengutronix.de \
--cc=quic_gokulsri@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox