* [PATCH 1/5] ASoC: codecs: va-macro: Rework version checking
2025-09-25 0:01 [PATCH 0/5] Add Audio Support for Kaanapali MTP Boards Jingyi Wang
@ 2025-09-25 0:01 ` Jingyi Wang
2025-09-26 5:36 ` kernel test robot
2025-09-25 0:01 ` [PATCH 2/5] ASoC: dt-bindings: qcom,sm8250: Add kaanapali sound card Jingyi Wang
` (3 subsequent siblings)
4 siblings, 1 reply; 15+ messages in thread
From: Jingyi Wang @ 2025-09-25 0:01 UTC (permalink / raw)
To: Srinivas Kandagatla, Liam Girdwood, Mark Brown, Jaroslav Kysela,
Takashi Iwai, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Rao Mandadapu
Cc: aiqun.yu, tingwei.zhang, trilok.soni, yijie.yang, linux-sound,
linux-arm-msm, linux-kernel, devicetree, Jingyi Wang,
Konrad Dybcio, Prasad Kumpatla
From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Open-code some of the registers to make the checks anywhere near human-
readable. Error out if the version is unsupported or if the VA macro
isn't supposed to be present within this LPASS instance (since we can
check for that now).
Note that previously v2.0 and v2.1 assignments were swapped, but v2.1
does not even seem to exist (as opposed to v2.0.1) and there is no
difference in SW handling anyway.
Signed-off-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
[Prasad Kumpatla: fixed a spelling error and resolved a checkpatch
warning related to return value handling]
Signed-off-by: Prasad Kumpatla <prasad.kumpatla@oss.qualcomm.com>
Signed-off-by: Jingyi Wang <jingyi.wang@oss.qualcomm.com>
---
sound/soc/codecs/lpass-va-macro.c | 89 +++++++++++++++++++++++++++------------
1 file changed, 62 insertions(+), 27 deletions(-)
diff --git a/sound/soc/codecs/lpass-va-macro.c b/sound/soc/codecs/lpass-va-macro.c
index 2e1b77973a3e..1454c533db8b 100644
--- a/sound/soc/codecs/lpass-va-macro.c
+++ b/sound/soc/codecs/lpass-va-macro.c
@@ -64,8 +64,15 @@
#define CDC_VA_TOP_CSR_I2S_CLK (0x00A8)
#define CDC_VA_TOP_CSR_I2S_RESET (0x00AC)
#define CDC_VA_TOP_CSR_CORE_ID_0 (0x00C0)
+ #define CORE_ID_0_REV_MAJ GENMASK(7, 0)
#define CDC_VA_TOP_CSR_CORE_ID_1 (0x00C4)
+#define CORE_ID_1_HAS_WSAMACRO BIT(3)
+#define CORE_ID_1_HAS_RXMACRO BIT(2)
+#define CORE_ID_1_HAS_TXMACRO BIT(1)
+#define CORE_ID_1_HAS_VAMACRO BIT(0)
#define CDC_VA_TOP_CSR_CORE_ID_2 (0x00C8)
+ #define CORE_ID_2_REV_MIN GENMASK(7, 4)
+ #define CORE_ID_2_REV_STEP GENMASK(3, 0)
#define CDC_VA_TOP_CSR_CORE_ID_3 (0x00CC)
#define CDC_VA_TOP_CSR_SWR_MIC_CTL0 (0x00D0)
#define CDC_VA_TOP_CSR_SWR_MIC_CTL1 (0x00D4)
@@ -1462,39 +1469,63 @@ static int va_macro_validate_dmic_sample_rate(u32 dmic_sample_rate,
return dmic_sample_rate;
}
-static void va_macro_set_lpass_codec_version(struct va_macro *va)
+static int va_macro_set_lpass_codec_version(struct va_macro *va)
{
- int core_id_0 = 0, core_id_1 = 0, core_id_2 = 0;
int version = LPASS_CODEC_VERSION_UNKNOWN;
+ u32 maj, min, step;
+ u32 val;
- regmap_read(va->regmap, CDC_VA_TOP_CSR_CORE_ID_0, &core_id_0);
- regmap_read(va->regmap, CDC_VA_TOP_CSR_CORE_ID_1, &core_id_1);
- regmap_read(va->regmap, CDC_VA_TOP_CSR_CORE_ID_2, &core_id_2);
+ regmap_read(va->regmap, CDC_VA_TOP_CSR_CORE_ID_0, &val);
+ maj = FIELD_GET(CORE_ID_0_REV_MAJ, val);
- if ((core_id_0 == 0x01) && (core_id_1 == 0x0F))
- version = LPASS_CODEC_VERSION_2_0;
- if ((core_id_0 == 0x02) && (core_id_1 == 0x0F) && core_id_2 == 0x01)
+ regmap_read(va->regmap, CDC_VA_TOP_CSR_CORE_ID_1, &val);
+ if (!FIELD_GET(CORE_ID_1_HAS_VAMACRO, val)) {
+ dev_err(va->dev, "This is not a VA macro instance\n");
+ return -ENODEV;
+ }
+
+ regmap_read(va->regmap, CDC_VA_TOP_CSR_CORE_ID_2, &val);
+ min = FIELD_GET(CORE_ID_2_REV_MIN, val);
+ step = FIELD_GET(CORE_ID_2_REV_STEP, val);
+
+ if (maj == 1) {
version = LPASS_CODEC_VERSION_2_0;
- if ((core_id_0 == 0x02) && (core_id_1 == 0x0E))
- version = LPASS_CODEC_VERSION_2_1;
- if ((core_id_0 == 0x02) && (core_id_1 == 0x0F) && (core_id_2 == 0x50 || core_id_2 == 0x51))
- version = LPASS_CODEC_VERSION_2_5;
- if ((core_id_0 == 0x02) && (core_id_1 == 0x0F) && (core_id_2 == 0x60 || core_id_2 == 0x61))
- version = LPASS_CODEC_VERSION_2_6;
- if ((core_id_0 == 0x02) && (core_id_1 == 0x0F) && (core_id_2 == 0x70 || core_id_2 == 0x71))
- version = LPASS_CODEC_VERSION_2_7;
- if ((core_id_0 == 0x02) && (core_id_1 == 0x0F) && (core_id_2 == 0x80 || core_id_2 == 0x81))
- version = LPASS_CODEC_VERSION_2_8;
- if ((core_id_0 == 0x02) && (core_id_1 == 0x0F) && (core_id_2 == 0x90 || core_id_2 == 0x91))
- version = LPASS_CODEC_VERSION_2_9;
-
- if (version == LPASS_CODEC_VERSION_UNKNOWN)
- dev_warn(va->dev, "Unknown Codec version, ID: %02x / %02x / %02x\n",
- core_id_0, core_id_1, core_id_2);
+ } else if (maj == 2) {
+ switch (min) {
+ case 0:
+ version = LPASS_CODEC_VERSION_2_0;
+ break;
+ case 5:
+ version = LPASS_CODEC_VERSION_2_5;
+ break;
+ case 6:
+ version = LPASS_CODEC_VERSION_2_6;
+ break;
+ case 7:
+ version = LPASS_CODEC_VERSION_2_7;
+ break;
+ case 8:
+ version = LPASS_CODEC_VERSION_2_8;
+ break;
+ case 9:
+ version = LPASS_CODEC_VERSION_2_9;
+ break;
+ default:
+ break;
+ }
+ }
+
+ if (version == LPASS_CODEC_VERSION_UNKNOWN) {
+ dev_err(va->dev, "VA Macro v%u.%u.%u is not supported\n",
+ maj, min, step);
+ return -EOPNOTSUPP;
+ }
lpass_macro_set_codec_version(version);
dev_dbg(va->dev, "LPASS Codec Version %s\n", lpass_macro_get_codec_version_string(version));
+
+ return 0;
}
static int va_macro_probe(struct platform_device *pdev)
@@ -1594,10 +1625,14 @@ static int va_macro_probe(struct platform_device *pdev)
* old version of codecs do not have a reliable way to determine the
* version from registers, get them from soc specific data
*/
- if (data->version)
+ if (data->version) {
lpass_macro_set_codec_version(data->version);
- else /* read version from register */
- va_macro_set_lpass_codec_version(va);
+ } else {
+ /* read version from register */
+ ret = va_macro_set_lpass_codec_version(va);
+ if (ret)
+ return ret;
+ }
if (va->has_swr_master) {
/* Set default CLK div to 1 */
--
2.25.1
^ permalink raw reply related [flat|nested] 15+ messages in thread* Re: [PATCH 1/5] ASoC: codecs: va-macro: Rework version checking
2025-09-25 0:01 ` [PATCH 1/5] ASoC: codecs: va-macro: Rework version checking Jingyi Wang
@ 2025-09-26 5:36 ` kernel test robot
2025-09-26 8:50 ` Konrad Dybcio
0 siblings, 1 reply; 15+ messages in thread
From: kernel test robot @ 2025-09-26 5:36 UTC (permalink / raw)
To: Jingyi Wang, Srinivas Kandagatla, Liam Girdwood, Mark Brown,
Jaroslav Kysela, Takashi Iwai, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Rao Mandadapu
Cc: llvm, oe-kbuild-all, aiqun.yu, tingwei.zhang, trilok.soni,
yijie.yang, linux-sound, linux-arm-msm, linux-kernel, devicetree,
Jingyi Wang, Konrad Dybcio, Prasad Kumpatla
Hi Jingyi,
kernel test robot noticed the following build errors:
[auto build test ERROR on ae2d20002576d2893ecaff25db3d7ef9190ac0b6]
url: https://github.com/intel-lab-lkp/linux/commits/Jingyi-Wang/ASoC-codecs-va-macro-Rework-version-checking/20250925-080338
base: ae2d20002576d2893ecaff25db3d7ef9190ac0b6
patch link: https://lore.kernel.org/r/20250924-knp-audio-v1-1-5afa926b567c%40oss.qualcomm.com
patch subject: [PATCH 1/5] ASoC: codecs: va-macro: Rework version checking
config: i386-buildonly-randconfig-001-20250926 (https://download.01.org/0day-ci/archive/20250926/202509261315.O9CiiXjb-lkp@intel.com/config)
compiler: clang version 20.1.8 (https://github.com/llvm/llvm-project 87f0227cb60147a26a1eeb4fb06e3b505e9c7261)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250926/202509261315.O9CiiXjb-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202509261315.O9CiiXjb-lkp@intel.com/
All errors (new ones prefixed by >>):
>> sound/soc/codecs/lpass-va-macro.c:1479:8: error: call to undeclared function 'FIELD_GET'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
1479 | maj = FIELD_GET(CORE_ID_0_REV_MAJ, val);
| ^
1 error generated.
vim +/FIELD_GET +1479 sound/soc/codecs/lpass-va-macro.c
1471
1472 static int va_macro_set_lpass_codec_version(struct va_macro *va)
1473 {
1474 int version = LPASS_CODEC_VERSION_UNKNOWN;
1475 u32 maj, min, step;
1476 u32 val;
1477
1478 regmap_read(va->regmap, CDC_VA_TOP_CSR_CORE_ID_0, &val);
> 1479 maj = FIELD_GET(CORE_ID_0_REV_MAJ, val);
1480
1481 regmap_read(va->regmap, CDC_VA_TOP_CSR_CORE_ID_1, &val);
1482 if (!FIELD_GET(CORE_ID_1_HAS_VAMACRO, val)) {
1483 dev_err(va->dev, "This is not a VA macro instance\n");
1484 return -ENODEV;
1485 }
1486
1487 regmap_read(va->regmap, CDC_VA_TOP_CSR_CORE_ID_2, &val);
1488 min = FIELD_GET(CORE_ID_2_REV_MIN, val);
1489 step = FIELD_GET(CORE_ID_2_REV_STEP, val);
1490
1491 if (maj == 1) {
1492 version = LPASS_CODEC_VERSION_2_0;
1493 } else if (maj == 2) {
1494 switch (min) {
1495 case 0:
1496 version = LPASS_CODEC_VERSION_2_0;
1497 break;
1498 case 5:
1499 version = LPASS_CODEC_VERSION_2_5;
1500 break;
1501 case 6:
1502 version = LPASS_CODEC_VERSION_2_6;
1503 break;
1504 case 7:
1505 version = LPASS_CODEC_VERSION_2_7;
1506 break;
1507 case 8:
1508 version = LPASS_CODEC_VERSION_2_8;
1509 break;
1510 case 9:
1511 version = LPASS_CODEC_VERSION_2_9;
1512 break;
1513 default:
1514 break;
1515 }
1516 }
1517
1518 if (version == LPASS_CODEC_VERSION_UNKNOWN) {
1519 dev_err(va->dev, "VA Macro v%u.%u.%u is not supported\n",
1520 maj, min, step);
1521 return -EOPNOTSUPP;
1522 }
1523
1524 lpass_macro_set_codec_version(version);
1525
1526 dev_dbg(va->dev, "LPASS Codec Version %s\n", lpass_macro_get_codec_version_string(version));
1527
1528 return 0;
1529 }
1530
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 15+ messages in thread* Re: [PATCH 1/5] ASoC: codecs: va-macro: Rework version checking
2025-09-26 5:36 ` kernel test robot
@ 2025-09-26 8:50 ` Konrad Dybcio
2025-09-29 5:43 ` Jingyi Wang
0 siblings, 1 reply; 15+ messages in thread
From: Konrad Dybcio @ 2025-09-26 8:50 UTC (permalink / raw)
To: kernel test robot, Jingyi Wang, Srinivas Kandagatla,
Liam Girdwood, Mark Brown, Jaroslav Kysela, Takashi Iwai,
Rob Herring, Krzysztof Kozlowski, Conor Dooley, Rao Mandadapu
Cc: llvm, oe-kbuild-all, aiqun.yu, tingwei.zhang, trilok.soni,
yijie.yang, linux-sound, linux-arm-msm, linux-kernel, devicetree,
Prasad Kumpatla
On 9/26/25 7:36 AM, kernel test robot wrote:
> Hi Jingyi,
>
> kernel test robot noticed the following build errors:
>
> [auto build test ERROR on ae2d20002576d2893ecaff25db3d7ef9190ac0b6]
>
> url: https://github.com/intel-lab-lkp/linux/commits/Jingyi-Wang/ASoC-codecs-va-macro-Rework-version-checking/20250925-080338
> base: ae2d20002576d2893ecaff25db3d7ef9190ac0b6
> patch link: https://lore.kernel.org/r/20250924-knp-audio-v1-1-5afa926b567c%40oss.qualcomm.com
> patch subject: [PATCH 1/5] ASoC: codecs: va-macro: Rework version checking
> config: i386-buildonly-randconfig-001-20250926 (https://download.01.org/0day-ci/archive/20250926/202509261315.O9CiiXjb-lkp@intel.com/config)
> compiler: clang version 20.1.8 (https://github.com/llvm/llvm-project 87f0227cb60147a26a1eeb4fb06e3b505e9c7261)
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250926/202509261315.O9CiiXjb-lkp@intel.com/reproduce)
>
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@intel.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202509261315.O9CiiXjb-lkp@intel.com/
>
> All errors (new ones prefixed by >>):
>
>>> sound/soc/codecs/lpass-va-macro.c:1479:8: error: call to undeclared function 'FIELD_GET'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
> 1479 | maj = FIELD_GET(CORE_ID_0_REV_MAJ, val);
Jingyi, could you please add:
#include <linux/bitfield.h>
when resending?
Konrad
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH 1/5] ASoC: codecs: va-macro: Rework version checking
2025-09-26 8:50 ` Konrad Dybcio
@ 2025-09-29 5:43 ` Jingyi Wang
0 siblings, 0 replies; 15+ messages in thread
From: Jingyi Wang @ 2025-09-29 5:43 UTC (permalink / raw)
To: Konrad Dybcio, kernel test robot, Srinivas Kandagatla,
Liam Girdwood, Mark Brown, Jaroslav Kysela, Takashi Iwai,
Rob Herring, Krzysztof Kozlowski, Conor Dooley, Rao Mandadapu
Cc: llvm, oe-kbuild-all, aiqun.yu, tingwei.zhang, trilok.soni,
yijie.yang, linux-sound, linux-arm-msm, linux-kernel, devicetree,
Prasad Kumpatla
On 9/26/2025 4:50 PM, Konrad Dybcio wrote:
> On 9/26/25 7:36 AM, kernel test robot wrote:
>> Hi Jingyi,
>>
>> kernel test robot noticed the following build errors:
>>
>> [auto build test ERROR on ae2d20002576d2893ecaff25db3d7ef9190ac0b6]
>>
>> url: https://github.com/intel-lab-lkp/linux/commits/Jingyi-Wang/ASoC-codecs-va-macro-Rework-version-checking/20250925-080338
>> base: ae2d20002576d2893ecaff25db3d7ef9190ac0b6
>> patch link: https://lore.kernel.org/r/20250924-knp-audio-v1-1-5afa926b567c%40oss.qualcomm.com
>> patch subject: [PATCH 1/5] ASoC: codecs: va-macro: Rework version checking
>> config: i386-buildonly-randconfig-001-20250926 (https://download.01.org/0day-ci/archive/20250926/202509261315.O9CiiXjb-lkp@intel.com/config)
>> compiler: clang version 20.1.8 (https://github.com/llvm/llvm-project 87f0227cb60147a26a1eeb4fb06e3b505e9c7261)
>> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250926/202509261315.O9CiiXjb-lkp@intel.com/reproduce)
>>
>> If you fix the issue in a separate patch/commit (i.e. not just a new version of
>> the same patch/commit), kindly add following tags
>> | Reported-by: kernel test robot <lkp@intel.com>
>> | Closes: https://lore.kernel.org/oe-kbuild-all/202509261315.O9CiiXjb-lkp@intel.com/
>>
>> All errors (new ones prefixed by >>):
>>
>>>> sound/soc/codecs/lpass-va-macro.c:1479:8: error: call to undeclared function 'FIELD_GET'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
>> 1479 | maj = FIELD_GET(CORE_ID_0_REV_MAJ, val);
>
> Jingyi, could you please add:
>
> #include <linux/bitfield.h>
>
> when resending?
>
> Konrad
Will add in next version.
Thanks,
Jingyi
^ permalink raw reply [flat|nested] 15+ messages in thread
* [PATCH 2/5] ASoC: dt-bindings: qcom,sm8250: Add kaanapali sound card
2025-09-25 0:01 [PATCH 0/5] Add Audio Support for Kaanapali MTP Boards Jingyi Wang
2025-09-25 0:01 ` [PATCH 1/5] ASoC: codecs: va-macro: Rework version checking Jingyi Wang
@ 2025-09-25 0:01 ` Jingyi Wang
2025-10-09 10:40 ` Krzysztof Kozlowski
2025-09-25 0:01 ` [PATCH 3/5] ASoC: qcom: sc8280xp: Add support for Kaanapali Jingyi Wang
` (2 subsequent siblings)
4 siblings, 1 reply; 15+ messages in thread
From: Jingyi Wang @ 2025-09-25 0:01 UTC (permalink / raw)
To: Srinivas Kandagatla, Liam Girdwood, Mark Brown, Jaroslav Kysela,
Takashi Iwai, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Rao Mandadapu
Cc: aiqun.yu, tingwei.zhang, trilok.soni, yijie.yang, linux-sound,
linux-arm-msm, linux-kernel, devicetree, Jingyi Wang,
Prasad Kumpatla
From: Prasad Kumpatla <prasad.kumpatla@oss.qualcomm.com>
Add bindings for Kaanapali sound card, which looks fully
compatible with existing SM8450.
Signed-off-by: Prasad Kumpatla <prasad.kumpatla@oss.qualcomm.com>
Signed-off-by: Jingyi Wang <jingyi.wang@oss.qualcomm.com>
---
Documentation/devicetree/bindings/sound/qcom,sm8250.yaml | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/sound/qcom,sm8250.yaml b/Documentation/devicetree/bindings/sound/qcom,sm8250.yaml
index 8ac91625dce5..708bae805403 100644
--- a/Documentation/devicetree/bindings/sound/qcom,sm8250.yaml
+++ b/Documentation/devicetree/bindings/sound/qcom,sm8250.yaml
@@ -23,6 +23,7 @@ properties:
- const: qcom,sdm845-sndcard
- items:
- enum:
+ - qcom,kaanapali-sndcard
- qcom,sm8550-sndcard
- qcom,sm8650-sndcard
- qcom,sm8750-sndcard
--
2.25.1
^ permalink raw reply related [flat|nested] 15+ messages in thread* Re: [PATCH 2/5] ASoC: dt-bindings: qcom,sm8250: Add kaanapali sound card
2025-09-25 0:01 ` [PATCH 2/5] ASoC: dt-bindings: qcom,sm8250: Add kaanapali sound card Jingyi Wang
@ 2025-10-09 10:40 ` Krzysztof Kozlowski
0 siblings, 0 replies; 15+ messages in thread
From: Krzysztof Kozlowski @ 2025-10-09 10:40 UTC (permalink / raw)
To: Jingyi Wang, Srinivas Kandagatla, Liam Girdwood, Mark Brown,
Jaroslav Kysela, Takashi Iwai, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Rao Mandadapu
Cc: aiqun.yu, tingwei.zhang, trilok.soni, yijie.yang, linux-sound,
linux-arm-msm, linux-kernel, devicetree, Prasad Kumpatla
On 25/09/2025 09:01, Jingyi Wang wrote:
> From: Prasad Kumpatla <prasad.kumpatla@oss.qualcomm.com>
>
> Add bindings for Kaanapali sound card, which looks fully
> compatible with existing SM8450.
>
> Signed-off-by: Prasad Kumpatla <prasad.kumpatla@oss.qualcomm.com>
> Signed-off-by: Jingyi Wang <jingyi.wang@oss.qualcomm.com>
> ---
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 15+ messages in thread
* [PATCH 3/5] ASoC: qcom: sc8280xp: Add support for Kaanapali
2025-09-25 0:01 [PATCH 0/5] Add Audio Support for Kaanapali MTP Boards Jingyi Wang
2025-09-25 0:01 ` [PATCH 1/5] ASoC: codecs: va-macro: Rework version checking Jingyi Wang
2025-09-25 0:01 ` [PATCH 2/5] ASoC: dt-bindings: qcom,sm8250: Add kaanapali sound card Jingyi Wang
@ 2025-09-25 0:01 ` Jingyi Wang
2025-09-25 2:59 ` Dmitry Baryshkov
2025-10-09 10:41 ` Krzysztof Kozlowski
2025-09-25 0:01 ` [PATCH 4/5] dt-bindings: soundwire: qcom: Add SoundWire v2.2.0 compatible Jingyi Wang
2025-09-25 0:01 ` [PATCH 5/5] ASoC: dt-bindings: qcom: Add Kaanapali LPASS macro codecs Jingyi Wang
4 siblings, 2 replies; 15+ messages in thread
From: Jingyi Wang @ 2025-09-25 0:01 UTC (permalink / raw)
To: Srinivas Kandagatla, Liam Girdwood, Mark Brown, Jaroslav Kysela,
Takashi Iwai, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Rao Mandadapu
Cc: aiqun.yu, tingwei.zhang, trilok.soni, yijie.yang, linux-sound,
linux-arm-msm, linux-kernel, devicetree, Jingyi Wang,
Prasad Kumpatla
From: Prasad Kumpatla <prasad.kumpatla@oss.qualcomm.com>
Add compatible for sound card on Qualcomm Kaanapali boards.
Signed-off-by: Prasad Kumpatla <prasad.kumpatla@oss.qualcomm.com>
Signed-off-by: Jingyi Wang <jingyi.wang@oss.qualcomm.com>
---
sound/soc/qcom/sc8280xp.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/sound/soc/qcom/sc8280xp.c b/sound/soc/qcom/sc8280xp.c
index 288ccd7f8866..e231112175d9 100644
--- a/sound/soc/qcom/sc8280xp.c
+++ b/sound/soc/qcom/sc8280xp.c
@@ -198,6 +198,7 @@ static const struct of_device_id snd_sc8280xp_dt_match[] = {
{.compatible = "qcom,sm8550-sndcard", "sm8550"},
{.compatible = "qcom,sm8650-sndcard", "sm8650"},
{.compatible = "qcom,sm8750-sndcard", "sm8750"},
+ {.compatible = "qcom,kaanapali-sndcard", "kaanapali"},
{}
};
--
2.25.1
^ permalink raw reply related [flat|nested] 15+ messages in thread* Re: [PATCH 3/5] ASoC: qcom: sc8280xp: Add support for Kaanapali
2025-09-25 0:01 ` [PATCH 3/5] ASoC: qcom: sc8280xp: Add support for Kaanapali Jingyi Wang
@ 2025-09-25 2:59 ` Dmitry Baryshkov
2025-09-29 10:09 ` Prasad Kumpatla
2025-10-09 10:41 ` Krzysztof Kozlowski
1 sibling, 1 reply; 15+ messages in thread
From: Dmitry Baryshkov @ 2025-09-25 2:59 UTC (permalink / raw)
To: Jingyi Wang
Cc: Srinivas Kandagatla, Liam Girdwood, Mark Brown, Jaroslav Kysela,
Takashi Iwai, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Rao Mandadapu, aiqun.yu, tingwei.zhang, trilok.soni, yijie.yang,
linux-sound, linux-arm-msm, linux-kernel, devicetree,
Prasad Kumpatla
On Wed, Sep 24, 2025 at 05:01:17PM -0700, Jingyi Wang wrote:
> From: Prasad Kumpatla <prasad.kumpatla@oss.qualcomm.com>
>
> Add compatible for sound card on Qualcomm Kaanapali boards.
>
> Signed-off-by: Prasad Kumpatla <prasad.kumpatla@oss.qualcomm.com>
> Signed-off-by: Jingyi Wang <jingyi.wang@oss.qualcomm.com>
> ---
> sound/soc/qcom/sc8280xp.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/sound/soc/qcom/sc8280xp.c b/sound/soc/qcom/sc8280xp.c
> index 288ccd7f8866..e231112175d9 100644
> --- a/sound/soc/qcom/sc8280xp.c
> +++ b/sound/soc/qcom/sc8280xp.c
> @@ -198,6 +198,7 @@ static const struct of_device_id snd_sc8280xp_dt_match[] = {
> {.compatible = "qcom,sm8550-sndcard", "sm8550"},
> {.compatible = "qcom,sm8650-sndcard", "sm8650"},
> {.compatible = "qcom,sm8750-sndcard", "sm8750"},
> + {.compatible = "qcom,kaanapali-sndcard", "kaanapali"},
sorting
> {}
> };
>
>
> --
> 2.25.1
>
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 15+ messages in thread* Re: [PATCH 3/5] ASoC: qcom: sc8280xp: Add support for Kaanapali
2025-09-25 2:59 ` Dmitry Baryshkov
@ 2025-09-29 10:09 ` Prasad Kumpatla
0 siblings, 0 replies; 15+ messages in thread
From: Prasad Kumpatla @ 2025-09-29 10:09 UTC (permalink / raw)
To: Dmitry Baryshkov, Jingyi Wang
Cc: Srinivas Kandagatla, Liam Girdwood, Mark Brown, Jaroslav Kysela,
Takashi Iwai, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Rao Mandadapu, aiqun.yu, tingwei.zhang, trilok.soni, yijie.yang,
linux-sound, linux-arm-msm, linux-kernel, devicetree
On 9/25/2025 8:29 AM, Dmitry Baryshkov wrote:
> On Wed, Sep 24, 2025 at 05:01:17PM -0700, Jingyi Wang wrote:
>> From: Prasad Kumpatla <prasad.kumpatla@oss.qualcomm.com>
>>
>> Add compatible for sound card on Qualcomm Kaanapali boards.
>>
>> Signed-off-by: Prasad Kumpatla <prasad.kumpatla@oss.qualcomm.com>
>> Signed-off-by: Jingyi Wang <jingyi.wang@oss.qualcomm.com>
>> ---
>> sound/soc/qcom/sc8280xp.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/sound/soc/qcom/sc8280xp.c b/sound/soc/qcom/sc8280xp.c
>> index 288ccd7f8866..e231112175d9 100644
>> --- a/sound/soc/qcom/sc8280xp.c
>> +++ b/sound/soc/qcom/sc8280xp.c
>> @@ -198,6 +198,7 @@ static const struct of_device_id snd_sc8280xp_dt_match[] = {
>> {.compatible = "qcom,sm8550-sndcard", "sm8550"},
>> {.compatible = "qcom,sm8650-sndcard", "sm8650"},
>> {.compatible = "qcom,sm8750-sndcard", "sm8750"},
>> + {.compatible = "qcom,kaanapali-sndcard", "kaanapali"},
> sorting
Sure , will update in next patch.
Thanks,
Prasad
>
>> {}
>> };
>>
>>
>> --
>> 2.25.1
>>
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH 3/5] ASoC: qcom: sc8280xp: Add support for Kaanapali
2025-09-25 0:01 ` [PATCH 3/5] ASoC: qcom: sc8280xp: Add support for Kaanapali Jingyi Wang
2025-09-25 2:59 ` Dmitry Baryshkov
@ 2025-10-09 10:41 ` Krzysztof Kozlowski
1 sibling, 0 replies; 15+ messages in thread
From: Krzysztof Kozlowski @ 2025-10-09 10:41 UTC (permalink / raw)
To: Jingyi Wang, Srinivas Kandagatla, Liam Girdwood, Mark Brown,
Jaroslav Kysela, Takashi Iwai, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Rao Mandadapu
Cc: aiqun.yu, tingwei.zhang, trilok.soni, yijie.yang, linux-sound,
linux-arm-msm, linux-kernel, devicetree, Prasad Kumpatla
On 25/09/2025 09:01, Jingyi Wang wrote:
> From: Prasad Kumpatla <prasad.kumpatla@oss.qualcomm.com>
>
> Add compatible for sound card on Qualcomm Kaanapali boards.
>
> Signed-off-by: Prasad Kumpatla <prasad.kumpatla@oss.qualcomm.com>
> Signed-off-by: Jingyi Wang <jingyi.wang@oss.qualcomm.com>
> ---
> sound/soc/qcom/sc8280xp.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/sound/soc/qcom/sc8280xp.c b/sound/soc/qcom/sc8280xp.c
> index 288ccd7f8866..e231112175d9 100644
> --- a/sound/soc/qcom/sc8280xp.c
> +++ b/sound/soc/qcom/sc8280xp.c
> @@ -198,6 +198,7 @@ static const struct of_device_id snd_sc8280xp_dt_match[] = {
> {.compatible = "qcom,sm8550-sndcard", "sm8550"},
> {.compatible = "qcom,sm8650-sndcard", "sm8650"},
> {.compatible = "qcom,sm8750-sndcard", "sm8750"},
> + {.compatible = "qcom,kaanapali-sndcard", "kaanapali"},
Keep alphabetical order.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 15+ messages in thread
* [PATCH 4/5] dt-bindings: soundwire: qcom: Add SoundWire v2.2.0 compatible
2025-09-25 0:01 [PATCH 0/5] Add Audio Support for Kaanapali MTP Boards Jingyi Wang
` (2 preceding siblings ...)
2025-09-25 0:01 ` [PATCH 3/5] ASoC: qcom: sc8280xp: Add support for Kaanapali Jingyi Wang
@ 2025-09-25 0:01 ` Jingyi Wang
2025-10-09 10:42 ` Krzysztof Kozlowski
2025-09-25 0:01 ` [PATCH 5/5] ASoC: dt-bindings: qcom: Add Kaanapali LPASS macro codecs Jingyi Wang
4 siblings, 1 reply; 15+ messages in thread
From: Jingyi Wang @ 2025-09-25 0:01 UTC (permalink / raw)
To: Srinivas Kandagatla, Liam Girdwood, Mark Brown, Jaroslav Kysela,
Takashi Iwai, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Rao Mandadapu
Cc: aiqun.yu, tingwei.zhang, trilok.soni, yijie.yang, linux-sound,
linux-arm-msm, linux-kernel, devicetree, Jingyi Wang,
Prasad Kumpatla
From: Prasad Kumpatla <prasad.kumpatla@oss.qualcomm.com>
Add qcom,soundwire-v2.2.0 to the list of supported Qualcomm
SoundWire controller versions. This version falls back to
qcom,soundwire-v2.0.0 if not explicitly handled by the driver.
Signed-off-by: Prasad Kumpatla <prasad.kumpatla@oss.qualcomm.com>
Signed-off-by: Jingyi Wang <jingyi.wang@oss.qualcomm.com>
---
Documentation/devicetree/bindings/soundwire/qcom,soundwire.yaml | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/soundwire/qcom,soundwire.yaml b/Documentation/devicetree/bindings/soundwire/qcom,soundwire.yaml
index 95d947fda6a7..1c4b0bdbb044 100644
--- a/Documentation/devicetree/bindings/soundwire/qcom,soundwire.yaml
+++ b/Documentation/devicetree/bindings/soundwire/qcom,soundwire.yaml
@@ -26,6 +26,7 @@ properties:
- items:
- enum:
- qcom,soundwire-v2.1.0
+ - qcom,soundwire-v2.2.0
- const: qcom,soundwire-v2.0.0
reg:
--
2.25.1
^ permalink raw reply related [flat|nested] 15+ messages in thread* Re: [PATCH 4/5] dt-bindings: soundwire: qcom: Add SoundWire v2.2.0 compatible
2025-09-25 0:01 ` [PATCH 4/5] dt-bindings: soundwire: qcom: Add SoundWire v2.2.0 compatible Jingyi Wang
@ 2025-10-09 10:42 ` Krzysztof Kozlowski
0 siblings, 0 replies; 15+ messages in thread
From: Krzysztof Kozlowski @ 2025-10-09 10:42 UTC (permalink / raw)
To: Jingyi Wang, Srinivas Kandagatla, Liam Girdwood, Mark Brown,
Jaroslav Kysela, Takashi Iwai, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Rao Mandadapu
Cc: aiqun.yu, tingwei.zhang, trilok.soni, yijie.yang, linux-sound,
linux-arm-msm, linux-kernel, devicetree, Prasad Kumpatla
On 25/09/2025 09:01, Jingyi Wang wrote:
> From: Prasad Kumpatla <prasad.kumpatla@oss.qualcomm.com>
>
> Add qcom,soundwire-v2.2.0 to the list of supported Qualcomm
> SoundWire controller versions. This version falls back to
> qcom,soundwire-v2.0.0 if not explicitly handled by the driver.
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 15+ messages in thread
* [PATCH 5/5] ASoC: dt-bindings: qcom: Add Kaanapali LPASS macro codecs
2025-09-25 0:01 [PATCH 0/5] Add Audio Support for Kaanapali MTP Boards Jingyi Wang
` (3 preceding siblings ...)
2025-09-25 0:01 ` [PATCH 4/5] dt-bindings: soundwire: qcom: Add SoundWire v2.2.0 compatible Jingyi Wang
@ 2025-09-25 0:01 ` Jingyi Wang
2025-10-09 10:43 ` Krzysztof Kozlowski
4 siblings, 1 reply; 15+ messages in thread
From: Jingyi Wang @ 2025-09-25 0:01 UTC (permalink / raw)
To: Srinivas Kandagatla, Liam Girdwood, Mark Brown, Jaroslav Kysela,
Takashi Iwai, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Rao Mandadapu
Cc: aiqun.yu, tingwei.zhang, trilok.soni, yijie.yang, linux-sound,
linux-arm-msm, linux-kernel, devicetree, Jingyi Wang,
Prasad Kumpatla
From: Prasad Kumpatla <prasad.kumpatla@oss.qualcomm.com>
Add bindings for Qualcomm Kaanapali (LPASS) RX, TX, VA and WSA
macro codecs, which is likely compatible with earlier SM8550.
Signed-off-by: Prasad Kumpatla <prasad.kumpatla@oss.qualcomm.com>
Signed-off-by: Jingyi Wang <jingyi.wang@oss.qualcomm.com>
---
Documentation/devicetree/bindings/sound/qcom,lpass-rx-macro.yaml | 1 +
Documentation/devicetree/bindings/sound/qcom,lpass-tx-macro.yaml | 1 +
Documentation/devicetree/bindings/sound/qcom,lpass-va-macro.yaml | 1 +
Documentation/devicetree/bindings/sound/qcom,lpass-wsa-macro.yaml | 1 +
4 files changed, 4 insertions(+)
diff --git a/Documentation/devicetree/bindings/sound/qcom,lpass-rx-macro.yaml b/Documentation/devicetree/bindings/sound/qcom,lpass-rx-macro.yaml
index 92f95eb74b19..b869469a5848 100644
--- a/Documentation/devicetree/bindings/sound/qcom,lpass-rx-macro.yaml
+++ b/Documentation/devicetree/bindings/sound/qcom,lpass-rx-macro.yaml
@@ -20,6 +20,7 @@ properties:
- qcom,sc8280xp-lpass-rx-macro
- items:
- enum:
+ - qcom,kaanapali-lpass-rx-macro
- qcom,sm8650-lpass-rx-macro
- qcom,sm8750-lpass-rx-macro
- qcom,x1e80100-lpass-rx-macro
diff --git a/Documentation/devicetree/bindings/sound/qcom,lpass-tx-macro.yaml b/Documentation/devicetree/bindings/sound/qcom,lpass-tx-macro.yaml
index 914798a89878..e5e65e226a02 100644
--- a/Documentation/devicetree/bindings/sound/qcom,lpass-tx-macro.yaml
+++ b/Documentation/devicetree/bindings/sound/qcom,lpass-tx-macro.yaml
@@ -21,6 +21,7 @@ properties:
- qcom,sc8280xp-lpass-tx-macro
- items:
- enum:
+ - qcom,kaanapali-lpass-tx-macro
- qcom,sm8650-lpass-tx-macro
- qcom,sm8750-lpass-tx-macro
- qcom,x1e80100-lpass-tx-macro
diff --git a/Documentation/devicetree/bindings/sound/qcom,lpass-va-macro.yaml b/Documentation/devicetree/bindings/sound/qcom,lpass-va-macro.yaml
index 1c0d78af3c05..5b450f227b70 100644
--- a/Documentation/devicetree/bindings/sound/qcom,lpass-va-macro.yaml
+++ b/Documentation/devicetree/bindings/sound/qcom,lpass-va-macro.yaml
@@ -21,6 +21,7 @@ properties:
- items:
- enum:
- qcom,glymur-lpass-va-macro
+ - qcom,kaanapali-lpass-va-macro
- qcom,sm8650-lpass-va-macro
- qcom,sm8750-lpass-va-macro
- qcom,x1e80100-lpass-va-macro
diff --git a/Documentation/devicetree/bindings/sound/qcom,lpass-wsa-macro.yaml b/Documentation/devicetree/bindings/sound/qcom,lpass-wsa-macro.yaml
index b6f5ba5d1320..d5f22b5cf021 100644
--- a/Documentation/devicetree/bindings/sound/qcom,lpass-wsa-macro.yaml
+++ b/Documentation/devicetree/bindings/sound/qcom,lpass-wsa-macro.yaml
@@ -21,6 +21,7 @@ properties:
- items:
- enum:
- qcom,glymur-lpass-wsa-macro
+ - qcom,kaanapali-lpass-wsa-macro
- qcom,sm8650-lpass-wsa-macro
- qcom,sm8750-lpass-wsa-macro
- qcom,x1e80100-lpass-wsa-macro
--
2.25.1
^ permalink raw reply related [flat|nested] 15+ messages in thread* Re: [PATCH 5/5] ASoC: dt-bindings: qcom: Add Kaanapali LPASS macro codecs
2025-09-25 0:01 ` [PATCH 5/5] ASoC: dt-bindings: qcom: Add Kaanapali LPASS macro codecs Jingyi Wang
@ 2025-10-09 10:43 ` Krzysztof Kozlowski
0 siblings, 0 replies; 15+ messages in thread
From: Krzysztof Kozlowski @ 2025-10-09 10:43 UTC (permalink / raw)
To: Jingyi Wang, Srinivas Kandagatla, Liam Girdwood, Mark Brown,
Jaroslav Kysela, Takashi Iwai, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Rao Mandadapu
Cc: aiqun.yu, tingwei.zhang, trilok.soni, yijie.yang, linux-sound,
linux-arm-msm, linux-kernel, devicetree, Prasad Kumpatla
On 25/09/2025 09:01, Jingyi Wang wrote:
> From: Prasad Kumpatla <prasad.kumpatla@oss.qualcomm.com>
>
> Add bindings for Qualcomm Kaanapali (LPASS) RX, TX, VA and WSA
> macro codecs, which is likely compatible with earlier SM8550.
>
> Signed-off-by: Prasad Kumpatla <prasad.kumpatla@oss.qualcomm.com>
> Signed-off-by: Jingyi Wang <jingyi.wang@oss.qualcomm.com>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 15+ messages in thread