From: Dikshita Agarwal <dikshita.agarwal@oss.qualcomm.com>
To: Bryan O'Donoghue <bod@kernel.org>,
Neil Armstrong <neil.armstrong@linaro.org>,
Vikash Garodia <vikash.garodia@oss.qualcomm.com>,
Abhinav Kumar <abhinav.kumar@linux.dev>,
Mauro Carvalho Chehab <mchehab@kernel.org>
Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] media: iris: Add support for QC08C format for decoder
Date: Mon, 6 Oct 2025 11:51:19 +0530 [thread overview]
Message-ID: <66d3b851-5b29-ca88-53de-a4126c2b5366@oss.qualcomm.com> (raw)
In-Reply-To: <d603c0d3-4dd5-4ea0-8a31-47e6dd03ffd7@kernel.org>
On 10/1/2025 8:34 PM, Bryan O'Donoghue wrote:
> On 01/10/2025 09:36, Neil Armstrong wrote:
>> On 9/24/25 15:28, Bryan O'Donoghue wrote:
>>> On 19/09/2025 16:47, Dikshita Agarwal wrote:
>>>> Introduce handling for the QC08C format in the decoder.
>>>> Update format checks and configuration to enable decoding of QC08C
>>>> streams.
>>>
>>> Since QC08C is a Qualcomm specific pixel format, you should detail in
>>> your commit log exactly what the packing/ordering of pixels is.
>>>
>>> In other words tell the reader more about QC08C.
>>
>> This has been upstreamed 3y ago for venus, which is the same as iris:
>> https://lore.kernel.org/all/20220117155559.234026-1-stanimir.varbanov@linaro.org/
>>
>> No need to re-explain it for iris, the format is the same.
>>
>> Neil
> Yeah no, at a minimum the explanation of NV12 + UBWC should appear in the
> commit log for this format.
Please see [1] in case it was missed
[1]:
https://lore.kernel.org/linux-media/10bb819d-105b-5471-b3a6-774fce134eb6@oss.qualcomm.com/
Thanks,
Dikshita
>
> thx
> ---
> bod
next prev parent reply other threads:[~2025-10-06 6:21 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-19 15:47 [PATCH 0/2] Add support for QC08C format in iris driver Dikshita Agarwal
2025-09-19 15:47 ` [PATCH 1/2] media: iris: Add support for QC08C format for decoder Dikshita Agarwal
2025-09-19 16:54 ` Dmitry Baryshkov
2025-09-24 10:54 ` Dikshita Agarwal
2025-09-24 16:23 ` Dmitry Baryshkov
2025-10-01 8:24 ` Dikshita Agarwal
2025-09-24 12:32 ` Markus Elfring
2025-09-24 15:50 ` Nicolas Dufresne
2025-09-24 13:28 ` Bryan O'Donoghue
2025-10-01 8:36 ` Neil Armstrong
2025-10-01 15:04 ` Bryan O'Donoghue
2025-10-06 6:21 ` Dikshita Agarwal [this message]
2025-10-06 10:18 ` Dmitry Baryshkov
2025-10-01 8:38 ` Dikshita Agarwal
2025-09-19 15:47 ` [PATCH 2/2] media: iris: Add support for QC08C format for encoder Dikshita Agarwal
2025-09-24 12:40 ` Markus Elfring
2025-09-24 13:31 ` Bryan O'Donoghue
2025-10-01 8:39 ` [PATCH 0/2] Add support for QC08C format in iris driver Neil Armstrong
2025-10-01 9:00 ` Dikshita Agarwal
2025-10-01 13:47 ` Nicolas Dufresne
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=66d3b851-5b29-ca88-53de-a4126c2b5366@oss.qualcomm.com \
--to=dikshita.agarwal@oss.qualcomm.com \
--cc=abhinav.kumar@linux.dev \
--cc=bod@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=vikash.garodia@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox