From: Markus Elfring <Markus.Elfring@web.de>
To: Dikshita Agarwal <dikshita.agarwal@oss.qualcomm.com>,
linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org
Cc: LKML <linux-kernel@vger.kernel.org>,
Abhinav Kumar <abhinav.kumar@linux.dev>,
Bryan O'Donoghue <bod@kernel.org>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Vikash Garodia <vikash.garodia@oss.qualcomm.com>
Subject: Re: [PATCH 1/2] media: iris: Add support for QC08C format for decoder
Date: Wed, 24 Sep 2025 14:32:32 +0200 [thread overview]
Message-ID: <ce08ae79-8f7e-4a37-85b9-d86c10567881@web.de> (raw)
In-Reply-To: <20250919-video-iris-ubwc-enable-v1-1-000d11edafd8@oss.qualcomm.com>
…
> +++ b/drivers/media/platform/qcom/iris/iris_buffer.c
> @@ -261,7 +261,10 @@ int iris_get_buffer_size(struct iris_inst *inst,
> case BUF_INPUT:
> return iris_dec_bitstream_buffer_size(inst);
> case BUF_OUTPUT:
> - return iris_yuv_buffer_size_nv12(inst);
> + if (inst->fmt_dst->fmt.pix_mp.pixelformat == V4L2_PIX_FMT_QC08C)
> + return iris_yuv_buffer_size_qc08c(inst);
> + else
> + return iris_yuv_buffer_size_nv12(inst);
…
How do you think about to use a source code variant like the following?
return (inst->fmt_dst->fmt.pix_mp.pixelformat == V4L2_PIX_FMT_QC08C)
? iris_yuv_buffer_size_qc08c(inst)
: iris_yuv_buffer_size_nv12(inst);
Regards,
Markus
next prev parent reply other threads:[~2025-09-24 12:32 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-19 15:47 [PATCH 0/2] Add support for QC08C format in iris driver Dikshita Agarwal
2025-09-19 15:47 ` [PATCH 1/2] media: iris: Add support for QC08C format for decoder Dikshita Agarwal
2025-09-19 16:54 ` Dmitry Baryshkov
2025-09-24 10:54 ` Dikshita Agarwal
2025-09-24 16:23 ` Dmitry Baryshkov
2025-10-01 8:24 ` Dikshita Agarwal
2025-09-24 12:32 ` Markus Elfring [this message]
2025-09-24 15:50 ` Nicolas Dufresne
2025-09-24 13:28 ` Bryan O'Donoghue
2025-10-01 8:36 ` Neil Armstrong
2025-10-01 15:04 ` Bryan O'Donoghue
2025-10-06 6:21 ` Dikshita Agarwal
2025-10-06 10:18 ` Dmitry Baryshkov
2025-10-01 8:38 ` Dikshita Agarwal
2025-09-19 15:47 ` [PATCH 2/2] media: iris: Add support for QC08C format for encoder Dikshita Agarwal
2025-09-24 12:40 ` Markus Elfring
2025-09-24 13:31 ` Bryan O'Donoghue
2025-10-01 8:39 ` [PATCH 0/2] Add support for QC08C format in iris driver Neil Armstrong
2025-10-01 9:00 ` Dikshita Agarwal
2025-10-01 13:47 ` Nicolas Dufresne
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ce08ae79-8f7e-4a37-85b9-d86c10567881@web.de \
--to=markus.elfring@web.de \
--cc=abhinav.kumar@linux.dev \
--cc=bod@kernel.org \
--cc=dikshita.agarwal@oss.qualcomm.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=vikash.garodia@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox