From: Krzysztof Kozlowski <krzk@kernel.org>
To: Jingyi Wang <jingyi.wang@oss.qualcomm.com>,
Manivannan Sadhasivam <mani@kernel.org>,
Jassi Brar <jassisinghbrar@gmail.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>
Cc: aiqun.yu@oss.qualcomm.com, tingwei.zhang@oss.qualcomm.com,
trilok.soni@oss.qualcomm.com, yijie.yang@oss.qualcomm.com,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org,
Sibi Sankar <sibi.sankar@oss.qualcomm.com>
Subject: Re: [PATCH v2 2/2] dt-bindings: mailbox: qcom: Add IPCC support for Glymur Platform
Date: Wed, 29 Oct 2025 16:49:30 +0100 [thread overview]
Message-ID: <67038d9f-7c6c-4bb3-ba64-b06816b76be7@kernel.org> (raw)
In-Reply-To: <20251029-knp-ipcc-v2-2-8ba303ab82de@oss.qualcomm.com>
On 29/10/2025 09:15, Jingyi Wang wrote:
> diff --git a/include/dt-bindings/mailbox/qcom,glymur-ipcc.h b/include/dt-bindings/mailbox/qcom,glymur-ipcc.h
> new file mode 100644
> index 000000000000..3ab8189974a5
> --- /dev/null
> +++ b/include/dt-bindings/mailbox/qcom,glymur-ipcc.h
> @@ -0,0 +1,68 @@
> +/* SPDX-License-Identifier: GPL-2.0 OR BSD-2-Clause */
> +/*
> + * Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries.
> + */
> +
> +#ifndef __DT_BINDINGS_MAILBOX_IPCC_GLYMUR_H
> +#define __DT_BINDINGS_MAILBOX_IPCC_GLYMUR_H
> +
> +/* Glymur physical client IDs */
> +#define IPCC_MPROC_AOP 0
Here the same - not used by Linux. Don't add these, they are really not
necessary and they are not helping anyhow. For longer explanation see 2
year thread for PMIC ADC v7.
Or provide explanation in terms what Linux interface you are binding
here (please focus on Linux or other SW).
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-10-29 15:49 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-29 8:15 [PATCH v2 0/2] dt-bindings: mailbox: qcom-ipcc: Add IPCC on Kaanapali and Glymur Platforms Jingyi Wang
2025-10-29 8:15 ` [PATCH v2 1/2] dt-bindings: mailbox: qcom: Add IPCC support for Kaanapali Platform Jingyi Wang
2025-10-29 15:16 ` Bjorn Andersson
2025-10-29 15:47 ` Krzysztof Kozlowski
2025-10-29 16:15 ` Bjorn Andersson
2025-10-30 5:55 ` Krzysztof Kozlowski
2025-10-29 8:15 ` [PATCH v2 2/2] dt-bindings: mailbox: qcom: Add IPCC support for Glymur Platform Jingyi Wang
2025-10-29 15:18 ` Bjorn Andersson
2025-10-29 15:49 ` Krzysztof Kozlowski [this message]
2025-10-29 17:23 ` Bjorn Andersson
2025-10-30 5:53 ` Krzysztof Kozlowski
2025-10-30 19:11 ` Bjorn Andersson
2025-10-31 2:04 ` Jingyi Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=67038d9f-7c6c-4bb3-ba64-b06816b76be7@kernel.org \
--to=krzk@kernel.org \
--cc=aiqun.yu@oss.qualcomm.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jassisinghbrar@gmail.com \
--cc=jingyi.wang@oss.qualcomm.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mani@kernel.org \
--cc=robh@kernel.org \
--cc=sibi.sankar@oss.qualcomm.com \
--cc=tingwei.zhang@oss.qualcomm.com \
--cc=trilok.soni@oss.qualcomm.com \
--cc=yijie.yang@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox