From: Krzysztof Kozlowski <krzk@kernel.org>
To: Bjorn Andersson <andersson@kernel.org>,
Jingyi Wang <jingyi.wang@oss.qualcomm.com>
Cc: Manivannan Sadhasivam <mani@kernel.org>,
Jassi Brar <jassisinghbrar@gmail.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
aiqun.yu@oss.qualcomm.com, tingwei.zhang@oss.qualcomm.com,
trilok.soni@oss.qualcomm.com, yijie.yang@oss.qualcomm.com,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH v2 1/2] dt-bindings: mailbox: qcom: Add IPCC support for Kaanapali Platform
Date: Wed, 29 Oct 2025 16:47:17 +0100 [thread overview]
Message-ID: <cdfde03c-0fa1-4142-87b6-7c023e0b5c0d@kernel.org> (raw)
In-Reply-To: <k2wgpzkfklso42nsd6w527gqiadgdb235kzmvgk4wy27vievir@vlyxti5y7yan>
On 29/10/2025 16:16, Bjorn Andersson wrote:
> On Wed, Oct 29, 2025 at 01:15:09AM -0700, Jingyi Wang wrote:
>> Add the physical client ids and binding for Kaanapali platform. Physical
>> client IDs instead of virtual client IDs are used for qcom new platforms
>> in the Inter Process Communication Controller (IPCC) driver as virtual to
>> physical mapping logic is removed in HW.
>
> Happy to see the description of what changed wrt physical vs virtual
> client IDs, but you're leaving the task of figuring out how this
> explanation is applicable to the imagination of the reader.
>
> Nobody knows that the values in dt-bindings/mailbox/qcom-ipcc.h are
> "virtual client IDs", so it's not clear that you're trying to provide an
> explanation to why a new, platform-specific, header file is needed here.
>
>
Physical or virtual, standard expectation is that they are used by the
driver. This does not happen here, so what do they exactly represent?
Which part of SW ABI?
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-10-29 15:47 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-29 8:15 [PATCH v2 0/2] dt-bindings: mailbox: qcom-ipcc: Add IPCC on Kaanapali and Glymur Platforms Jingyi Wang
2025-10-29 8:15 ` [PATCH v2 1/2] dt-bindings: mailbox: qcom: Add IPCC support for Kaanapali Platform Jingyi Wang
2025-10-29 15:16 ` Bjorn Andersson
2025-10-29 15:47 ` Krzysztof Kozlowski [this message]
2025-10-29 16:15 ` Bjorn Andersson
2025-10-30 5:55 ` Krzysztof Kozlowski
2025-10-29 8:15 ` [PATCH v2 2/2] dt-bindings: mailbox: qcom: Add IPCC support for Glymur Platform Jingyi Wang
2025-10-29 15:18 ` Bjorn Andersson
2025-10-29 15:49 ` Krzysztof Kozlowski
2025-10-29 17:23 ` Bjorn Andersson
2025-10-30 5:53 ` Krzysztof Kozlowski
2025-10-30 19:11 ` Bjorn Andersson
2025-10-31 2:04 ` Jingyi Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cdfde03c-0fa1-4142-87b6-7c023e0b5c0d@kernel.org \
--to=krzk@kernel.org \
--cc=aiqun.yu@oss.qualcomm.com \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jassisinghbrar@gmail.com \
--cc=jingyi.wang@oss.qualcomm.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mani@kernel.org \
--cc=robh@kernel.org \
--cc=tingwei.zhang@oss.qualcomm.com \
--cc=trilok.soni@oss.qualcomm.com \
--cc=yijie.yang@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox