From: Johannes Berg <johannes@sipsolutions.net>
To: Eugen Hristev <eugen.hristev@linaro.org>,
linux-arm-msm@vger.kernel.org, linux-hardening@vger.kernel.org,
kees@kernel.org
Cc: linux-kernel@vger.kernel.org, gregkh@linuxfoundation.org,
rafael@kernel.org, dakr@kernel.org, andersson@kernel.org,
konradybcio@kernel.org, tony.luck@intel.com,
gpiccoli@igalia.com, pmladek@suse.com, rostedt@goodmis.org,
john.ogness@linutronix.de, senozhatsky@chromium.org,
quic_mojha@quicinc.com, linux-arm-kernel@lists.infradead.org,
kernel@quicinc.com
Subject: Re: [RFC][PATCH 00/10] pstore: directly mapped regions
Date: Mon, 17 Feb 2025 12:43:56 +0100 [thread overview]
Message-ID: <673d0ef9477f1dfbed474cc51ad68092814dfe85.camel@sipsolutions.net> (raw)
In-Reply-To: <885a9312-484a-4b60-bec0-5adf8f1e4a0e@linaro.org>
On Mon, 2025-02-17 at 13:39 +0200, Eugen Hristev wrote:
>
> On 2/17/25 13:19, Johannes Berg wrote:
> > On Mon, 2025-02-17 at 12:44 +0200, Eugen Hristev wrote:
> > >
> > > At this moment going through devcoredump is not something that impacts
> > > the idea of the implementation.
> >
> > Yeah. I don't think it _should_ go through it at all.
> >
> > > The whole reason of going through it (because things work without it as
> > > well), is to see whether this has any kind of impact or not, and if
> > > there is any kind of fit/reason of going through it.
> >
> > So it's just a trial balloon?
>
> Yes, that's why it's marked as an RFC.
>
(IMHO) that doesn't make it acceptable to just randomly go modify code
you don't understand the purpose of, certainly not without actually
stating such. But anyway, I'll leave it at that.
johannes
prev parent reply other threads:[~2025-02-17 11:44 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-17 10:16 [RFC][PATCH 00/10] pstore: directly mapped regions Eugen Hristev
2025-02-17 10:16 ` [RFC][PATCH 01/10] pstore/zone: move pstore_device_info into zone header Eugen Hristev
2025-02-17 10:16 ` [RFC][PATCH 02/10] pstore/smem: add new pstore/smem type of pstore Eugen Hristev
2025-02-17 10:16 ` [RFC][PATCH 03/10] pstore/zone: introduce directly mapped zones Eugen Hristev
2025-02-17 10:17 ` [RFC][PATCH 04/10] qcom: smem: add pstore smem backend Eugen Hristev
2025-02-17 10:17 ` [RFC][PATCH 05/10] pstore: implement core area registration Eugen Hristev
2025-02-17 10:17 ` [RFC][PATCH 06/10] qcom: smem: enable smem pstore backend Eugen Hristev
2025-02-17 10:17 ` [RFC][PATCH 07/10] printk: export symbols for buffer address and length functions Eugen Hristev
2025-02-18 8:26 ` Christoph Hellwig
2025-02-18 8:58 ` Sergey Senozhatsky
2025-02-18 9:11 ` Eugen Hristev
2025-02-17 10:17 ` [RFC][PATCH 08/10] pstore: register kmsg into directly mapped zones if available Eugen Hristev
2025-02-17 10:17 ` [RFC][PATCH 09/10] devcoredump: add devcd_{un}register_core_area API Eugen Hristev
2025-02-17 10:17 ` [RFC][PATCH 10/10] rng: qcom_rng: EXAMPLE: registering dev structure Eugen Hristev
2025-02-17 10:23 ` [RFC][PATCH 00/10] pstore: directly mapped regions Johannes Berg
2025-02-17 10:44 ` Eugen Hristev
2025-02-17 11:19 ` Johannes Berg
2025-02-17 11:39 ` Eugen Hristev
2025-02-17 11:43 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=673d0ef9477f1dfbed474cc51ad68092814dfe85.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=andersson@kernel.org \
--cc=dakr@kernel.org \
--cc=eugen.hristev@linaro.org \
--cc=gpiccoli@igalia.com \
--cc=gregkh@linuxfoundation.org \
--cc=john.ogness@linutronix.de \
--cc=kees@kernel.org \
--cc=kernel@quicinc.com \
--cc=konradybcio@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmladek@suse.com \
--cc=quic_mojha@quicinc.com \
--cc=rafael@kernel.org \
--cc=rostedt@goodmis.org \
--cc=senozhatsky@chromium.org \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox