* [PATCH v1 0/2] arm64: dts: qcom: sa8775p: Add sa8775p camss support @ 2025-02-10 15:56 Vikram Sharma 2025-02-10 15:56 ` [PATCH v1 1/2] media: dt-bindings: Add qcom,sa8775p-camss Vikram Sharma 2025-02-10 15:56 ` [PATCH v1 2/2] arm64: dts: qcom: sa8775p: Add support for camss Vikram Sharma 0 siblings, 2 replies; 10+ messages in thread From: Vikram Sharma @ 2025-02-10 15:56 UTC (permalink / raw) To: rfoss, todor.too, bryan.odonoghue, mchehab, robh, krzk+dt, conor+dt, andersson, konradybcio, hverkuil-cisco, cros-qcom-dts-watchers, catalin.marinas, will Cc: linux-arm-kernel, quic_vikramsa, linux-media, linux-arm-msm, devicetree, linux-kernel SA8775P is a Qualcomm SoC. This series adds bindings and devicetree to bring up CSIPHY, TPG, CSID, VFE/RDI interfaces in SA8775P. SA8775P provides - 2 x VFE, 3 RDI per VFE - 5 x VFE Lite, 6 RDI per VFE - 2 x CSID - 5 x CSID Lite - 3 x TPG - 4 x CSIPHY Used following tools for the sanity check of these changes. - make CHECK_DTBS=y W=1 DT_SCHEMA_FILES=media/qcom,sc7280-camss.yaml qcom/qcs6490-rb3gen2-vision-mezzanine.dtb - make DT_CHECKER_FLAGS=-m W=1 DT_SCHEMA_FILES=media/qcom,sc7280-camss.yaml dt_binding_check - make -j32 W=1 - ./scripts/checkpatch.pl Signed-off-by: Vikram Sharma <quic_vikramsa@quicinc.com> Vikram Sharma (2): media: dt-bindings: Add qcom,sa8775p-camss arm64: dts: qcom: sa8775p: Add support for camss .../bindings/media/qcom,sa8775p-camss.yaml | 351 ++++++++++++++++++ arch/arm64/boot/dts/qcom/sa8775p.dtsi | 187 ++++++++++ 2 files changed, 538 insertions(+) create mode 100644 Documentation/devicetree/bindings/media/qcom,sa8775p-camss.yaml -- 2.25.1 ^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH v1 1/2] media: dt-bindings: Add qcom,sa8775p-camss 2025-02-10 15:56 [PATCH v1 0/2] arm64: dts: qcom: sa8775p: Add sa8775p camss support Vikram Sharma @ 2025-02-10 15:56 ` Vikram Sharma 2025-02-11 10:08 ` Bryan O'Donoghue 2025-02-10 15:56 ` [PATCH v1 2/2] arm64: dts: qcom: sa8775p: Add support for camss Vikram Sharma 1 sibling, 1 reply; 10+ messages in thread From: Vikram Sharma @ 2025-02-10 15:56 UTC (permalink / raw) To: rfoss, todor.too, bryan.odonoghue, mchehab, robh, krzk+dt, conor+dt, andersson, konradybcio, hverkuil-cisco, cros-qcom-dts-watchers, catalin.marinas, will Cc: linux-arm-kernel, quic_vikramsa, linux-media, linux-arm-msm, devicetree, linux-kernel Add bindings for qcom,sa8775p-camss to support the camera subsystem on SA8775P platform. Signed-off-by: Vikram Sharma <quic_vikramsa@quicinc.com> --- .../bindings/media/qcom,sa8775p-camss.yaml | 351 ++++++++++++++++++ 1 file changed, 351 insertions(+) create mode 100644 Documentation/devicetree/bindings/media/qcom,sa8775p-camss.yaml diff --git a/Documentation/devicetree/bindings/media/qcom,sa8775p-camss.yaml b/Documentation/devicetree/bindings/media/qcom,sa8775p-camss.yaml new file mode 100644 index 000000000000..083e1193c474 --- /dev/null +++ b/Documentation/devicetree/bindings/media/qcom,sa8775p-camss.yaml @@ -0,0 +1,351 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/media/qcom,sa8775p-camss.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Qualcomm SA8775P CAMSS ISP + +maintainers: + - Vikram Sharma <quic_vikramsa@quicinc.com> + +description: + The CAMSS IP is a CSI decoder and ISP present on Qualcomm platforms. + +properties: + compatible: + const: qcom,sa8775p-camss + + reg: + maxItems: 22 + + reg-names: + items: + - const: csid0 + - const: csid1 + - const: csid_lite0 + - const: csid_lite1 + - const: csid_lite2 + - const: csid_lite3 + - const: csid_lite4 + - const: csid_wrapper + - const: csiphy0 + - const: csiphy1 + - const: csiphy2 + - const: csiphy3 + - const: tpg0 + - const: tpg1 + - const: tpg2 + - const: vfe0 + - const: vfe1 + - const: vfe_lite0 + - const: vfe_lite1 + - const: vfe_lite2 + - const: vfe_lite3 + - const: vfe_lite4 + + clocks: + maxItems: 28 + + clock-names: + items: + - const: camnoc_axi + - const: core_ahb + - const: cpas_ahb + - const: cpas_fast_ahb_clk + - const: cpas_ife_lite + - const: cpas_vfe0 + - const: cpas_vfe1 + - const: csid + - const: csiphy0 + - const: csiphy0_timer + - const: csiphy1 + - const: csiphy1_timer + - const: csiphy2 + - const: csiphy2_timer + - const: csiphy3 + - const: csiphy3_timer + - const: csiphy_rx + - const: gcc_axi_hf + - const: gcc_axi_sf + - const: icp_ahb + - const: vfe0 + - const: vfe0_fast_ahb + - const: vfe1 + - const: vfe1_fast_ahb + - const: vfe_lite + - const: vfe_lite_ahb + - const: vfe_lite_cphy_rx + - const: vfe_lite_csid + + interrupts: + maxItems: 21 + + interrupt-names: + items: + - const: csid0 + - const: csid1 + - const: csid-lite0 + - const: csid-lite1 + - const: csid-lite2 + - const: csid-lite3 + - const: csid-lite4 + - const: csiphy0 + - const: csiphy1 + - const: csiphy2 + - const: csiphy3 + - const: tpg0 + - const: tpg1 + - const: tpg2 + - const: vfe0 + - const: vfe1 + - const: vfe-lite0 + - const: vfe-lite1 + - const: vfe-lite2 + - const: vfe-lite3 + - const: vfe-lite4 + + interconnects: + maxItems: 3 + + interconnect-names: + items: + - const: ahb + - const: hf_0 + - const: sf_0 + + iommus: + maxItems: 1 + + power-domains: + items: + - description: Titan GDSC - Titan ISP Block, Global Distributed Switch Controller. + + power-domain-names: + items: + - const: top + + ports: + $ref: /schemas/graph.yaml#/properties/ports + + description: + CSI input ports. + + patternProperties: + "^port@[0-3]+$": + $ref: /schemas/graph.yaml#/$defs/port-base + unevaluatedProperties: false + description: + Input port for receiving CSI data on CSIPHY 0-3. + + properties: + endpoint: + $ref: video-interfaces.yaml# + unevaluatedProperties: false + + properties: + data-lanes: + minItems: 1 + maxItems: 4 + + required: + - data-lanes + +required: + - compatible + - reg + - reg-names + - clocks + - clock-names + - interrupts + - interrupt-names + - interconnects + - interconnect-names + - iommus + - power-domains + - power-domain-names + +additionalProperties: false + +examples: + - | + #include <dt-bindings/clock/qcom,sa8775p-camcc.h> + #include <dt-bindings/clock/qcom,sa8775p-gcc.h> + #include <dt-bindings/interconnect/qcom,sa8775p-rpmh.h> + #include <dt-bindings/interconnect/qcom,icc.h> + #include <dt-bindings/interrupt-controller/arm-gic.h> + #include <dt-bindings/power/qcom-rpmpd.h> + + soc { + #address-cells = <2>; + #size-cells = <2>; + + isp@ac7a000 { + compatible = "qcom,sa8775p-camss"; + + reg = <0x0 0xac7a000 0x0 0x0f01>, + <0x0 0xac7c000 0x0 0x0f01>, + <0x0 0xac84000 0x0 0x0f01>, + <0x0 0xac88000 0x0 0x0f01>, + <0x0 0xac8c000 0x0 0x0f01>, + <0x0 0xac90000 0x0 0x0f01>, + <0x0 0xac94000 0x0 0x0f01>, + <0x0 0xac78000 0x0 0x1000>, + <0x0 0xac9c000 0x0 0x2000>, + <0x0 0xac9e000 0x0 0x2000>, + <0x0 0xaca0000 0x0 0x2000>, + <0x0 0xaca2000 0x0 0x2000>, + <0x0 0xacac000 0x0 0x0400>, + <0x0 0xacad000 0x0 0x0400>, + <0x0 0xacae000 0x0 0x0400>, + <0x0 0xac4d000 0x0 0xd000>, + <0x0 0xac5a000 0x0 0xd000>, + <0x0 0xac85000 0x0 0x0d00>, + <0x0 0xac89000 0x0 0x0d00>, + <0x0 0xac8d000 0x0 0x0d00>, + <0x0 0xac91000 0x0 0x0d00>, + <0x0 0xac95000 0x0 0x0d00>; + reg-names = "csid0", + "csid1", + "csid_lite0", + "csid_lite1", + "csid_lite2", + "csid_lite3", + "csid_lite4", + "csid_wrapper", + "csiphy0", + "csiphy1", + "csiphy2", + "csiphy3", + "tpg0", + "tpg1", + "tpg2", + "vfe0", + "vfe1", + "vfe_lite0", + "vfe_lite1", + "vfe_lite2", + "vfe_lite3", + "vfe_lite4"; + + clocks = <&camcc CAM_CC_CAMNOC_AXI_CLK>, + <&camcc CAM_CC_CORE_AHB_CLK>, + <&camcc CAM_CC_CPAS_AHB_CLK>, + <&camcc CAM_CC_CPAS_FAST_AHB_CLK>, + <&camcc CAM_CC_CPAS_IFE_LITE_CLK>, + <&camcc CAM_CC_CPAS_IFE_0_CLK>, + <&camcc CAM_CC_CPAS_IFE_1_CLK>, + <&camcc CAM_CC_CSID_CLK>, + <&camcc CAM_CC_CSIPHY0_CLK>, + <&camcc CAM_CC_CSI0PHYTIMER_CLK>, + <&camcc CAM_CC_CSIPHY1_CLK>, + <&camcc CAM_CC_CSI1PHYTIMER_CLK>, + <&camcc CAM_CC_CSIPHY2_CLK>, + <&camcc CAM_CC_CSI2PHYTIMER_CLK>, + <&camcc CAM_CC_CSIPHY3_CLK>, + <&camcc CAM_CC_CSI3PHYTIMER_CLK>, + <&camcc CAM_CC_CSID_CSIPHY_RX_CLK>, + <&gcc GCC_CAMERA_HF_AXI_CLK>, + <&gcc GCC_CAMERA_SF_AXI_CLK>, + <&camcc CAM_CC_ICP_AHB_CLK>, + <&camcc CAM_CC_IFE_0_CLK>, + <&camcc CAM_CC_IFE_0_FAST_AHB_CLK>, + <&camcc CAM_CC_IFE_1_CLK>, + <&camcc CAM_CC_IFE_1_FAST_AHB_CLK>, + <&camcc CAM_CC_IFE_LITE_CLK>, + <&camcc CAM_CC_IFE_LITE_AHB_CLK>, + <&camcc CAM_CC_IFE_LITE_CPHY_RX_CLK>, + <&camcc CAM_CC_IFE_LITE_CSID_CLK>; + clock-names = "camnoc_axi", + "core_ahb", + "cpas_ahb", + "cpas_fast_ahb_clk", + "cpas_ife_lite", + "cpas_vfe0", + "cpas_vfe1", + "csid", + "csiphy0", + "csiphy0_timer", + "csiphy1", + "csiphy1_timer", + "csiphy2", + "csiphy2_timer", + "csiphy3", + "csiphy3_timer", + "csiphy_rx", + "gcc_axi_hf", + "gcc_axi_sf", + "icp_ahb", + "vfe0", + "vfe0_fast_ahb", + "vfe1", + "vfe1_fast_ahb", + "vfe_lite", + "vfe_lite_ahb", + "vfe_lite_cphy_rx", + "vfe_lite_csid"; + + interrupts = <GIC_SPI 565 IRQ_TYPE_EDGE_RISING>, + <GIC_SPI 564 IRQ_TYPE_EDGE_RISING>, + <GIC_SPI 468 IRQ_TYPE_EDGE_RISING>, + <GIC_SPI 359 IRQ_TYPE_EDGE_RISING>, + <GIC_SPI 759 IRQ_TYPE_EDGE_RISING>, + <GIC_SPI 758 IRQ_TYPE_EDGE_RISING>, + <GIC_SPI 604 IRQ_TYPE_EDGE_RISING>, + <GIC_SPI 477 IRQ_TYPE_EDGE_RISING>, + <GIC_SPI 478 IRQ_TYPE_EDGE_RISING>, + <GIC_SPI 479 IRQ_TYPE_EDGE_RISING>, + <GIC_SPI 448 IRQ_TYPE_EDGE_RISING>, + <GIC_SPI 545 IRQ_TYPE_EDGE_RISING>, + <GIC_SPI 546 IRQ_TYPE_EDGE_RISING>, + <GIC_SPI 547 IRQ_TYPE_EDGE_RISING>, + <GIC_SPI 465 IRQ_TYPE_EDGE_RISING>, + <GIC_SPI 467 IRQ_TYPE_EDGE_RISING>, + <GIC_SPI 469 IRQ_TYPE_EDGE_RISING>, + <GIC_SPI 360 IRQ_TYPE_EDGE_RISING>, + <GIC_SPI 761 IRQ_TYPE_EDGE_RISING>, + <GIC_SPI 760 IRQ_TYPE_EDGE_RISING>, + <GIC_SPI 605 IRQ_TYPE_EDGE_RISING>; + interrupt-names = "csid0", + "csid1", + "csid-lite0", + "csid-lite1", + "csid-lite2", + "csid-lite3", + "csid-lite4", + "csiphy0", + "csiphy1", + "csiphy2", + "csiphy3", + "tpg0", + "tpg1", + "tpg2", + "vfe0", + "vfe1", + "vfe-lite0", + "vfe-lite1", + "vfe-lite2", + "vfe-lite3", + "vfe-lite4"; + + interconnects = <&gem_noc MASTER_APPSS_PROC QCOM_ICC_TAG_ACTIVE_ONLY + &config_noc SLAVE_CAMERA_CFG QCOM_ICC_TAG_ACTIVE_ONLY>, + <&mmss_noc MASTER_CAMNOC_HF QCOM_ICC_TAG_ALWAYS + &mc_virt SLAVE_EBI1 QCOM_ICC_TAG_ALWAYS>, + <&mmss_noc MASTER_CAMNOC_SF QCOM_ICC_TAG_ACTIVE_ONLY + &mc_virt SLAVE_EBI1 QCOM_ICC_TAG_ACTIVE_ONLY>; + interconnect-names = "ahb", + "hf_0", + "sf_0"; + + iommus = <&apps_smmu 0x3400 0x20>; + + power-domains = <&camcc CAM_CC_TITAN_TOP_GDSC>; + power-domain-names = "top"; + + ports { + #address-cells = <1>; + #size-cells = <0>; + }; + }; + }; -- 2.25.1 ^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH v1 1/2] media: dt-bindings: Add qcom,sa8775p-camss 2025-02-10 15:56 ` [PATCH v1 1/2] media: dt-bindings: Add qcom,sa8775p-camss Vikram Sharma @ 2025-02-11 10:08 ` Bryan O'Donoghue 2025-02-12 7:19 ` Vikram Sharma 0 siblings, 1 reply; 10+ messages in thread From: Bryan O'Donoghue @ 2025-02-11 10:08 UTC (permalink / raw) To: Vikram Sharma, rfoss, todor.too, mchehab, robh, krzk+dt, conor+dt, andersson, konradybcio, hverkuil-cisco, cros-qcom-dts-watchers, catalin.marinas, will Cc: linux-arm-kernel, linux-media, linux-arm-msm, devicetree, linux-kernel On 10/02/2025 15:56, Vikram Sharma wrote: > Add bindings for qcom,sa8775p-camss to support the camera subsystem > on SA8775P platform. > > Signed-off-by: Vikram Sharma <quic_vikramsa@quicinc.com> > --- > .../bindings/media/qcom,sa8775p-camss.yaml | 351 ++++++++++++++++++ > 1 file changed, 351 insertions(+) > create mode 100644 Documentation/devicetree/bindings/media/qcom,sa8775p-camss.yaml > > diff --git a/Documentation/devicetree/bindings/media/qcom,sa8775p-camss.yaml b/Documentation/devicetree/bindings/media/qcom,sa8775p-camss.yaml > new file mode 100644 > index 000000000000..083e1193c474 > --- /dev/null > +++ b/Documentation/devicetree/bindings/media/qcom,sa8775p-camss.yaml > @@ -0,0 +1,351 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/media/qcom,sa8775p-camss.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Qualcomm SA8775P CAMSS ISP > + > +maintainers: > + - Vikram Sharma <quic_vikramsa@quicinc.com> > + > +description: > + The CAMSS IP is a CSI decoder and ISP present on Qualcomm platforms. > + > +properties: > + compatible: > + const: qcom,sa8775p-camss > + > + reg: > + maxItems: 22 > + > + reg-names: > + items: > + - const: csid0 > + - const: csid1 > + - const: csid_lite0 > + - const: csid_lite1 > + - const: csid_lite2 > + - const: csid_lite3 > + - const: csid_lite4 > + - const: csid_wrapper csid_wrapper should come first https://git.codelinaro.org/bryan.odonoghue/kernel/-/blob/x1e80100-6.13-inspiron14p/Documentation/devicetree/bindings/media/qcom,x1e80100-camss.yaml?ref_type=heads > + - const: csiphy0 > + - const: csiphy1 > + - const: csiphy2 > + - const: csiphy3 > + - const: tpg0 > + - const: tpg1 > + - const: tpg2 > + - const: vfe0 > + - const: vfe1 > + - const: vfe_lite0 > + - const: vfe_lite1 > + - const: vfe_lite2 > + - const: vfe_lite3 > + - const: vfe_lite4 > + > + clocks: > + maxItems: 28 > + > + clock-names: > + items: > + - const: camnoc_axi > + - const: core_ahb > + - const: cpas_ahb > + - const: cpas_fast_ahb_clk > + - const: cpas_ife_lite > + - const: cpas_vfe0 > + - const: cpas_vfe1 > + - const: csid > + - const: csiphy0 > + - const: csiphy0_timer > + - const: csiphy1 > + - const: csiphy1_timer > + - const: csiphy2 > + - const: csiphy2_timer > + - const: csiphy3 > + - const: csiphy3_timer > + - const: csiphy_rx > + - const: gcc_axi_hf > + - const: gcc_axi_sf > + - const: icp_ahb > + - const: vfe0 > + - const: vfe0_fast_ahb > + - const: vfe1 > + - const: vfe1_fast_ahb > + - const: vfe_lite > + - const: vfe_lite_ahb > + - const: vfe_lite_cphy_rx > + - const: vfe_lite_csid > + > + interrupts: > + maxItems: 21 > + > + interrupt-names: > + items: > + - const: csid0 > + - const: csid1 > + - const: csid-lite0 > + - const: csid-lite1 > + - const: csid-lite2 > + - const: csid-lite3 > + - const: csid-lite4 > + - const: csiphy0 > + - const: csiphy1 > + - const: csiphy2 > + - const: csiphy3 > + - const: tpg0 > + - const: tpg1 > + - const: tpg2 > + - const: vfe0 > + - const: vfe1 > + - const: vfe-lite0 > + - const: vfe-lite1 > + - const: vfe-lite2 > + - const: vfe-lite3 > + - const: vfe-lite4 > + > + interconnects: > + maxItems: 3 > + > + interconnect-names: > + items: > + - const: ahb > + - const: hf_0 > + - const: sf_0 > + > + iommus: > + maxItems: 1 > + > + power-domains: > + items: > + - description: Titan GDSC - Titan ISP Block, Global Distributed Switch Controller. > + > + power-domain-names: > + items: > + - const: top > + > + ports: > + $ref: /schemas/graph.yaml#/properties/ports > + > + description: > + CSI input ports. > + > + patternProperties: > + "^port@[0-3]+$": > + $ref: /schemas/graph.yaml#/$defs/port-base > + unevaluatedProperties: false > + description: > + Input port for receiving CSI data on CSIPHY 0-3. > + > + properties: > + endpoint: > + $ref: video-interfaces.yaml# > + unevaluatedProperties: false > + > + properties: > + data-lanes: > + minItems: 1 > + maxItems: 4 > + > + required: > + - data-lanes > + > +required: > + - compatible > + - reg > + - reg-names > + - clocks > + - clock-names > + - interrupts > + - interrupt-names > + - interconnects > + - interconnect-names > + - iommus > + - power-domains > + - power-domain-names ports should be required > + > +additionalProperties: false > + > +examples: > + - | > + #include <dt-bindings/clock/qcom,sa8775p-camcc.h> > + #include <dt-bindings/clock/qcom,sa8775p-gcc.h> > + #include <dt-bindings/interconnect/qcom,sa8775p-rpmh.h> > + #include <dt-bindings/interconnect/qcom,icc.h> > + #include <dt-bindings/interrupt-controller/arm-gic.h> > + #include <dt-bindings/power/qcom-rpmpd.h> > + > + soc { > + #address-cells = <2>; > + #size-cells = <2>; > + > + isp@ac7a000 { > + compatible = "qcom,sa8775p-camss"; > + > + reg = <0x0 0xac7a000 0x0 0x0f01>, > + <0x0 0xac7c000 0x0 0x0f01>, > + <0x0 0xac84000 0x0 0x0f01>, > + <0x0 0xac88000 0x0 0x0f01>, > + <0x0 0xac8c000 0x0 0x0f01>, > + <0x0 0xac90000 0x0 0x0f01>, > + <0x0 0xac94000 0x0 0x0f01>, > + <0x0 0xac78000 0x0 0x1000>, > + <0x0 0xac9c000 0x0 0x2000>, > + <0x0 0xac9e000 0x0 0x2000>, > + <0x0 0xaca0000 0x0 0x2000>, > + <0x0 0xaca2000 0x0 0x2000>, > + <0x0 0xacac000 0x0 0x0400>, > + <0x0 0xacad000 0x0 0x0400>, > + <0x0 0xacae000 0x0 0x0400>, > + <0x0 0xac4d000 0x0 0xd000>, > + <0x0 0xac5a000 0x0 0xd000>, > + <0x0 0xac85000 0x0 0x0d00>, > + <0x0 0xac89000 0x0 0x0d00>, > + <0x0 0xac8d000 0x0 0x0d00>, > + <0x0 0xac91000 0x0 0x0d00>, > + <0x0 0xac95000 0x0 0x0d00>; > + reg-names = "csid0", > + "csid1", > + "csid_lite0", > + "csid_lite1", > + "csid_lite2", > + "csid_lite3", > + "csid_lite4", > + "csid_wrapper", > + "csiphy0", > + "csiphy1", > + "csiphy2", > + "csiphy3", > + "tpg0", > + "tpg1", > + "tpg2", > + "vfe0", > + "vfe1", > + "vfe_lite0", > + "vfe_lite1", > + "vfe_lite2", > + "vfe_lite3", > + "vfe_lite4"; > + > + clocks = <&camcc CAM_CC_CAMNOC_AXI_CLK>, > + <&camcc CAM_CC_CORE_AHB_CLK>, > + <&camcc CAM_CC_CPAS_AHB_CLK>, > + <&camcc CAM_CC_CPAS_FAST_AHB_CLK>, > + <&camcc CAM_CC_CPAS_IFE_LITE_CLK>, > + <&camcc CAM_CC_CPAS_IFE_0_CLK>, > + <&camcc CAM_CC_CPAS_IFE_1_CLK>, > + <&camcc CAM_CC_CSID_CLK>, > + <&camcc CAM_CC_CSIPHY0_CLK>, > + <&camcc CAM_CC_CSI0PHYTIMER_CLK>, > + <&camcc CAM_CC_CSIPHY1_CLK>, > + <&camcc CAM_CC_CSI1PHYTIMER_CLK>, > + <&camcc CAM_CC_CSIPHY2_CLK>, > + <&camcc CAM_CC_CSI2PHYTIMER_CLK>, > + <&camcc CAM_CC_CSIPHY3_CLK>, > + <&camcc CAM_CC_CSI3PHYTIMER_CLK>, > + <&camcc CAM_CC_CSID_CSIPHY_RX_CLK>, > + <&gcc GCC_CAMERA_HF_AXI_CLK>, > + <&gcc GCC_CAMERA_SF_AXI_CLK>, > + <&camcc CAM_CC_ICP_AHB_CLK>, > + <&camcc CAM_CC_IFE_0_CLK>, > + <&camcc CAM_CC_IFE_0_FAST_AHB_CLK>, > + <&camcc CAM_CC_IFE_1_CLK>, > + <&camcc CAM_CC_IFE_1_FAST_AHB_CLK>, > + <&camcc CAM_CC_IFE_LITE_CLK>, > + <&camcc CAM_CC_IFE_LITE_AHB_CLK>, > + <&camcc CAM_CC_IFE_LITE_CPHY_RX_CLK>, > + <&camcc CAM_CC_IFE_LITE_CSID_CLK>; > + clock-names = "camnoc_axi", > + "core_ahb", > + "cpas_ahb", > + "cpas_fast_ahb_clk", > + "cpas_ife_lite", > + "cpas_vfe0", > + "cpas_vfe1", > + "csid", > + "csiphy0", > + "csiphy0_timer", > + "csiphy1", > + "csiphy1_timer", > + "csiphy2", > + "csiphy2_timer", > + "csiphy3", > + "csiphy3_timer", > + "csiphy_rx", > + "gcc_axi_hf", > + "gcc_axi_sf", > + "icp_ahb", > + "vfe0", > + "vfe0_fast_ahb", > + "vfe1", > + "vfe1_fast_ahb", > + "vfe_lite", > + "vfe_lite_ahb", > + "vfe_lite_cphy_rx", > + "vfe_lite_csid"; > + > + interrupts = <GIC_SPI 565 IRQ_TYPE_EDGE_RISING>, > + <GIC_SPI 564 IRQ_TYPE_EDGE_RISING>, > + <GIC_SPI 468 IRQ_TYPE_EDGE_RISING>, > + <GIC_SPI 359 IRQ_TYPE_EDGE_RISING>, > + <GIC_SPI 759 IRQ_TYPE_EDGE_RISING>, > + <GIC_SPI 758 IRQ_TYPE_EDGE_RISING>, > + <GIC_SPI 604 IRQ_TYPE_EDGE_RISING>, > + <GIC_SPI 477 IRQ_TYPE_EDGE_RISING>, > + <GIC_SPI 478 IRQ_TYPE_EDGE_RISING>, > + <GIC_SPI 479 IRQ_TYPE_EDGE_RISING>, > + <GIC_SPI 448 IRQ_TYPE_EDGE_RISING>, > + <GIC_SPI 545 IRQ_TYPE_EDGE_RISING>, > + <GIC_SPI 546 IRQ_TYPE_EDGE_RISING>, > + <GIC_SPI 547 IRQ_TYPE_EDGE_RISING>, > + <GIC_SPI 465 IRQ_TYPE_EDGE_RISING>, > + <GIC_SPI 467 IRQ_TYPE_EDGE_RISING>, > + <GIC_SPI 469 IRQ_TYPE_EDGE_RISING>, > + <GIC_SPI 360 IRQ_TYPE_EDGE_RISING>, > + <GIC_SPI 761 IRQ_TYPE_EDGE_RISING>, > + <GIC_SPI 760 IRQ_TYPE_EDGE_RISING>, > + <GIC_SPI 605 IRQ_TYPE_EDGE_RISING>; > + interrupt-names = "csid0", > + "csid1", > + "csid-lite0", > + "csid-lite1", > + "csid-lite2", > + "csid-lite3", > + "csid-lite4", > + "csiphy0", > + "csiphy1", > + "csiphy2", > + "csiphy3", > + "tpg0", > + "tpg1", > + "tpg2", > + "vfe0", > + "vfe1", > + "vfe-lite0", > + "vfe-lite1", > + "vfe-lite2", > + "vfe-lite3", > + "vfe-lite4"; > + > + interconnects = <&gem_noc MASTER_APPSS_PROC QCOM_ICC_TAG_ACTIVE_ONLY > + &config_noc SLAVE_CAMERA_CFG QCOM_ICC_TAG_ACTIVE_ONLY>, > + <&mmss_noc MASTER_CAMNOC_HF QCOM_ICC_TAG_ALWAYS > + &mc_virt SLAVE_EBI1 QCOM_ICC_TAG_ALWAYS>, > + <&mmss_noc MASTER_CAMNOC_SF QCOM_ICC_TAG_ACTIVE_ONLY > + &mc_virt SLAVE_EBI1 QCOM_ICC_TAG_ACTIVE_ONLY>; > + interconnect-names = "ahb", > + "hf_0", > + "sf_0"; > + > + iommus = <&apps_smmu 0x3400 0x20>; > + > + power-domains = <&camcc CAM_CC_TITAN_TOP_GDSC>; > + power-domain-names = "top"; > + > + ports { > + #address-cells = <1>; > + #size-cells = <0>; > + }; > + }; > + }; ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v1 1/2] media: dt-bindings: Add qcom,sa8775p-camss 2025-02-11 10:08 ` Bryan O'Donoghue @ 2025-02-12 7:19 ` Vikram Sharma 0 siblings, 0 replies; 10+ messages in thread From: Vikram Sharma @ 2025-02-12 7:19 UTC (permalink / raw) To: Bryan O'Donoghue, rfoss, todor.too, mchehab, robh, krzk+dt, conor+dt, andersson, konradybcio, hverkuil-cisco, cros-qcom-dts-watchers, catalin.marinas, will Cc: linux-arm-kernel, linux-media, linux-arm-msm, devicetree, linux-kernel On 2/11/2025 3:38 PM, Bryan O'Donoghue wrote: > On 10/02/2025 15:56, Vikram Sharma wrote: >> Add bindings for qcom,sa8775p-camss to support the camera subsystem >> on SA8775P platform. >> >> Signed-off-by: Vikram Sharma <quic_vikramsa@quicinc.com> >> --- >> .../bindings/media/qcom,sa8775p-camss.yaml | 351 ++++++++++++++++++ >> 1 file changed, 351 insertions(+) >> create mode 100644 >> Documentation/devicetree/bindings/media/qcom,sa8775p-camss.yaml >> >> diff --git >> a/Documentation/devicetree/bindings/media/qcom,sa8775p-camss.yaml >> b/Documentation/devicetree/bindings/media/qcom,sa8775p-camss.yaml >> new file mode 100644 >> index 000000000000..083e1193c474 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/media/qcom,sa8775p-camss.yaml >> @@ -0,0 +1,351 @@ >> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/media/qcom,sa8775p-camss.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: Qualcomm SA8775P CAMSS ISP >> + >> +maintainers: >> + - Vikram Sharma <quic_vikramsa@quicinc.com> >> + >> +description: >> + The CAMSS IP is a CSI decoder and ISP present on Qualcomm platforms. >> + >> +properties: >> + compatible: >> + const: qcom,sa8775p-camss >> + >> + reg: >> + maxItems: 22 >> + >> + reg-names: >> + items: >> + - const: csid0 >> + - const: csid1 >> + - const: csid_lite0 >> + - const: csid_lite1 >> + - const: csid_lite2 >> + - const: csid_lite3 >> + - const: csid_lite4 >> + - const: csid_wrapper > > csid_wrapper should come first > > https://git.codelinaro.org/bryan.odonoghue/kernel/-/blob/x1e80100-6.13-inspiron14p/Documentation/devicetree/bindings/media/qcom,x1e80100-camss.yaml?ref_type=heads > Hi Bryan, Thanks for your comments. Moving csid_wrapper on top will break the alphanumeric order. Is it acceptable? > >> + - const: csiphy0 >> + - const: csiphy1 >> + - const: csiphy2 >> + - const: csiphy3 >> + - const: tpg0 >> + - const: tpg1 >> + - const: tpg2 >> + - const: vfe0 >> + - const: vfe1 >> + - const: vfe_lite0 >> + - const: vfe_lite1 >> + - const: vfe_lite2 >> + - const: vfe_lite3 >> + - const: vfe_lite4 >> + >> + clocks: >> + maxItems: 28 >> + >> + clock-names: >> + items: >> + - const: camnoc_axi >> + - const: core_ahb >> + - const: cpas_ahb >> + - const: cpas_fast_ahb_clk >> + - const: cpas_ife_lite >> + - const: cpas_vfe0 >> + - const: cpas_vfe1 >> + - const: csid >> + - const: csiphy0 >> + - const: csiphy0_timer >> + - const: csiphy1 >> + - const: csiphy1_timer >> + - const: csiphy2 >> + - const: csiphy2_timer >> + - const: csiphy3 >> + - const: csiphy3_timer >> + - const: csiphy_rx >> + - const: gcc_axi_hf >> + - const: gcc_axi_sf >> + - const: icp_ahb >> + - const: vfe0 >> + - const: vfe0_fast_ahb >> + - const: vfe1 >> + - const: vfe1_fast_ahb >> + - const: vfe_lite >> + - const: vfe_lite_ahb >> + - const: vfe_lite_cphy_rx >> + - const: vfe_lite_csid >> + >> + interrupts: >> + maxItems: 21 >> + >> + interrupt-names: >> + items: >> + - const: csid0 >> + - const: csid1 >> + - const: csid-lite0 >> + - const: csid-lite1 >> + - const: csid-lite2 >> + - const: csid-lite3 >> + - const: csid-lite4 >> + - const: csiphy0 >> + - const: csiphy1 >> + - const: csiphy2 >> + - const: csiphy3 >> + - const: tpg0 >> + - const: tpg1 >> + - const: tpg2 >> + - const: vfe0 >> + - const: vfe1 >> + - const: vfe-lite0 >> + - const: vfe-lite1 >> + - const: vfe-lite2 >> + - const: vfe-lite3 >> + - const: vfe-lite4 >> + >> + interconnects: >> + maxItems: 3 >> + >> + interconnect-names: >> + items: >> + - const: ahb >> + - const: hf_0 >> + - const: sf_0 >> + >> + iommus: >> + maxItems: 1 >> + >> + power-domains: >> + items: >> + - description: Titan GDSC - Titan ISP Block, Global >> Distributed Switch Controller. >> + >> + power-domain-names: >> + items: >> + - const: top >> + >> + ports: >> + $ref: /schemas/graph.yaml#/properties/ports >> + >> + description: >> + CSI input ports. >> + >> + patternProperties: >> + "^port@[0-3]+$": >> + $ref: /schemas/graph.yaml#/$defs/port-base >> + unevaluatedProperties: false >> + description: >> + Input port for receiving CSI data on CSIPHY 0-3. >> + >> + properties: >> + endpoint: >> + $ref: video-interfaces.yaml# >> + unevaluatedProperties: false >> + >> + properties: >> + data-lanes: >> + minItems: 1 >> + maxItems: 4 >> + >> + required: >> + - data-lanes >> + >> +required: >> + - compatible >> + - reg >> + - reg-names >> + - clocks >> + - clock-names >> + - interrupts >> + - interrupt-names >> + - interconnects >> + - interconnect-names >> + - iommus >> + - power-domains >> + - power-domain-names > > ports should be required ACK. > >> + >> +additionalProperties: false >> + >> +examples: >> + - | >> + #include <dt-bindings/clock/qcom,sa8775p-camcc.h> >> + #include <dt-bindings/clock/qcom,sa8775p-gcc.h> >> + #include <dt-bindings/interconnect/qcom,sa8775p-rpmh.h> >> + #include <dt-bindings/interconnect/qcom,icc.h> >> + #include <dt-bindings/interrupt-controller/arm-gic.h> >> + #include <dt-bindings/power/qcom-rpmpd.h> >> + >> + soc { >> + #address-cells = <2>; >> + #size-cells = <2>; >> + >> + isp@ac7a000 { >> + compatible = "qcom,sa8775p-camss"; >> + >> + reg = <0x0 0xac7a000 0x0 0x0f01>, >> + <0x0 0xac7c000 0x0 0x0f01>, >> + <0x0 0xac84000 0x0 0x0f01>, >> + <0x0 0xac88000 0x0 0x0f01>, >> + <0x0 0xac8c000 0x0 0x0f01>, >> + <0x0 0xac90000 0x0 0x0f01>, >> + <0x0 0xac94000 0x0 0x0f01>, >> + <0x0 0xac78000 0x0 0x1000>, >> + <0x0 0xac9c000 0x0 0x2000>, >> + <0x0 0xac9e000 0x0 0x2000>, >> + <0x0 0xaca0000 0x0 0x2000>, >> + <0x0 0xaca2000 0x0 0x2000>, >> + <0x0 0xacac000 0x0 0x0400>, >> + <0x0 0xacad000 0x0 0x0400>, >> + <0x0 0xacae000 0x0 0x0400>, >> + <0x0 0xac4d000 0x0 0xd000>, >> + <0x0 0xac5a000 0x0 0xd000>, >> + <0x0 0xac85000 0x0 0x0d00>, >> + <0x0 0xac89000 0x0 0x0d00>, >> + <0x0 0xac8d000 0x0 0x0d00>, >> + <0x0 0xac91000 0x0 0x0d00>, >> + <0x0 0xac95000 0x0 0x0d00>; >> + reg-names = "csid0", >> + "csid1", >> + "csid_lite0", >> + "csid_lite1", >> + "csid_lite2", >> + "csid_lite3", >> + "csid_lite4", >> + "csid_wrapper", >> + "csiphy0", >> + "csiphy1", >> + "csiphy2", >> + "csiphy3", >> + "tpg0", >> + "tpg1", >> + "tpg2", >> + "vfe0", >> + "vfe1", >> + "vfe_lite0", >> + "vfe_lite1", >> + "vfe_lite2", >> + "vfe_lite3", >> + "vfe_lite4"; >> + >> + clocks = <&camcc CAM_CC_CAMNOC_AXI_CLK>, >> + <&camcc CAM_CC_CORE_AHB_CLK>, >> + <&camcc CAM_CC_CPAS_AHB_CLK>, >> + <&camcc CAM_CC_CPAS_FAST_AHB_CLK>, >> + <&camcc CAM_CC_CPAS_IFE_LITE_CLK>, >> + <&camcc CAM_CC_CPAS_IFE_0_CLK>, >> + <&camcc CAM_CC_CPAS_IFE_1_CLK>, >> + <&camcc CAM_CC_CSID_CLK>, >> + <&camcc CAM_CC_CSIPHY0_CLK>, >> + <&camcc CAM_CC_CSI0PHYTIMER_CLK>, >> + <&camcc CAM_CC_CSIPHY1_CLK>, >> + <&camcc CAM_CC_CSI1PHYTIMER_CLK>, >> + <&camcc CAM_CC_CSIPHY2_CLK>, >> + <&camcc CAM_CC_CSI2PHYTIMER_CLK>, >> + <&camcc CAM_CC_CSIPHY3_CLK>, >> + <&camcc CAM_CC_CSI3PHYTIMER_CLK>, >> + <&camcc CAM_CC_CSID_CSIPHY_RX_CLK>, >> + <&gcc GCC_CAMERA_HF_AXI_CLK>, >> + <&gcc GCC_CAMERA_SF_AXI_CLK>, >> + <&camcc CAM_CC_ICP_AHB_CLK>, >> + <&camcc CAM_CC_IFE_0_CLK>, >> + <&camcc CAM_CC_IFE_0_FAST_AHB_CLK>, >> + <&camcc CAM_CC_IFE_1_CLK>, >> + <&camcc CAM_CC_IFE_1_FAST_AHB_CLK>, >> + <&camcc CAM_CC_IFE_LITE_CLK>, >> + <&camcc CAM_CC_IFE_LITE_AHB_CLK>, >> + <&camcc CAM_CC_IFE_LITE_CPHY_RX_CLK>, >> + <&camcc CAM_CC_IFE_LITE_CSID_CLK>; >> + clock-names = "camnoc_axi", >> + "core_ahb", >> + "cpas_ahb", >> + "cpas_fast_ahb_clk", >> + "cpas_ife_lite", >> + "cpas_vfe0", >> + "cpas_vfe1", >> + "csid", >> + "csiphy0", >> + "csiphy0_timer", >> + "csiphy1", >> + "csiphy1_timer", >> + "csiphy2", >> + "csiphy2_timer", >> + "csiphy3", >> + "csiphy3_timer", >> + "csiphy_rx", >> + "gcc_axi_hf", >> + "gcc_axi_sf", >> + "icp_ahb", >> + "vfe0", >> + "vfe0_fast_ahb", >> + "vfe1", >> + "vfe1_fast_ahb", >> + "vfe_lite", >> + "vfe_lite_ahb", >> + "vfe_lite_cphy_rx", >> + "vfe_lite_csid"; >> + >> + interrupts = <GIC_SPI 565 IRQ_TYPE_EDGE_RISING>, >> + <GIC_SPI 564 IRQ_TYPE_EDGE_RISING>, >> + <GIC_SPI 468 IRQ_TYPE_EDGE_RISING>, >> + <GIC_SPI 359 IRQ_TYPE_EDGE_RISING>, >> + <GIC_SPI 759 IRQ_TYPE_EDGE_RISING>, >> + <GIC_SPI 758 IRQ_TYPE_EDGE_RISING>, >> + <GIC_SPI 604 IRQ_TYPE_EDGE_RISING>, >> + <GIC_SPI 477 IRQ_TYPE_EDGE_RISING>, >> + <GIC_SPI 478 IRQ_TYPE_EDGE_RISING>, >> + <GIC_SPI 479 IRQ_TYPE_EDGE_RISING>, >> + <GIC_SPI 448 IRQ_TYPE_EDGE_RISING>, >> + <GIC_SPI 545 IRQ_TYPE_EDGE_RISING>, >> + <GIC_SPI 546 IRQ_TYPE_EDGE_RISING>, >> + <GIC_SPI 547 IRQ_TYPE_EDGE_RISING>, >> + <GIC_SPI 465 IRQ_TYPE_EDGE_RISING>, >> + <GIC_SPI 467 IRQ_TYPE_EDGE_RISING>, >> + <GIC_SPI 469 IRQ_TYPE_EDGE_RISING>, >> + <GIC_SPI 360 IRQ_TYPE_EDGE_RISING>, >> + <GIC_SPI 761 IRQ_TYPE_EDGE_RISING>, >> + <GIC_SPI 760 IRQ_TYPE_EDGE_RISING>, >> + <GIC_SPI 605 IRQ_TYPE_EDGE_RISING>; >> + interrupt-names = "csid0", >> + "csid1", >> + "csid-lite0", >> + "csid-lite1", >> + "csid-lite2", >> + "csid-lite3", >> + "csid-lite4", >> + "csiphy0", >> + "csiphy1", >> + "csiphy2", >> + "csiphy3", >> + "tpg0", >> + "tpg1", >> + "tpg2", >> + "vfe0", >> + "vfe1", >> + "vfe-lite0", >> + "vfe-lite1", >> + "vfe-lite2", >> + "vfe-lite3", >> + "vfe-lite4"; >> + >> + interconnects = <&gem_noc MASTER_APPSS_PROC >> QCOM_ICC_TAG_ACTIVE_ONLY >> + &config_noc SLAVE_CAMERA_CFG >> QCOM_ICC_TAG_ACTIVE_ONLY>, >> + <&mmss_noc MASTER_CAMNOC_HF >> QCOM_ICC_TAG_ALWAYS >> + &mc_virt SLAVE_EBI1 QCOM_ICC_TAG_ALWAYS>, >> + <&mmss_noc MASTER_CAMNOC_SF >> QCOM_ICC_TAG_ACTIVE_ONLY >> + &mc_virt SLAVE_EBI1 >> QCOM_ICC_TAG_ACTIVE_ONLY>; >> + interconnect-names = "ahb", >> + "hf_0", >> + "sf_0"; >> + >> + iommus = <&apps_smmu 0x3400 0x20>; >> + >> + power-domains = <&camcc CAM_CC_TITAN_TOP_GDSC>; >> + power-domain-names = "top"; >> + >> + ports { >> + #address-cells = <1>; >> + #size-cells = <0>; >> + }; >> + }; >> + }; > ^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH v1 2/2] arm64: dts: qcom: sa8775p: Add support for camss 2025-02-10 15:56 [PATCH v1 0/2] arm64: dts: qcom: sa8775p: Add sa8775p camss support Vikram Sharma 2025-02-10 15:56 ` [PATCH v1 1/2] media: dt-bindings: Add qcom,sa8775p-camss Vikram Sharma @ 2025-02-10 15:56 ` Vikram Sharma 2025-04-14 13:44 ` Konrad Dybcio 2025-04-14 13:48 ` Konrad Dybcio 1 sibling, 2 replies; 10+ messages in thread From: Vikram Sharma @ 2025-02-10 15:56 UTC (permalink / raw) To: rfoss, todor.too, bryan.odonoghue, mchehab, robh, krzk+dt, conor+dt, andersson, konradybcio, hverkuil-cisco, cros-qcom-dts-watchers, catalin.marinas, will Cc: linux-arm-kernel, quic_vikramsa, linux-media, linux-arm-msm, devicetree, linux-kernel, Suresh Vankadara Add changes to support the camera subsystem on the SA8775P. Co-developed-by: Suresh Vankadara <quic_svankada@quicinc.com> Signed-off-by: Suresh Vankadara <quic_svankada@quicinc.com> Signed-off-by: Vikram Sharma <quic_vikramsa@quicinc.com> --- arch/arm64/boot/dts/qcom/sa8775p.dtsi | 187 ++++++++++++++++++++++++++ 1 file changed, 187 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/sa8775p.dtsi b/arch/arm64/boot/dts/qcom/sa8775p.dtsi index 3394ae2d1300..83640fef05d2 100644 --- a/arch/arm64/boot/dts/qcom/sa8775p.dtsi +++ b/arch/arm64/boot/dts/qcom/sa8775p.dtsi @@ -7,6 +7,7 @@ #include <dt-bindings/interconnect/qcom,icc.h> #include <dt-bindings/interrupt-controller/arm-gic.h> #include <dt-bindings/clock/qcom,rpmh.h> +#include <dt-bindings/clock/qcom,sa8775p-camcc.h> #include <dt-bindings/clock/qcom,sa8775p-dispcc.h> #include <dt-bindings/clock/qcom,sa8775p-gcc.h> #include <dt-bindings/clock/qcom,sa8775p-gpucc.h> @@ -3796,6 +3797,192 @@ videocc: clock-controller@abf0000 { #power-domain-cells = <1>; }; + camss: isp@ac7a000 { + compatible = "qcom,sa8775p-camss"; + + reg = <0x0 0xac7a000 0x0 0x0f01>, + <0x0 0xac7c000 0x0 0x0f01>, + <0x0 0xac84000 0x0 0x0f01>, + <0x0 0xac88000 0x0 0x0f01>, + <0x0 0xac8c000 0x0 0x0f01>, + <0x0 0xac90000 0x0 0x0f01>, + <0x0 0xac94000 0x0 0x0f01>, + <0x0 0xac78000 0x0 0x1000>, + <0x0 0xac9c000 0x0 0x2000>, + <0x0 0xac9e000 0x0 0x2000>, + <0x0 0xaca0000 0x0 0x2000>, + <0x0 0xaca2000 0x0 0x2000>, + <0x0 0xacac000 0x0 0x0400>, + <0x0 0xacad000 0x0 0x0400>, + <0x0 0xacae000 0x0 0x0400>, + <0x0 0xac4d000 0x0 0xd000>, + <0x0 0xac5a000 0x0 0xd000>, + <0x0 0xac85000 0x0 0x0d00>, + <0x0 0xac89000 0x0 0x0d00>, + <0x0 0xac8d000 0x0 0x0d00>, + <0x0 0xac91000 0x0 0x0d00>, + <0x0 0xac95000 0x0 0x0d00>; + reg-names = "csid0", + "csid1", + "csid_lite0", + "csid_lite1", + "csid_lite2", + "csid_lite3", + "csid_lite4", + "csid_wrapper", + "csiphy0", + "csiphy1", + "csiphy2", + "csiphy3", + "tpg0", + "tpg1", + "tpg2", + "vfe0", + "vfe1", + "vfe_lite0", + "vfe_lite1", + "vfe_lite2", + "vfe_lite3", + "vfe_lite4"; + + clocks = <&camcc CAM_CC_CAMNOC_AXI_CLK>, + <&camcc CAM_CC_CORE_AHB_CLK>, + <&camcc CAM_CC_CPAS_AHB_CLK>, + <&camcc CAM_CC_CPAS_FAST_AHB_CLK>, + <&camcc CAM_CC_CPAS_IFE_LITE_CLK>, + <&camcc CAM_CC_CPAS_IFE_0_CLK>, + <&camcc CAM_CC_CPAS_IFE_1_CLK>, + <&camcc CAM_CC_CSID_CLK>, + <&camcc CAM_CC_CSIPHY0_CLK>, + <&camcc CAM_CC_CSI0PHYTIMER_CLK>, + <&camcc CAM_CC_CSIPHY1_CLK>, + <&camcc CAM_CC_CSI1PHYTIMER_CLK>, + <&camcc CAM_CC_CSIPHY2_CLK>, + <&camcc CAM_CC_CSI2PHYTIMER_CLK>, + <&camcc CAM_CC_CSIPHY3_CLK>, + <&camcc CAM_CC_CSI3PHYTIMER_CLK>, + <&camcc CAM_CC_CSID_CSIPHY_RX_CLK>, + <&gcc GCC_CAMERA_HF_AXI_CLK>, + <&gcc GCC_CAMERA_SF_AXI_CLK>, + <&camcc CAM_CC_ICP_AHB_CLK>, + <&camcc CAM_CC_IFE_0_CLK>, + <&camcc CAM_CC_IFE_0_FAST_AHB_CLK>, + <&camcc CAM_CC_IFE_1_CLK>, + <&camcc CAM_CC_IFE_1_FAST_AHB_CLK>, + <&camcc CAM_CC_IFE_LITE_CLK>, + <&camcc CAM_CC_IFE_LITE_AHB_CLK>, + <&camcc CAM_CC_IFE_LITE_CPHY_RX_CLK>, + <&camcc CAM_CC_IFE_LITE_CSID_CLK>; + clock-names = "camnoc_axi", + "core_ahb", + "cpas_ahb", + "cpas_fast_ahb_clk", + "cpas_ife_lite", + "cpas_vfe0", + "cpas_vfe1", + "csid", + "csiphy0", + "csiphy0_timer", + "csiphy1", + "csiphy1_timer", + "csiphy2", + "csiphy2_timer", + "csiphy3", + "csiphy3_timer", + "csiphy_rx", + "gcc_axi_hf", + "gcc_axi_sf", + "icp_ahb", + "vfe0", + "vfe0_fast_ahb", + "vfe1", + "vfe1_fast_ahb", + "vfe_lite", + "vfe_lite_ahb", + "vfe_lite_cphy_rx", + "vfe_lite_csid"; + + interrupts = <GIC_SPI 565 IRQ_TYPE_EDGE_RISING>, + <GIC_SPI 564 IRQ_TYPE_EDGE_RISING>, + <GIC_SPI 468 IRQ_TYPE_EDGE_RISING>, + <GIC_SPI 359 IRQ_TYPE_EDGE_RISING>, + <GIC_SPI 759 IRQ_TYPE_EDGE_RISING>, + <GIC_SPI 758 IRQ_TYPE_EDGE_RISING>, + <GIC_SPI 604 IRQ_TYPE_EDGE_RISING>, + <GIC_SPI 477 IRQ_TYPE_EDGE_RISING>, + <GIC_SPI 478 IRQ_TYPE_EDGE_RISING>, + <GIC_SPI 479 IRQ_TYPE_EDGE_RISING>, + <GIC_SPI 448 IRQ_TYPE_EDGE_RISING>, + <GIC_SPI 545 IRQ_TYPE_EDGE_RISING>, + <GIC_SPI 546 IRQ_TYPE_EDGE_RISING>, + <GIC_SPI 547 IRQ_TYPE_EDGE_RISING>, + <GIC_SPI 465 IRQ_TYPE_EDGE_RISING>, + <GIC_SPI 467 IRQ_TYPE_EDGE_RISING>, + <GIC_SPI 469 IRQ_TYPE_EDGE_RISING>, + <GIC_SPI 360 IRQ_TYPE_EDGE_RISING>, + <GIC_SPI 761 IRQ_TYPE_EDGE_RISING>, + <GIC_SPI 760 IRQ_TYPE_EDGE_RISING>, + <GIC_SPI 605 IRQ_TYPE_EDGE_RISING>; + interrupt-names = "csid0", + "csid1", + "csid-lite0", + "csid-lite1", + "csid-lite2", + "csid-lite3", + "csid-lite4", + "csiphy0", + "csiphy1", + "csiphy2", + "csiphy3", + "tpg0", + "tpg1", + "tpg2", + "vfe0", + "vfe1", + "vfe-lite0", + "vfe-lite1", + "vfe-lite2", + "vfe-lite3", + "vfe-lite4"; + + interconnects = <&gem_noc MASTER_APPSS_PROC QCOM_ICC_TAG_ACTIVE_ONLY + &config_noc SLAVE_CAMERA_CFG QCOM_ICC_TAG_ACTIVE_ONLY>, + <&mmss_noc MASTER_CAMNOC_HF QCOM_ICC_TAG_ALWAYS + &mc_virt SLAVE_EBI1 QCOM_ICC_TAG_ALWAYS>, + <&mmss_noc MASTER_CAMNOC_SF QCOM_ICC_TAG_ACTIVE_ONLY + &mc_virt SLAVE_EBI1 QCOM_ICC_TAG_ACTIVE_ONLY>; + interconnect-names = "ahb", + "hf_0", + "sf_0"; + + iommus = <&apps_smmu 0x3400 0x20>; + + power-domains = <&camcc CAM_CC_TITAN_TOP_GDSC>; + power-domain-names = "top"; + + status = "disabled"; + + ports { + #address-cells = <1>; + #size-cells = <0>; + port@0 { + reg = <0>; + }; + + port@1 { + reg = <1>; + }; + + port@2 { + reg = <2>; + }; + + port@3 { + reg = <3>; + }; + }; + }; + camcc: clock-controller@ade0000 { compatible = "qcom,sa8775p-camcc"; reg = <0x0 0x0ade0000 0x0 0x20000>; -- 2.25.1 ^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH v1 2/2] arm64: dts: qcom: sa8775p: Add support for camss 2025-02-10 15:56 ` [PATCH v1 2/2] arm64: dts: qcom: sa8775p: Add support for camss Vikram Sharma @ 2025-04-14 13:44 ` Konrad Dybcio [not found] ` <ee4d08b0-f291-4018-bda3-96dfbc7a07ff@quicinc.com> 2025-04-14 13:48 ` Konrad Dybcio 1 sibling, 1 reply; 10+ messages in thread From: Konrad Dybcio @ 2025-04-14 13:44 UTC (permalink / raw) To: Vikram Sharma, rfoss, todor.too, bryan.odonoghue, mchehab, robh, krzk+dt, conor+dt, andersson, konradybcio, hverkuil-cisco, cros-qcom-dts-watchers, catalin.marinas, will Cc: linux-arm-kernel, linux-media, linux-arm-msm, devicetree, linux-kernel, Suresh Vankadara On 2/10/25 4:56 PM, Vikram Sharma wrote: > Add changes to support the camera subsystem on the SA8775P. > > Co-developed-by: Suresh Vankadara <quic_svankada@quicinc.com> > Signed-off-by: Suresh Vankadara <quic_svankada@quicinc.com> > Signed-off-by: Vikram Sharma <quic_vikramsa@quicinc.com> > --- > arch/arm64/boot/dts/qcom/sa8775p.dtsi | 187 ++++++++++++++++++++++++++ > 1 file changed, 187 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sa8775p.dtsi b/arch/arm64/boot/dts/qcom/sa8775p.dtsi > index 3394ae2d1300..83640fef05d2 100644 > --- a/arch/arm64/boot/dts/qcom/sa8775p.dtsi > +++ b/arch/arm64/boot/dts/qcom/sa8775p.dtsi > @@ -7,6 +7,7 @@ > #include <dt-bindings/interconnect/qcom,icc.h> > #include <dt-bindings/interrupt-controller/arm-gic.h> > #include <dt-bindings/clock/qcom,rpmh.h> > +#include <dt-bindings/clock/qcom,sa8775p-camcc.h> > #include <dt-bindings/clock/qcom,sa8775p-dispcc.h> > #include <dt-bindings/clock/qcom,sa8775p-gcc.h> > #include <dt-bindings/clock/qcom,sa8775p-gpucc.h> > @@ -3796,6 +3797,192 @@ videocc: clock-controller@abf0000 { > #power-domain-cells = <1>; > }; > > + camss: isp@ac7a000 { > + compatible = "qcom,sa8775p-camss"; > + > + reg = <0x0 0xac7a000 0x0 0x0f01>, > + <0x0 0xac7c000 0x0 0x0f01>, > + <0x0 0xac84000 0x0 0x0f01>, > + <0x0 0xac88000 0x0 0x0f01>, > + <0x0 0xac8c000 0x0 0x0f01>, > + <0x0 0xac90000 0x0 0x0f01>, > + <0x0 0xac94000 0x0 0x0f01>, These I think should begin 0x1000 earlier and as a result be 0x1000 longer I also believe this is an off-by-one.. there's nothing past a certain register in there, but 0xf00 is what I believe makes more sense here [...] > + <&camcc CAM_CC_CSI3PHYTIMER_CLK>, > + <&camcc CAM_CC_CSID_CSIPHY_RX_CLK>, > + <&gcc GCC_CAMERA_HF_AXI_CLK>, > + <&gcc GCC_CAMERA_SF_AXI_CLK>, Please don't forcefully align these [...] > + interconnects = <&gem_noc MASTER_APPSS_PROC QCOM_ICC_TAG_ACTIVE_ONLY > + &config_noc SLAVE_CAMERA_CFG QCOM_ICC_TAG_ACTIVE_ONLY>, > + <&mmss_noc MASTER_CAMNOC_HF QCOM_ICC_TAG_ALWAYS > + &mc_virt SLAVE_EBI1 QCOM_ICC_TAG_ALWAYS>, > + <&mmss_noc MASTER_CAMNOC_SF QCOM_ICC_TAG_ACTIVE_ONLY > + &mc_virt SLAVE_EBI1 QCOM_ICC_TAG_ACTIVE_ONLY>; The last one should probably be always-on, given we're doing all voting on the APPS RSC as of right now otherwise looks reasonable Konrad ^ permalink raw reply [flat|nested] 10+ messages in thread
[parent not found: <ee4d08b0-f291-4018-bda3-96dfbc7a07ff@quicinc.com>]
* Re: [PATCH v1 2/2] arm64: dts: qcom: sa8775p: Add support for camss [not found] ` <ee4d08b0-f291-4018-bda3-96dfbc7a07ff@quicinc.com> @ 2025-04-16 16:09 ` Konrad Dybcio 0 siblings, 0 replies; 10+ messages in thread From: Konrad Dybcio @ 2025-04-16 16:09 UTC (permalink / raw) To: Vikram Sharma, Konrad Dybcio, rfoss, todor.too, bryan.odonoghue, mchehab, robh, krzk+dt, conor+dt, andersson, konradybcio, hverkuil-cisco, cros-qcom-dts-watchers, catalin.marinas, will Cc: linux-arm-kernel, linux-media, linux-arm-msm, devicetree, linux-kernel, Suresh Vankadara On 4/16/25 5:29 PM, Vikram Sharma wrote: > > On 4/14/2025 7:14 PM, Konrad Dybcio wrote: >> On 2/10/25 4:56 PM, Vikram Sharma wrote: >>> Add changes to support the camera subsystem on the SA8775P. >>> >>> Co-developed-by: Suresh Vankadara<quic_svankada@quicinc.com> >>> Signed-off-by: Suresh Vankadara<quic_svankada@quicinc.com> >>> Signed-off-by: Vikram Sharma<quic_vikramsa@quicinc.com> >>> --- >>> arch/arm64/boot/dts/qcom/sa8775p.dtsi | 187 ++++++++++++++++++++++++++ >>> 1 file changed, 187 insertions(+) >>> >>> diff --git a/arch/arm64/boot/dts/qcom/sa8775p.dtsi b/arch/arm64/boot/dts/qcom/sa8775p.dtsi >>> index 3394ae2d1300..83640fef05d2 100644 >>> --- a/arch/arm64/boot/dts/qcom/sa8775p.dtsi >>> +++ b/arch/arm64/boot/dts/qcom/sa8775p.dtsi >>> @@ -7,6 +7,7 @@ >>> #include <dt-bindings/interconnect/qcom,icc.h> >>> #include <dt-bindings/interrupt-controller/arm-gic.h> >>> #include <dt-bindings/clock/qcom,rpmh.h> >>> +#include <dt-bindings/clock/qcom,sa8775p-camcc.h> >>> #include <dt-bindings/clock/qcom,sa8775p-dispcc.h> >>> #include <dt-bindings/clock/qcom,sa8775p-gcc.h> >>> #include <dt-bindings/clock/qcom,sa8775p-gpucc.h> >>> @@ -3796,6 +3797,192 @@ videocc: clock-controller@abf0000 { >>> #power-domain-cells = <1>; >>> }; >>> + camss: isp@ac7a000 { >>> + compatible = "qcom,sa8775p-camss"; >>> + >>> + reg = <0x0 0xac7a000 0x0 0x0f01>, >>> + <0x0 0xac7c000 0x0 0x0f01>, >>> + <0x0 0xac84000 0x0 0x0f01>, >>> + <0x0 0xac88000 0x0 0x0f01>, >>> + <0x0 0xac8c000 0x0 0x0f01>, >>> + <0x0 0xac90000 0x0 0x0f01>, >>> + <0x0 0xac94000 0x0 0x0f01>, >> These I think should begin 0x1000 earlier and as a result be 0x1000 > Hi Konrad, > Thanks for your comments. > First 0x1000 bytes of CSID are for secure usecase. Actually CSID register address space starts from > 'TITAN_A_RT_1_CSID_WRAPPER_CLC_CSID0_HW_VERSION' which is 0xac7a000. Alright, thanks Konrad ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v1 2/2] arm64: dts: qcom: sa8775p: Add support for camss 2025-02-10 15:56 ` [PATCH v1 2/2] arm64: dts: qcom: sa8775p: Add support for camss Vikram Sharma 2025-04-14 13:44 ` Konrad Dybcio @ 2025-04-14 13:48 ` Konrad Dybcio 2025-04-18 7:28 ` Vikram Sharma 1 sibling, 1 reply; 10+ messages in thread From: Konrad Dybcio @ 2025-04-14 13:48 UTC (permalink / raw) To: Vikram Sharma, rfoss, todor.too, bryan.odonoghue, mchehab, robh, krzk+dt, conor+dt, andersson, konradybcio, hverkuil-cisco, cros-qcom-dts-watchers, catalin.marinas, will Cc: linux-arm-kernel, linux-media, linux-arm-msm, devicetree, linux-kernel, Suresh Vankadara On 2/10/25 4:56 PM, Vikram Sharma wrote: > Add changes to support the camera subsystem on the SA8775P. > > Co-developed-by: Suresh Vankadara <quic_svankada@quicinc.com> > Signed-off-by: Suresh Vankadara <quic_svankada@quicinc.com> > Signed-off-by: Vikram Sharma <quic_vikramsa@quicinc.com> > --- [...] > + interrupts = <GIC_SPI 565 IRQ_TYPE_EDGE_RISING>, > + <GIC_SPI 564 IRQ_TYPE_EDGE_RISING>, > + <GIC_SPI 468 IRQ_TYPE_EDGE_RISING>, > + <GIC_SPI 359 IRQ_TYPE_EDGE_RISING>, > + <GIC_SPI 759 IRQ_TYPE_EDGE_RISING>, 760> + <GIC_SPI 758 IRQ_TYPE_EDGE_RISING>, 759 > + <GIC_SPI 604 IRQ_TYPE_EDGE_RISING>, > + <GIC_SPI 477 IRQ_TYPE_EDGE_RISING>, > + <GIC_SPI 478 IRQ_TYPE_EDGE_RISING>, > + <GIC_SPI 479 IRQ_TYPE_EDGE_RISING>, > + <GIC_SPI 448 IRQ_TYPE_EDGE_RISING>, > + <GIC_SPI 545 IRQ_TYPE_EDGE_RISING>, > + <GIC_SPI 546 IRQ_TYPE_EDGE_RISING>, > + <GIC_SPI 547 IRQ_TYPE_EDGE_RISING>, > + <GIC_SPI 465 IRQ_TYPE_EDGE_RISING>, > + <GIC_SPI 467 IRQ_TYPE_EDGE_RISING>, > + <GIC_SPI 469 IRQ_TYPE_EDGE_RISING>, > + <GIC_SPI 360 IRQ_TYPE_EDGE_RISING>, > + <GIC_SPI 761 IRQ_TYPE_EDGE_RISING>, 762 > + <GIC_SPI 760 IRQ_TYPE_EDGE_RISING>, 761 Konrad ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v1 2/2] arm64: dts: qcom: sa8775p: Add support for camss 2025-04-14 13:48 ` Konrad Dybcio @ 2025-04-18 7:28 ` Vikram Sharma 2025-04-18 9:51 ` Konrad Dybcio 0 siblings, 1 reply; 10+ messages in thread From: Vikram Sharma @ 2025-04-18 7:28 UTC (permalink / raw) To: Konrad Dybcio, rfoss, todor.too, bryan.odonoghue, mchehab, robh, krzk+dt, conor+dt, andersson, konradybcio, hverkuil-cisco, cros-qcom-dts-watchers, catalin.marinas, will Cc: linux-arm-kernel, linux-media, linux-arm-msm, devicetree, linux-kernel, Suresh Vankadara On 4/14/2025 7:18 PM, Konrad Dybcio wrote: > On 2/10/25 4:56 PM, Vikram Sharma wrote: >> Add changes to support the camera subsystem on the SA8775P. >> >> Co-developed-by: Suresh Vankadara <quic_svankada@quicinc.com> >> Signed-off-by: Suresh Vankadara <quic_svankada@quicinc.com> >> Signed-off-by: Vikram Sharma <quic_vikramsa@quicinc.com> >> --- > [...] > >> + interrupts = <GIC_SPI 565 IRQ_TYPE_EDGE_RISING>, >> + <GIC_SPI 564 IRQ_TYPE_EDGE_RISING>, >> + <GIC_SPI 468 IRQ_TYPE_EDGE_RISING>, >> + <GIC_SPI 359 IRQ_TYPE_EDGE_RISING>, >> + <GIC_SPI 759 IRQ_TYPE_EDGE_RISING>, > 760> + <GIC_SPI 758 IRQ_TYPE_EDGE_RISING>, Hi Konrad, We cross checked internal documents to confirm IRQ number for csid_lite2/3 and vfe_lite2/3 Calculation for IRQ number is done with respect to vector number as irq_num = (vector - 32). csid_lite2 vector -> 791 csid_lite3 vector -> 790 vfe_lite2 vector -> 793 vfe_lite3 vector -> 792 thus irqs are as csid_lite2 -> 759 csid_lite3 -> 758 vfe_lite2 -> 761 vfe_lite3 -> 760 Please let me know if this looks fine to you? > > 759 > >> + <GIC_SPI 604 IRQ_TYPE_EDGE_RISING>, >> + <GIC_SPI 477 IRQ_TYPE_EDGE_RISING>, >> + <GIC_SPI 478 IRQ_TYPE_EDGE_RISING>, >> + <GIC_SPI 479 IRQ_TYPE_EDGE_RISING>, >> + <GIC_SPI 448 IRQ_TYPE_EDGE_RISING>, >> + <GIC_SPI 545 IRQ_TYPE_EDGE_RISING>, >> + <GIC_SPI 546 IRQ_TYPE_EDGE_RISING>, >> + <GIC_SPI 547 IRQ_TYPE_EDGE_RISING>, >> + <GIC_SPI 465 IRQ_TYPE_EDGE_RISING>, >> + <GIC_SPI 467 IRQ_TYPE_EDGE_RISING>, >> + <GIC_SPI 469 IRQ_TYPE_EDGE_RISING>, >> + <GIC_SPI 360 IRQ_TYPE_EDGE_RISING>, >> + <GIC_SPI 761 IRQ_TYPE_EDGE_RISING>, > 762 > >> + <GIC_SPI 760 IRQ_TYPE_EDGE_RISING>, > 761 > > Konrad Best Regards, Vikram ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v1 2/2] arm64: dts: qcom: sa8775p: Add support for camss 2025-04-18 7:28 ` Vikram Sharma @ 2025-04-18 9:51 ` Konrad Dybcio 0 siblings, 0 replies; 10+ messages in thread From: Konrad Dybcio @ 2025-04-18 9:51 UTC (permalink / raw) To: Vikram Sharma, Konrad Dybcio, rfoss, todor.too, bryan.odonoghue, mchehab, robh, krzk+dt, conor+dt, andersson, konradybcio, hverkuil-cisco, cros-qcom-dts-watchers, catalin.marinas, will Cc: linux-arm-kernel, linux-media, linux-arm-msm, devicetree, linux-kernel, Suresh Vankadara On 4/18/25 9:28 AM, Vikram Sharma wrote: > > On 4/14/2025 7:18 PM, Konrad Dybcio wrote: >> On 2/10/25 4:56 PM, Vikram Sharma wrote: >>> Add changes to support the camera subsystem on the SA8775P. >>> >>> Co-developed-by: Suresh Vankadara <quic_svankada@quicinc.com> >>> Signed-off-by: Suresh Vankadara <quic_svankada@quicinc.com> >>> Signed-off-by: Vikram Sharma <quic_vikramsa@quicinc.com> >>> --- >> [...] >> >>> + interrupts = <GIC_SPI 565 IRQ_TYPE_EDGE_RISING>, >>> + <GIC_SPI 564 IRQ_TYPE_EDGE_RISING>, >>> + <GIC_SPI 468 IRQ_TYPE_EDGE_RISING>, >>> + <GIC_SPI 359 IRQ_TYPE_EDGE_RISING>, >>> + <GIC_SPI 759 IRQ_TYPE_EDGE_RISING>, >> 760> + <GIC_SPI 758 IRQ_TYPE_EDGE_RISING>, > > Hi Konrad, > > We cross checked internal documents to confirm IRQ number for csid_lite2/3 and vfe_lite2/3 > Calculation for IRQ number is done with respect to vector number as > irq_num = (vector - 32). > csid_lite2 vector -> 791 > csid_lite3 vector -> 790 > vfe_lite2 vector -> 793 > vfe_lite3 vector -> 792 > > thus irqs are as > csid_lite2 -> 759 > csid_lite3 -> 758 > vfe_lite2 -> 761 > vfe_lite3 -> 760 > > Please let me know if this looks fine to you? We had a similar issue with qcs8300 - the reported vector id skipped a number at some point. In that case the SPI ports indices alongside them were advised to be used. Please check with the HW team, but I suppose this would be the case for this one too. Konrad ^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2025-04-18 9:51 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-02-10 15:56 [PATCH v1 0/2] arm64: dts: qcom: sa8775p: Add sa8775p camss support Vikram Sharma
2025-02-10 15:56 ` [PATCH v1 1/2] media: dt-bindings: Add qcom,sa8775p-camss Vikram Sharma
2025-02-11 10:08 ` Bryan O'Donoghue
2025-02-12 7:19 ` Vikram Sharma
2025-02-10 15:56 ` [PATCH v1 2/2] arm64: dts: qcom: sa8775p: Add support for camss Vikram Sharma
2025-04-14 13:44 ` Konrad Dybcio
[not found] ` <ee4d08b0-f291-4018-bda3-96dfbc7a07ff@quicinc.com>
2025-04-16 16:09 ` Konrad Dybcio
2025-04-14 13:48 ` Konrad Dybcio
2025-04-18 7:28 ` Vikram Sharma
2025-04-18 9:51 ` Konrad Dybcio
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox