From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Varadarajan Narayanan <quic_varada@quicinc.com>,
amitk@kernel.org, thara.gopinath@gmail.com, agross@kernel.org,
andersson@kernel.org, konrad.dybcio@linaro.org,
rafael@kernel.org, daniel.lezcano@linaro.org,
rui.zhang@intel.com, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, linux-pm@vger.kernel.org,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Cc: Praveenkumar I <quic_ipkumar@quicinc.com>
Subject: Re: [PATCH v1 1/4] dt-bindings: thermal: tsens: Add ipq9574 compatible
Date: Wed, 3 May 2023 08:34:45 +0200 [thread overview]
Message-ID: <6fbdd628-89f6-e34f-1b6e-b36e8fbd2346@linaro.org> (raw)
In-Reply-To: <cbf916e31b00e0e0599a3012a84a4740df89f4e0.1683027347.git.quic_varada@quicinc.com>
On 03/05/2023 06:45, Varadarajan Narayanan wrote:
> From: Praveenkumar I <quic_ipkumar@quicinc.com>
>
> Qualcomm IPQ9574 has tsens v2.3.1 block, which is similar to IPQ8074 tsens.
>
> Signed-off-by: Praveenkumar I <quic_ipkumar@quicinc.com>
> Signed-off-by: Varadarajan Narayanan <quic_varada@quicinc.com>
> ---
> Documentation/devicetree/bindings/thermal/qcom-tsens.yaml | 3 +++
> 1 file changed, 3 insertions(+)
>
I saw already v1, so this looks like v2, not v1. Please add changelog
describing what you changed here.
> diff --git a/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml b/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml
> index d1ec963..8e2208c 100644
> --- a/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml
> +++ b/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml
> @@ -66,6 +66,7 @@ properties:
> - description: v2 of TSENS with combined interrupt
> enum:
> - qcom,ipq8074-tsens
> + - qcom,ipq9574-tsens
This is a friendly reminder during the review process.
It seems my previous comments were not fully addressed. Maybe my
feedback got lost between the quotes, maybe you just forgot to apply it.
Please go back to the previous discussion and either implement all
requested changes or keep discussing them.
Thank you.
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-05-03 6:34 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-03 4:45 [PATCH v1 0/4] Enable IPQ9574 TSENS support Varadarajan Narayanan
2023-05-03 4:45 ` [PATCH v1 1/4] dt-bindings: thermal: tsens: Add ipq9574 compatible Varadarajan Narayanan
2023-05-03 6:34 ` Krzysztof Kozlowski [this message]
2023-05-03 7:00 ` Varadarajan Narayanan
2023-05-05 21:58 ` Rob Herring
2023-05-03 4:46 ` [PATCH v1 2/4] thermal/drivers/tsens: Add IPQ9574 support Varadarajan Narayanan
2023-05-03 6:34 ` Krzysztof Kozlowski
2023-05-03 4:46 ` [PATCH v1 3/4] arm64: dts: qcom: ipq9574: add tsens node Varadarajan Narayanan
2023-05-03 4:46 ` [PATCH v1 4/4] arm64: dts: qcom: ipq9574: add thermal zone nodes Varadarajan Narayanan
2023-05-03 7:44 ` Dmitry Baryshkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6fbdd628-89f6-e34f-1b6e-b36e8fbd2346@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=agross@kernel.org \
--cc=amitk@kernel.org \
--cc=andersson@kernel.org \
--cc=daniel.lezcano@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=quic_ipkumar@quicinc.com \
--cc=quic_varada@quicinc.com \
--cc=rafael@kernel.org \
--cc=robh+dt@kernel.org \
--cc=rui.zhang@intel.com \
--cc=thara.gopinath@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox