From: Krzysztof Kozlowski <krzk@kernel.org>
To: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>,
Rakesh Kota <rakesh.kota@oss.qualcomm.com>
Cc: Sebastian Reichel <sre@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>, Vinod Koul <vkoul@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
linux-pm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Subject: Re: [PATCH v3 1/2] dt-bindings: power: reset: qcom-pon: Add new compatible PMM8654AU
Date: Mon, 2 Mar 2026 11:28:10 +0100 [thread overview]
Message-ID: <7118ad44-5a56-4523-baff-9afa8030aff0@kernel.org> (raw)
In-Reply-To: <6a304d0d-61b1-422f-bb65-8f8055095c39@oss.qualcomm.com>
On 02/03/2026 11:20, Konrad Dybcio wrote:
> On 2/28/26 11:17 AM, Krzysztof Kozlowski wrote:
>> On Fri, Feb 27, 2026 at 06:02:28PM +0530, Rakesh Kota wrote:
>>> PMM8654AU is a different PMIC from PMM8650AU, even though both share
>>> the same PMIC subtype. Add PON compatible string for PMM8654AU PMIC
>>> variant.
>>>
>>> The PMM8654AU PON block is compatible with the PMK8350 PON
>>> implementation, but PMM8654AU also implements additional PON registers
>>
>> So does that mean that PMM8654AU has 2 address spaces and PMK8350 has
>> only one? At least it looks, so I expect fixing the last if:then: - you
>> need to drop contains from PMK8350 if clause and add new if:then: for
>> PMM8654AU.
>
> The delta between them is such that within the already-described reg
> ranges, there is some additional bits and/or registers (can't remember
> but it doesn't matter for this point)
>
> This doesn't impact the described size, as all QC PMIC peripherals are
> by design allocated 0x100-wide windows
I still expect that fixed.
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-03-02 10:28 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-27 12:32 [PATCH v3 0/2] monaco: Add PMM8654AU PON support Rakesh Kota
2026-02-27 12:32 ` [PATCH v3 1/2] dt-bindings: power: reset: qcom-pon: Add new compatible PMM8654AU Rakesh Kota
2026-02-28 10:17 ` Krzysztof Kozlowski
2026-03-02 10:20 ` Konrad Dybcio
2026-03-02 10:28 ` Krzysztof Kozlowski [this message]
2026-03-04 10:08 ` Konrad Dybcio
2026-03-04 10:11 ` Krzysztof Kozlowski
2026-03-10 12:20 ` Rakesh Kota
2026-02-27 12:32 ` [PATCH v3 2/2] arm64: dts: qcom: monaco-pmics: Add PON power key and reset inputs Rakesh Kota
2026-02-27 16:50 ` Konrad Dybcio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7118ad44-5a56-4523-baff-9afa8030aff0@kernel.org \
--to=krzk@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@oss.qualcomm.com \
--cc=konrad.dybcio@oss.qualcomm.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rakesh.kota@oss.qualcomm.com \
--cc=robh@kernel.org \
--cc=sre@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox