Re: [PATCH v3 1/2] dt-bindings: power: reset: qcom-pon: Add new compatible PMM8654AU

[Krzysztof Kozlowski <krzk@kernel.org>]

On 04/03/2026 11:08, Konrad Dybcio wrote:
> On 3/2/26 11:28 AM, Krzysztof Kozlowski wrote:
>> On 02/03/2026 11:20, Konrad Dybcio wrote:
>>> On 2/28/26 11:17 AM, Krzysztof Kozlowski wrote:
>>>> On Fri, Feb 27, 2026 at 06:02:28PM +0530, Rakesh Kota wrote:
>>>>> PMM8654AU is a different PMIC from PMM8650AU, even though both share
>>>>> the same PMIC subtype. Add PON compatible string for PMM8654AU PMIC
>>>>> variant.
>>>>>
>>>>> The PMM8654AU PON block is compatible with the PMK8350 PON
>>>>> implementation, but PMM8654AU also implements additional PON registers
>>>>
>>>> So does that mean that PMM8654AU has 2 address spaces and PMK8350 has
>>>> only one? At least it looks, so I expect fixing the last if:then: - you
>>>> need to drop contains from PMK8350 if clause and add new if:then: for
>>>> PMM8654AU.
>>>
>>> The delta between them is such that within the already-described reg
>>> ranges, there is some additional bits and/or registers (can't remember
>>> but it doesn't matter for this point)
>>>
>>> This doesn't impact the described size, as all QC PMIC peripherals are
>>> by design allocated 0x100-wide windows
>>
>> I still expect that fixed.
> 
> that = commit message?

No, what I wrote in my first reply what has to be fixed.

Best regards,
Krzysztof