[PATCH v3 0/2] monaco: Add PMM8654AU PON support

[PATCH v3 0/2] monaco: Add PMM8654AU PON support

[Rakesh Kota]

This patch series updates the PON power and reset dt-bindings and
device tree to add support for PON power and reset keys on the 
Monaco platform.

Signed-off-by: Rakesh Kota <rakesh.kota@oss.qualcomm.com>
---
Changes in v3:
 - Drop the dt-bindings of PMM8654AU qcom,pm8941-pwrkey as this
   patch was picked - https://lore.kernel.org/all/20260209-add_pwrkey_and_resin-v2-2-f944d87b9a93@oss.qualcomm.com
 - Update Commit message and disable the resin as suggested by Konrad Dybcio
 - Link to v2: https://lore.kernel.org/r/20260209-add_pwrkey_and_resin-v2-0-f944d87b9a93@oss.qualcomm.com 

Changes in v2:
 - Introduces PMM8654AU compatible strings as suggested by Konrad Dybcio.
 - Link to v1: https://lore.kernel.org/all/20260122-add_pwrkey_and_resin-v1-1-a9fe87537816@oss.qualcomm.com

---
Rakesh Kota (2):
      dt-bindings: power: reset: qcom-pon: Add new compatible PMM8654AU
      arm64: dts: qcom: monaco-pmics: Add PON power key and reset inputs

 .../devicetree/bindings/power/reset/qcom,pon.yaml    | 16 ++++++++++------
 arch/arm64/boot/dts/qcom/monaco-pmics.dtsi           | 20 ++++++++++++++++++++
 2 files changed, 30 insertions(+), 6 deletions(-)
---
base-commit: 877552aa875839314afad7154b5a561889e87ea9
change-id: 20260226-b4-add_pwrkey_and_resin-2c04d8d53f5d

Best regards,
-- 
Rakesh Kota <rakesh.kota@oss.qualcomm.com>

[PATCH v3 1/2] dt-bindings: power: reset: qcom-pon: Add new compatible PMM8654AU

[Rakesh Kota]

PMM8654AU is a different PMIC from PMM8650AU, even though both share
the same PMIC subtype. Add PON compatible string for PMM8654AU PMIC
variant.

The PMM8654AU PON block is compatible with the PMK8350 PON
implementation, but PMM8654AU also implements additional PON registers
beyond the baseline. Use the PMM8654AU naming to match the compatible
string already present in the upstream pinctrl-spmi-gpio driver, keeping
device tree and kernel driver naming consistent.

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Signed-off-by: Rakesh Kota <rakesh.kota@oss.qualcomm.com>
---
Changes in v3:
 - Update the commit message.

Changes in v2:
 - Introduces PMM8654AU compatible strings as suggested by Konrad Dybcio.
---
 .../devicetree/bindings/power/reset/qcom,pon.yaml        | 16 ++++++++++------
 1 file changed, 10 insertions(+), 6 deletions(-)

diff --git a/Documentation/devicetree/bindings/power/reset/qcom,pon.yaml b/Documentation/devicetree/bindings/power/reset/qcom,pon.yaml
index 979a377cb4ffd577bfa51b9a3cd089acc202de0c..14b85b0d97da12c756cfe2ce33853501ba4ca46c 100644
--- a/Documentation/devicetree/bindings/power/reset/qcom,pon.yaml
+++ b/Documentation/devicetree/bindings/power/reset/qcom,pon.yaml
@@ -17,12 +17,16 @@ description: |
 
 properties:
   compatible:
-    enum:
-      - qcom,pm8916-pon
-      - qcom,pm8941-pon
-      - qcom,pms405-pon
-      - qcom,pm8998-pon
-      - qcom,pmk8350-pon
+    oneOf:
+      - enum:
+          - qcom,pm8916-pon
+          - qcom,pm8941-pon
+          - qcom,pms405-pon
+          - qcom,pm8998-pon
+          - qcom,pmk8350-pon
+      - items:
+          - const: qcom,pmm8654au-pon
+          - const: qcom,pmk8350-pon
 
   reg:
     description: |

-- 
2.34.1

Re: [PATCH v3 1/2] dt-bindings: power: reset: qcom-pon: Add new compatible PMM8654AU

[Krzysztof Kozlowski]

On Fri, Feb 27, 2026 at 06:02:28PM +0530, Rakesh Kota wrote:
> PMM8654AU is a different PMIC from PMM8650AU, even though both share
> the same PMIC subtype. Add PON compatible string for PMM8654AU PMIC
> variant.
> 
> The PMM8654AU PON block is compatible with the PMK8350 PON
> implementation, but PMM8654AU also implements additional PON registers

So does that mean that PMM8654AU has 2 address spaces and PMK8350 has
only one? At least it looks, so I expect fixing the last if:then: - you
need to drop contains from PMK8350 if clause and add new if:then: for
PMM8654AU.

Although the binding says "pbs" and here you say "PON".


> beyond the baseline. Use the PMM8654AU naming to match the compatible
> string already present in the upstream pinctrl-spmi-gpio driver, keeping
> device tree and kernel driver naming consistent.

And all this is partially confusing. This is reset/PON, not SPMI Pinctrl
GPIO binding.

Best regards,
Krzysztof

Re: [PATCH v3 1/2] dt-bindings: power: reset: qcom-pon: Add new compatible PMM8654AU

[Konrad Dybcio]

On 2/28/26 11:17 AM, Krzysztof Kozlowski wrote:
> On Fri, Feb 27, 2026 at 06:02:28PM +0530, Rakesh Kota wrote:
>> PMM8654AU is a different PMIC from PMM8650AU, even though both share
>> the same PMIC subtype. Add PON compatible string for PMM8654AU PMIC
>> variant.
>>
>> The PMM8654AU PON block is compatible with the PMK8350 PON
>> implementation, but PMM8654AU also implements additional PON registers
> 
> So does that mean that PMM8654AU has 2 address spaces and PMK8350 has
> only one? At least it looks, so I expect fixing the last if:then: - you
> need to drop contains from PMK8350 if clause and add new if:then: for
> PMM8654AU.

The delta between them is such that within the already-described reg
ranges, there is some additional bits and/or registers (can't remember
but it doesn't matter for this point)

This doesn't impact the described size, as all QC PMIC peripherals are
by design allocated 0x100-wide windows

Konrad

> 
> Although the binding says "pbs" and here you say "PON".
> 
> 
>> beyond the baseline. Use the PMM8654AU naming to match the compatible
>> string already present in the upstream pinctrl-spmi-gpio driver, keeping
>> device tree and kernel driver naming consistent.
> 
> And all this is partially confusing. This is reset/PON, not SPMI Pinctrl
> GPIO binding.
> 
> Best regards,
> Krzysztof
> 
> 

Re: [PATCH v3 1/2] dt-bindings: power: reset: qcom-pon: Add new compatible PMM8654AU

[Krzysztof Kozlowski]

On 02/03/2026 11:20, Konrad Dybcio wrote:
> On 2/28/26 11:17 AM, Krzysztof Kozlowski wrote:
>> On Fri, Feb 27, 2026 at 06:02:28PM +0530, Rakesh Kota wrote:
>>> PMM8654AU is a different PMIC from PMM8650AU, even though both share
>>> the same PMIC subtype. Add PON compatible string for PMM8654AU PMIC
>>> variant.
>>>
>>> The PMM8654AU PON block is compatible with the PMK8350 PON
>>> implementation, but PMM8654AU also implements additional PON registers
>>
>> So does that mean that PMM8654AU has 2 address spaces and PMK8350 has
>> only one? At least it looks, so I expect fixing the last if:then: - you
>> need to drop contains from PMK8350 if clause and add new if:then: for
>> PMM8654AU.
> 
> The delta between them is such that within the already-described reg
> ranges, there is some additional bits and/or registers (can't remember
> but it doesn't matter for this point)
> 
> This doesn't impact the described size, as all QC PMIC peripherals are
> by design allocated 0x100-wide windows

I still expect that fixed.

Best regards,
Krzysztof

Re: [PATCH v3 1/2] dt-bindings: power: reset: qcom-pon: Add new compatible PMM8654AU

[Konrad Dybcio]

On 3/2/26 11:28 AM, Krzysztof Kozlowski wrote:
> On 02/03/2026 11:20, Konrad Dybcio wrote:
>> On 2/28/26 11:17 AM, Krzysztof Kozlowski wrote:
>>> On Fri, Feb 27, 2026 at 06:02:28PM +0530, Rakesh Kota wrote:
>>>> PMM8654AU is a different PMIC from PMM8650AU, even though both share
>>>> the same PMIC subtype. Add PON compatible string for PMM8654AU PMIC
>>>> variant.
>>>>
>>>> The PMM8654AU PON block is compatible with the PMK8350 PON
>>>> implementation, but PMM8654AU also implements additional PON registers
>>>
>>> So does that mean that PMM8654AU has 2 address spaces and PMK8350 has
>>> only one? At least it looks, so I expect fixing the last if:then: - you
>>> need to drop contains from PMK8350 if clause and add new if:then: for
>>> PMM8654AU.
>>
>> The delta between them is such that within the already-described reg
>> ranges, there is some additional bits and/or registers (can't remember
>> but it doesn't matter for this point)
>>
>> This doesn't impact the described size, as all QC PMIC peripherals are
>> by design allocated 0x100-wide windows
> 
> I still expect that fixed.

that = commit message?

Konrad

Re: [PATCH v3 1/2] dt-bindings: power: reset: qcom-pon: Add new compatible PMM8654AU

[Krzysztof Kozlowski]

On 04/03/2026 11:08, Konrad Dybcio wrote:
> On 3/2/26 11:28 AM, Krzysztof Kozlowski wrote:
>> On 02/03/2026 11:20, Konrad Dybcio wrote:
>>> On 2/28/26 11:17 AM, Krzysztof Kozlowski wrote:
>>>> On Fri, Feb 27, 2026 at 06:02:28PM +0530, Rakesh Kota wrote:
>>>>> PMM8654AU is a different PMIC from PMM8650AU, even though both share
>>>>> the same PMIC subtype. Add PON compatible string for PMM8654AU PMIC
>>>>> variant.
>>>>>
>>>>> The PMM8654AU PON block is compatible with the PMK8350 PON
>>>>> implementation, but PMM8654AU also implements additional PON registers
>>>>
>>>> So does that mean that PMM8654AU has 2 address spaces and PMK8350 has
>>>> only one? At least it looks, so I expect fixing the last if:then: - you
>>>> need to drop contains from PMK8350 if clause and add new if:then: for
>>>> PMM8654AU.
>>>
>>> The delta between them is such that within the already-described reg
>>> ranges, there is some additional bits and/or registers (can't remember
>>> but it doesn't matter for this point)
>>>
>>> This doesn't impact the described size, as all QC PMIC peripherals are
>>> by design allocated 0x100-wide windows
>>
>> I still expect that fixed.
> 
> that = commit message?

No, what I wrote in my first reply what has to be fixed.

Best regards,
Krzysztof

Re: [PATCH v3 1/2] dt-bindings: power: reset: qcom-pon: Add new compatible PMM8654AU

[Rakesh Kota]

On Wed, Mar 04, 2026 at 11:11:38AM +0100, Krzysztof Kozlowski wrote:
> On 04/03/2026 11:08, Konrad Dybcio wrote:
> > On 3/2/26 11:28 AM, Krzysztof Kozlowski wrote:
> >> On 02/03/2026 11:20, Konrad Dybcio wrote:
> >>> On 2/28/26 11:17 AM, Krzysztof Kozlowski wrote:
> >>>> On Fri, Feb 27, 2026 at 06:02:28PM +0530, Rakesh Kota wrote:
> >>>>> PMM8654AU is a different PMIC from PMM8650AU, even though both share
> >>>>> the same PMIC subtype. Add PON compatible string for PMM8654AU PMIC
> >>>>> variant.
> >>>>>
> >>>>> The PMM8654AU PON block is compatible with the PMK8350 PON
> >>>>> implementation, but PMM8654AU also implements additional PON registers
> >>>>
> >>>> So does that mean that PMM8654AU has 2 address spaces and PMK8350 has
> >>>> only one? At least it looks, so I expect fixing the last if:then: - you
> >>>> need to drop contains from PMK8350 if clause and add new if:then: for
> >>>> PMM8654AU.
> >>>
> >>> The delta between them is such that within the already-described reg
> >>> ranges, there is some additional bits and/or registers (can't remember
> >>> but it doesn't matter for this point)
> >>>
> >>> This doesn't impact the described size, as all QC PMIC peripherals are
> >>> by design allocated 0x100-wide windows
> >>
> >> I still expect that fixed.
> > 
> > that = commit message?
> 
> No, what I wrote in my first reply what has to be fixed.
>
Should i need to add something like below: (removing the contain for
PMK8350 and new if:then for PMM8654AU)

+  - if:
+      properties:
+        compatible:
+          const: qcom,pmk8350-pon
+    then:
+      properties:
+        reg:
+          minItems: 1
+          maxItems: 2
+        reg-names:
+          minItems: 1
+          items:
+            - const: hlos
+            - const: pbs
+
   - if:
      properties:
	 compatible:
	   contains:
-            const: qcom,pmk8350-pon
+            const: qcom,pmm8654au-pon

Note: PMM8654AU uses the same PON register regions as PMK8350. hlos and
pbs togater called PON module and there are no additional reg ranges/properties
needed for PMM8654AU, While PMM8654AU updates some register
definitions (offsets/bits added/removed). 

Best regards
Rakesh kota

> Best regards,
> Krzysztof

[PATCH v3 2/2] arm64: dts: qcom: monaco-pmics: Add PON power key and reset inputs

[Rakesh Kota]

Add the Power On (PON) peripheral with power key and reset input
support for the PMM8654AU PMIC on Monaco platforms.

Signed-off-by: Rakesh Kota <rakesh.kota@oss.qualcomm.com>
---
Changes in v3:
 - Disable the resin as suggested by the Konrad.

Changes in v2:
 - Add new PMM8654AU compatible strings as suggested by the Konrad.
---
 arch/arm64/boot/dts/qcom/monaco-pmics.dtsi | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/monaco-pmics.dtsi b/arch/arm64/boot/dts/qcom/monaco-pmics.dtsi
index e990d7367719beaa9e0cea87d9c183ae18c3ebc8..af4c38309efae89479f9a11fcb970a4c18f03a91 100644
--- a/arch/arm64/boot/dts/qcom/monaco-pmics.dtsi
+++ b/arch/arm64/boot/dts/qcom/monaco-pmics.dtsi
@@ -13,6 +13,26 @@ pmm8620au_0: pmic@0 {
 		#address-cells = <1>;
 		#size-cells = <0>;
 
+		pmm8654au_0_pon: pon@1200 {
+			compatible = "qcom,pmm8654au-pon", "qcom,pmk8350-pon";
+			reg = <0x1200>, <0x800>;
+			reg-names = "hlos", "pbs";
+
+			pmm8654au_0_pon_pwrkey: pwrkey {
+				compatible = "qcom,pmm8654au-pwrkey", "qcom,pmk8350-pwrkey";
+				interrupts-extended = <&spmi_bus 0x0 0x12 0x7 IRQ_TYPE_EDGE_BOTH>;
+				linux,code = <KEY_POWER>;
+				debounce = <15625>;
+			};
+
+			pmm8654au_0_pon_resin: resin {
+				compatible = "qcom,pmm8654au-resin", "qcom,pmk8350-resin";
+				interrupts-extended = <&spmi_bus 0x0 0x12 0x6 IRQ_TYPE_EDGE_BOTH>;
+				debounce = <15625>;
+				status = "disabled";
+			};
+		};
+
 		pmm8620au_0_rtc: rtc@6100 {
 			compatible = "qcom,pmk8350-rtc";
 			reg = <0x6100>, <0x6200>;

-- 
2.34.1

Re: [PATCH v3 2/2] arm64: dts: qcom: monaco-pmics: Add PON power key and reset inputs

[Konrad Dybcio]

On 2/27/26 1:32 PM, Rakesh Kota wrote:
> Add the Power On (PON) peripheral with power key and reset input
> support for the PMM8654AU PMIC on Monaco platforms.
> 
> Signed-off-by: Rakesh Kota <rakesh.kota@oss.qualcomm.com>
> ---
> Changes in v3:
>  - Disable the resin as suggested by the Konrad.
> 
> Changes in v2:
>  - Add new PMM8654AU compatible strings as suggested by the Konrad.
> ---

Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>

Konrad