* [PATCH] clk: qcom: camcc-sc7180: Add parent dependency to all camera GDSCs
@ 2023-04-20 11:55 Taniya Das
2023-04-21 13:42 ` Dmitry Baryshkov
0 siblings, 1 reply; 3+ messages in thread
From: Taniya Das @ 2023-04-20 11:55 UTC (permalink / raw)
To: Stephen Boyd, Bjorn Andersson, Michael Turquette, Andy Gross
Cc: linux-arm-msm, linux-clk, linux-kernel, quic_skakitap,
quic_cponnapa, Taniya Das
Mark titan_top_gdsc as parent to all other camera GDSCs.
Signed-off-by: Taniya Das <quic_tdas@quicinc.com>
---
drivers/clk/qcom/camcc-sc7180.c | 19 ++++++++++++-------
1 file changed, 12 insertions(+), 7 deletions(-)
diff --git a/drivers/clk/qcom/camcc-sc7180.c b/drivers/clk/qcom/camcc-sc7180.c
index e2b4804695f3..8a4ba7a19ed1 100644
--- a/drivers/clk/qcom/camcc-sc7180.c
+++ b/drivers/clk/qcom/camcc-sc7180.c
@@ -1480,12 +1480,21 @@ static struct clk_branch cam_cc_sys_tmr_clk = {
},
};
+static struct gdsc titan_top_gdsc = {
+ .gdscr = 0xb134,
+ .pd = {
+ .name = "titan_top_gdsc",
+ },
+ .pwrsts = PWRSTS_OFF_ON,
+};
+
static struct gdsc bps_gdsc = {
.gdscr = 0x6004,
.pd = {
.name = "bps_gdsc",
},
.pwrsts = PWRSTS_OFF_ON,
+ .parent = &titan_top_gdsc.pd,
.flags = HW_CTRL,
};
@@ -1495,6 +1504,7 @@ static struct gdsc ife_0_gdsc = {
.name = "ife_0_gdsc",
},
.pwrsts = PWRSTS_OFF_ON,
+ .parent = &titan_top_gdsc.pd,
};
static struct gdsc ife_1_gdsc = {
@@ -1503,6 +1513,7 @@ static struct gdsc ife_1_gdsc = {
.name = "ife_1_gdsc",
},
.pwrsts = PWRSTS_OFF_ON,
+ .parent = &titan_top_gdsc.pd,
};
static struct gdsc ipe_0_gdsc = {
@@ -1512,15 +1523,9 @@ static struct gdsc ipe_0_gdsc = {
},
.pwrsts = PWRSTS_OFF_ON,
.flags = HW_CTRL,
+ .parent = &titan_top_gdsc.pd,
};
-static struct gdsc titan_top_gdsc = {
- .gdscr = 0xb134,
- .pd = {
- .name = "titan_top_gdsc",
- },
- .pwrsts = PWRSTS_OFF_ON,
-};
static struct clk_hw *cam_cc_sc7180_hws[] = {
[CAM_CC_PLL2_OUT_EARLY] = &cam_cc_pll2_out_early.hw,
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] clk: qcom: camcc-sc7180: Add parent dependency to all camera GDSCs
2023-04-20 11:55 [PATCH] clk: qcom: camcc-sc7180: Add parent dependency to all camera GDSCs Taniya Das
@ 2023-04-21 13:42 ` Dmitry Baryshkov
2023-04-25 1:20 ` Stephen Boyd
0 siblings, 1 reply; 3+ messages in thread
From: Dmitry Baryshkov @ 2023-04-21 13:42 UTC (permalink / raw)
To: Taniya Das
Cc: Stephen Boyd, Bjorn Andersson, Michael Turquette, Andy Gross,
linux-arm-msm, linux-clk, linux-kernel, quic_skakitap,
quic_cponnapa
On Thu, 20 Apr 2023 at 14:55, Taniya Das <quic_tdas@quicinc.com> wrote:
>
> Mark titan_top_gdsc as parent to all other camera GDSCs.
Please expand the commit message. Your text describes what the patch
does, but it can be observed from the patch itself. Please describe
why it is done.
>
> Signed-off-by: Taniya Das <quic_tdas@quicinc.com>
> ---
> drivers/clk/qcom/camcc-sc7180.c | 19 ++++++++++++-------
> 1 file changed, 12 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/clk/qcom/camcc-sc7180.c b/drivers/clk/qcom/camcc-sc7180.c
> index e2b4804695f3..8a4ba7a19ed1 100644
> --- a/drivers/clk/qcom/camcc-sc7180.c
> +++ b/drivers/clk/qcom/camcc-sc7180.c
> @@ -1480,12 +1480,21 @@ static struct clk_branch cam_cc_sys_tmr_clk = {
> },
> };
>
> +static struct gdsc titan_top_gdsc = {
> + .gdscr = 0xb134,
> + .pd = {
> + .name = "titan_top_gdsc",
> + },
> + .pwrsts = PWRSTS_OFF_ON,
> +};
> +
> static struct gdsc bps_gdsc = {
> .gdscr = 0x6004,
> .pd = {
> .name = "bps_gdsc",
> },
> .pwrsts = PWRSTS_OFF_ON,
> + .parent = &titan_top_gdsc.pd,
> .flags = HW_CTRL,
> };
>
> @@ -1495,6 +1504,7 @@ static struct gdsc ife_0_gdsc = {
> .name = "ife_0_gdsc",
> },
> .pwrsts = PWRSTS_OFF_ON,
> + .parent = &titan_top_gdsc.pd,
> };
>
> static struct gdsc ife_1_gdsc = {
> @@ -1503,6 +1513,7 @@ static struct gdsc ife_1_gdsc = {
> .name = "ife_1_gdsc",
> },
> .pwrsts = PWRSTS_OFF_ON,
> + .parent = &titan_top_gdsc.pd,
> };
>
> static struct gdsc ipe_0_gdsc = {
> @@ -1512,15 +1523,9 @@ static struct gdsc ipe_0_gdsc = {
> },
> .pwrsts = PWRSTS_OFF_ON,
> .flags = HW_CTRL,
> + .parent = &titan_top_gdsc.pd,
> };
>
> -static struct gdsc titan_top_gdsc = {
> - .gdscr = 0xb134,
> - .pd = {
> - .name = "titan_top_gdsc",
> - },
> - .pwrsts = PWRSTS_OFF_ON,
> -};
>
> static struct clk_hw *cam_cc_sc7180_hws[] = {
> [CAM_CC_PLL2_OUT_EARLY] = &cam_cc_pll2_out_early.hw,
> --
> 2.17.1
>
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] clk: qcom: camcc-sc7180: Add parent dependency to all camera GDSCs
2023-04-21 13:42 ` Dmitry Baryshkov
@ 2023-04-25 1:20 ` Stephen Boyd
0 siblings, 0 replies; 3+ messages in thread
From: Stephen Boyd @ 2023-04-25 1:20 UTC (permalink / raw)
To: Dmitry Baryshkov, Taniya Das
Cc: Bjorn Andersson, Michael Turquette, Andy Gross, linux-arm-msm,
linux-clk, linux-kernel, quic_skakitap, quic_cponnapa
Quoting Dmitry Baryshkov (2023-04-21 06:42:06)
> On Thu, 20 Apr 2023 at 14:55, Taniya Das <quic_tdas@quicinc.com> wrote:
> >
> > Mark titan_top_gdsc as parent to all other camera GDSCs.
>
> Please expand the commit message. Your text describes what the patch
> does, but it can be observed from the patch itself. Please describe
> why it is done.
+1 and also add a Fixes tag because I'm guessing this is a fix.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-04-25 1:21 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-04-20 11:55 [PATCH] clk: qcom: camcc-sc7180: Add parent dependency to all camera GDSCs Taniya Das
2023-04-21 13:42 ` Dmitry Baryshkov
2023-04-25 1:20 ` Stephen Boyd
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox