From: Krzysztof Kozlowski <krzk@kernel.org>
To: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Andy Gross <agross@kernel.org>,
Stephan Gerhold <stephan@gerhold.net>
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/4] dt-bindings: soc: qcom: smd-rpm: add generic compatible
Date: Mon, 29 Jul 2024 17:01:59 +0200 [thread overview]
Message-ID: <75a6b4fd-f81c-4bd7-a07b-7f7165ece2fe@kernel.org> (raw)
In-Reply-To: <20240729-fix-smd-rpm-v1-1-99a96133cc65@linaro.org>
On 29/07/2024 13:04, Dmitry Baryshkov wrote:
> Add generic compatible to all smd-rpm devices, they follow the same
> RPMSG protocol.
>
> Fixes: bcabe1e09135 ("soc: qcom: smd-rpm: Match rpmsg channel instead of compatible")
I do not see a bug being fixed here. Whether you have fallback or not,
is a design decision with both options reasonable in certain cases.
More over, some explanation, why you are doing this or what is the
benefit, is missing.
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> ---
> .../devicetree/bindings/soc/qcom/qcom,smd-rpm.yaml | 52 +++++++++++-----------
> 1 file changed, 27 insertions(+), 25 deletions(-)
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-07-29 15:02 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-29 11:04 [PATCH 0/4] soc: qcom: fix rpm_requests module probing Dmitry Baryshkov
2024-07-29 11:04 ` [PATCH 1/4] dt-bindings: soc: qcom: smd-rpm: add generic compatible Dmitry Baryshkov
2024-07-29 12:23 ` Rob Herring (Arm)
2024-07-29 15:01 ` Krzysztof Kozlowski [this message]
2024-07-29 11:04 ` [PATCH 2/4] soc: qcom: smd-rpm: add qcom,smd-rpm compatible Dmitry Baryshkov
2024-07-29 15:04 ` Krzysztof Kozlowski
2024-07-29 17:49 ` Dmitry Baryshkov
2024-07-29 18:36 ` Krzysztof Kozlowski
2024-07-29 18:53 ` Dmitry Baryshkov
2024-07-29 11:04 ` [PATCH 3/4] ARM: dts: qcom: add generic compat string to RPM glink channels Dmitry Baryshkov
2024-07-29 15:06 ` Krzysztof Kozlowski
2024-07-29 11:04 ` [PATCH 4/4] arm64: " Dmitry Baryshkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=75a6b4fd-f81c-4bd7-a07b-7f7165ece2fe@kernel.org \
--to=krzk@kernel.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=stephan@gerhold.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox