From: Krzysztof Kozlowski <krzk@kernel.org>
To: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Cc: Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Andy Gross <agross@kernel.org>,
Stephan Gerhold <stephan@gerhold.net>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/4] soc: qcom: smd-rpm: add qcom,smd-rpm compatible
Date: Mon, 29 Jul 2024 20:36:34 +0200 [thread overview]
Message-ID: <77a21001-09b1-48c3-8aa7-a32ed83e8893@kernel.org> (raw)
In-Reply-To: <CAA8EJppO_fohT_NWJ1P95YYejgAnZQdzrBpz7Ooceiu-t_MkQg@mail.gmail.com>
On 29/07/2024 19:49, Dmitry Baryshkov wrote:
> On Mon, 29 Jul 2024 at 18:04, Krzysztof Kozlowski <krzk@kernel.org> wrote:
>>
>> On 29/07/2024 13:04, Dmitry Baryshkov wrote:
>>> The device node has the compatible string, so the glink channel name
>>> isn't used for modprobing. Add the qcom,smd-rpm compatible to let the
>>> module be automatically loaded when required.
>>
>> So autoloading is not working? I don't understand whether you are fixing
>> real issue or just making something complete based on your feelings.
>
> Yes, autoloading of smd-rpm is not working since bcabe1e09135, kernel
> looks for qcom,rpm-FOO rather than the rpmsg:rpm_requests.
> The obvious fix is to revert the commit, but I don't think that
> listing all the chipsets there is a correct thing.
>
OK, to me it wasn't so sure whether there is a real issue. Anyway, the
reason behind adding common compatible is not to fix autoloading but be
explicit that all of devices follow some sort of FW<->OS protocol.
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-07-29 18:36 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-29 11:04 [PATCH 0/4] soc: qcom: fix rpm_requests module probing Dmitry Baryshkov
2024-07-29 11:04 ` [PATCH 1/4] dt-bindings: soc: qcom: smd-rpm: add generic compatible Dmitry Baryshkov
2024-07-29 12:23 ` Rob Herring (Arm)
2024-07-29 15:01 ` Krzysztof Kozlowski
2024-07-29 11:04 ` [PATCH 2/4] soc: qcom: smd-rpm: add qcom,smd-rpm compatible Dmitry Baryshkov
2024-07-29 15:04 ` Krzysztof Kozlowski
2024-07-29 17:49 ` Dmitry Baryshkov
2024-07-29 18:36 ` Krzysztof Kozlowski [this message]
2024-07-29 18:53 ` Dmitry Baryshkov
2024-07-29 11:04 ` [PATCH 3/4] ARM: dts: qcom: add generic compat string to RPM glink channels Dmitry Baryshkov
2024-07-29 15:06 ` Krzysztof Kozlowski
2024-07-29 11:04 ` [PATCH 4/4] arm64: " Dmitry Baryshkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=77a21001-09b1-48c3-8aa7-a32ed83e8893@kernel.org \
--to=krzk@kernel.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=stephan@gerhold.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox