Linux ARM-MSM sub-architecture
 help / color / mirror / Atom feed
From: Jeffrey Hugo <jhugo@codeaurora.org>
To: Loic Poulain <loic.poulain@linaro.org>,
	manivannan.sadhasivam@linaro.org, hemantk@codeaurora.org
Cc: linux-arm-msm@vger.kernel.org, bjorn.andersson@linaro.org
Subject: Re: [PATCH] bus: mhi: Add MHI PCI support
Date: Wed, 23 Sep 2020 08:03:53 -0600	[thread overview]
Message-ID: <797a690f-247c-7ff1-6468-8d56b0b81116@codeaurora.org> (raw)
In-Reply-To: <1600868432-12438-1-git-send-email-loic.poulain@linaro.org>

On 9/23/2020 7:40 AM, Loic Poulain wrote:
> This is a generic MHI-over-PCI controller driver for MHI only devices
> such as QCOM modems. For now it supports registering of Qualcomm SDX55
> based PCIe modules. The MHI channels have been extracted from mhi
> downstream driver.
> 
> This driver is easily extendable to support other MHI PCI devices like
> different modem hw or OEM superset.
> 

Maybe I'm being a bit dense, but what does this "driver" even do?

Ok, it'll bind to SDX55 and "power up" the MHI.  I don't see any 
communication with the device, so I'm not really seeing the value here. 
  Feels like this should be patch 1 of a series, but patches 2 - X are 
"missing".

-- 
Jeffrey Hugo
Qualcomm Technologies, Inc. is a member of the
Code Aurora Forum, a Linux Foundation Collaborative Project.

  reply	other threads:[~2020-09-23 14:05 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-23 13:40 [PATCH] bus: mhi: Add MHI PCI support Loic Poulain
2020-09-23 14:03 ` Jeffrey Hugo [this message]
2020-09-23 14:35   ` Loic Poulain
2020-09-23 14:55     ` Jeffrey Hugo
2020-09-23 15:42       ` Loic Poulain
2020-09-23 15:17 ` Bjorn Andersson
2020-09-23 15:28   ` Jeffrey Hugo
2020-09-23 16:31   ` Loic Poulain
2020-09-26  5:18     ` Manivannan Sadhasivam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=797a690f-247c-7ff1-6468-8d56b0b81116@codeaurora.org \
    --to=jhugo@codeaurora.org \
    --cc=bjorn.andersson@linaro.org \
    --cc=hemantk@codeaurora.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=loic.poulain@linaro.org \
    --cc=manivannan.sadhasivam@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox