From: Jeffrey Hugo <jhugo@codeaurora.org>
To: Bjorn Andersson <bjorn.andersson@linaro.org>,
Loic Poulain <loic.poulain@linaro.org>
Cc: manivannan.sadhasivam@linaro.org, hemantk@codeaurora.org,
linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH] bus: mhi: Add MHI PCI support
Date: Wed, 23 Sep 2020 09:28:17 -0600 [thread overview]
Message-ID: <96f5107c-849d-8b5f-0473-555e4582bcdb@codeaurora.org> (raw)
In-Reply-To: <20200923151709.GC40811@yoga>
On 9/23/2020 9:17 AM, Bjorn Andersson wrote:
> On Wed 23 Sep 08:40 CDT 2020, Loic Poulain wrote:
>
>> This is a generic MHI-over-PCI controller driver for MHI only devices
>> such as QCOM modems. For now it supports registering of Qualcomm SDX55
>> based PCIe modules. The MHI channels have been extracted from mhi
>> downstream driver.
>>
>> This driver is easily extendable to support other MHI PCI devices like
>> different modem hw or OEM superset.
>>
>> Signed-off-by: Loic Poulain <loic.poulain@linaro.org>
>> ---
> [..]
>> diff --git a/drivers/bus/mhi/controllers/mhi_pci_common.c b/drivers/bus/mhi/controllers/mhi_pci_common.c
>> new file mode 100644
>> index 0000000..705b283
>> --- /dev/null
>> +++ b/drivers/bus/mhi/controllers/mhi_pci_common.c
>
> ath11k is also "PCI" and "MHI" but this isn't "common" code for it, so
> perhaps "mhi_pci_generic.c" or "mhi_pci_modem.c"?
It occurs to me from seeing Bjorn's comment, GregKH had a pretty hard
objection to creating a directory for the mhi_uci driver (more or less
its pointless to have a directory for a single file, wait until there
are a mess of files that need to be managed), and this patch is doing
the same thing. I would suggest dropping the "controllers" directory,
and just putting this in the root mhi directory.
--
Jeffrey Hugo
Qualcomm Technologies, Inc. is a member of the
Code Aurora Forum, a Linux Foundation Collaborative Project.
next prev parent reply other threads:[~2020-09-23 15:28 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-23 13:40 [PATCH] bus: mhi: Add MHI PCI support Loic Poulain
2020-09-23 14:03 ` Jeffrey Hugo
2020-09-23 14:35 ` Loic Poulain
2020-09-23 14:55 ` Jeffrey Hugo
2020-09-23 15:42 ` Loic Poulain
2020-09-23 15:17 ` Bjorn Andersson
2020-09-23 15:28 ` Jeffrey Hugo [this message]
2020-09-23 16:31 ` Loic Poulain
2020-09-26 5:18 ` Manivannan Sadhasivam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=96f5107c-849d-8b5f-0473-555e4582bcdb@codeaurora.org \
--to=jhugo@codeaurora.org \
--cc=bjorn.andersson@linaro.org \
--cc=hemantk@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=loic.poulain@linaro.org \
--cc=manivannan.sadhasivam@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox