* [PATCH v2 0/2] Bluetooth: hci_qca: Refactor HFP hardware offload capability handling @ 2026-01-26 16:24 Mengshi Wu 2026-01-26 16:24 ` [PATCH v2 1/2] " Mengshi Wu 2026-01-26 16:24 ` [PATCH v2 2/2] Bluetooth: hci_qca: Enable HFP hardware offload for WCN6855 Mengshi Wu 0 siblings, 2 replies; 14+ messages in thread From: Mengshi Wu @ 2026-01-26 16:24 UTC (permalink / raw) To: Bartosz Golaszewski, Marcel Holtmann, Luiz Augusto von Dentz Cc: linux-arm-msm, linux-bluetooth, linux-kernel, shuai.zhang, cheng.jiang, chezhou, wei.deng, yiboz, Mengshi Wu Changes from v2: - Add QCA_CAP_HFP_HW_OFFLOAD capability flag at first commit to avoid breaking original logic. Changes from v1: - Refactor HFP hardware offload capability handling. - Enable HFP hardware offload for QCA2066 and WCN6855. - Link to v1: https://lore.kernel.org/all/20260123055243.2634107-1-mengshi.wu@oss.qualcomm.com/ Mengshi Wu (2): Bluetooth: hci_qca: Refactor HFP hardware offload capability handling Bluetooth: hci_qca: Enable HFP hardware offload for WCN6855 drivers/bluetooth/hci_qca.c | 16 +++++++++++----- 1 file changed, 11 insertions(+), 5 deletions(-) -- 2.34.1 ^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH v2 1/2] Bluetooth: hci_qca: Refactor HFP hardware offload capability handling 2026-01-26 16:24 [PATCH v2 0/2] Bluetooth: hci_qca: Refactor HFP hardware offload capability handling Mengshi Wu @ 2026-01-26 16:24 ` Mengshi Wu 2026-01-26 17:49 ` Dmitry Baryshkov 2026-01-26 16:24 ` [PATCH v2 2/2] Bluetooth: hci_qca: Enable HFP hardware offload for WCN6855 Mengshi Wu 1 sibling, 1 reply; 14+ messages in thread From: Mengshi Wu @ 2026-01-26 16:24 UTC (permalink / raw) To: Bartosz Golaszewski, Marcel Holtmann, Luiz Augusto von Dentz Cc: linux-arm-msm, linux-bluetooth, linux-kernel, shuai.zhang, cheng.jiang, chezhou, wei.deng, yiboz, Mengshi Wu Replace SoC-specific check with capability-based approach for HFP hardware offload configuration. Add QCA_CAP_HFP_HW_OFFLOAD capability flag and support_hfp_hw_offload field to qca_serdev structure. Add QCA_CAP_HFP_HW_OFFLOAD capability flag to QCA2066 device data structures. Signed-off-by: Mengshi Wu <mengshi.wu@oss.qualcomm.com> --- drivers/bluetooth/hci_qca.c | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/drivers/bluetooth/hci_qca.c b/drivers/bluetooth/hci_qca.c index 888176b0f..b99fdda88 100644 --- a/drivers/bluetooth/hci_qca.c +++ b/drivers/bluetooth/hci_qca.c @@ -87,6 +87,7 @@ enum qca_flags { enum qca_capabilities { QCA_CAP_WIDEBAND_SPEECH = BIT(0), QCA_CAP_VALID_LE_STATES = BIT(1), + QCA_CAP_HFP_HW_OFFLOAD = BIT(2), }; /* HCI_IBS transmit side sleep protocol states */ @@ -229,6 +230,7 @@ struct qca_serdev { u32 init_speed; u32 oper_speed; bool bdaddr_property_broken; + bool support_hfp_hw_offload; const char *firmware_name[2]; }; @@ -1879,7 +1881,7 @@ static int qca_setup(struct hci_uart *hu) const char *rampatch_name = qca_get_rampatch_name(hu); int ret; struct qca_btsoc_version ver; - struct qca_serdev *qcadev; + struct qca_serdev *qcadev = serdev_device_get_drvdata(hu->serdev); const char *soc_name; ret = qca_check_speeds(hu); @@ -1943,7 +1945,6 @@ static int qca_setup(struct hci_uart *hu) case QCA_WCN6750: case QCA_WCN6855: case QCA_WCN7850: - qcadev = serdev_device_get_drvdata(hu->serdev); if (qcadev->bdaddr_property_broken) hci_set_quirk(hdev, HCI_QUIRK_BDADDR_PROPERTY_BROKEN); @@ -2033,7 +2034,7 @@ static int qca_setup(struct hci_uart *hu) else hu->hdev->set_bdaddr = qca_set_bdaddr; - if (soc_type == QCA_QCA2066) + if (qcadev->support_hfp_hw_offload) qca_configure_hfp_offload(hdev); qca->fw_version = le16_to_cpu(ver.patch_ver); @@ -2117,7 +2118,8 @@ static const struct qca_device_data qca_soc_data_wcn3998 __maybe_unused = { static const struct qca_device_data qca_soc_data_qca2066 __maybe_unused = { .soc_type = QCA_QCA2066, .num_vregs = 0, - .capabilities = QCA_CAP_WIDEBAND_SPEECH | QCA_CAP_VALID_LE_STATES, + .capabilities = QCA_CAP_WIDEBAND_SPEECH | QCA_CAP_VALID_LE_STATES | + QCA_CAP_HFP_HW_OFFLOAD, }; static const struct qca_device_data qca_soc_data_qca6390 __maybe_unused = { @@ -2502,6 +2504,9 @@ static int qca_serdev_probe(struct serdev_device *serdev) if (!(data->capabilities & QCA_CAP_VALID_LE_STATES)) hci_set_quirk(hdev, HCI_QUIRK_BROKEN_LE_STATES); + + if (data->capabilities & QCA_CAP_HFP_HW_OFFLOAD) + qcadev->support_hfp_hw_offload = true; } return 0; -- 2.34.1 ^ permalink raw reply related [flat|nested] 14+ messages in thread
* Re: [PATCH v2 1/2] Bluetooth: hci_qca: Refactor HFP hardware offload capability handling 2026-01-26 16:24 ` [PATCH v2 1/2] " Mengshi Wu @ 2026-01-26 17:49 ` Dmitry Baryshkov 0 siblings, 0 replies; 14+ messages in thread From: Dmitry Baryshkov @ 2026-01-26 17:49 UTC (permalink / raw) To: Mengshi Wu Cc: Bartosz Golaszewski, Marcel Holtmann, Luiz Augusto von Dentz, linux-arm-msm, linux-bluetooth, linux-kernel, shuai.zhang, cheng.jiang, chezhou, wei.deng, yiboz On Tue, Jan 27, 2026 at 12:24:43AM +0800, Mengshi Wu wrote: > Replace SoC-specific check with capability-based approach for HFP > hardware offload configuration. Add QCA_CAP_HFP_HW_OFFLOAD capability > flag and support_hfp_hw_offload field to qca_serdev structure. Add > QCA_CAP_HFP_HW_OFFLOAD capability flag to QCA2066 device data > structures. > > Signed-off-by: Mengshi Wu <mengshi.wu@oss.qualcomm.com> > --- > drivers/bluetooth/hci_qca.c | 13 +++++++++---- > 1 file changed, 9 insertions(+), 4 deletions(-) > Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com> -- With best wishes Dmitry ^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH v2 2/2] Bluetooth: hci_qca: Enable HFP hardware offload for WCN6855 2026-01-26 16:24 [PATCH v2 0/2] Bluetooth: hci_qca: Refactor HFP hardware offload capability handling Mengshi Wu 2026-01-26 16:24 ` [PATCH v2 1/2] " Mengshi Wu @ 2026-01-26 16:24 ` Mengshi Wu 2026-01-26 17:51 ` Dmitry Baryshkov 1 sibling, 1 reply; 14+ messages in thread From: Mengshi Wu @ 2026-01-26 16:24 UTC (permalink / raw) To: Bartosz Golaszewski, Marcel Holtmann, Luiz Augusto von Dentz Cc: linux-arm-msm, linux-bluetooth, linux-kernel, shuai.zhang, cheng.jiang, chezhou, wei.deng, yiboz, Mengshi Wu Add QCA_CAP_HFP_HW_OFFLOAD capability flag to WCN6855 device data structures to enable Hands-Free Profile (HFP) hardware offload support on these Qualcomm Bluetooth chipsets. Signed-off-by: Mengshi Wu <mengshi.wu@oss.qualcomm.com> --- drivers/bluetooth/hci_qca.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/bluetooth/hci_qca.c b/drivers/bluetooth/hci_qca.c index b99fdda88..212a92bbf 100644 --- a/drivers/bluetooth/hci_qca.c +++ b/drivers/bluetooth/hci_qca.c @@ -2155,7 +2155,8 @@ static const struct qca_device_data qca_soc_data_wcn6855 __maybe_unused = { { "vddrfa1p2", 257000 }, }, .num_vregs = 6, - .capabilities = QCA_CAP_WIDEBAND_SPEECH | QCA_CAP_VALID_LE_STATES, + .capabilities = QCA_CAP_WIDEBAND_SPEECH | QCA_CAP_VALID_LE_STATES | + QCA_CAP_HFP_HW_OFFLOAD, }; static const struct qca_device_data qca_soc_data_wcn7850 __maybe_unused = { -- 2.34.1 ^ permalink raw reply related [flat|nested] 14+ messages in thread
* Re: [PATCH v2 2/2] Bluetooth: hci_qca: Enable HFP hardware offload for WCN6855 2026-01-26 16:24 ` [PATCH v2 2/2] Bluetooth: hci_qca: Enable HFP hardware offload for WCN6855 Mengshi Wu @ 2026-01-26 17:51 ` Dmitry Baryshkov 2026-01-27 2:32 ` Mengshi Wu 0 siblings, 1 reply; 14+ messages in thread From: Dmitry Baryshkov @ 2026-01-26 17:51 UTC (permalink / raw) To: Mengshi Wu Cc: Bartosz Golaszewski, Marcel Holtmann, Luiz Augusto von Dentz, linux-arm-msm, linux-bluetooth, linux-kernel, shuai.zhang, cheng.jiang, chezhou, wei.deng, yiboz On Tue, Jan 27, 2026 at 12:24:44AM +0800, Mengshi Wu wrote: > Add QCA_CAP_HFP_HW_OFFLOAD capability flag to WCN6855 device > data structures to enable Hands-Free Profile (HFP) hardware > offload support on these Qualcomm Bluetooth chipsets. > > Signed-off-by: Mengshi Wu <mengshi.wu@oss.qualcomm.com> > --- > drivers/bluetooth/hci_qca.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > Any other chips which would benefit from this flag? If you are setting it for WCN6855, I'd assume that it also applies to WCN7850. Should it be set for WCN6750? -- With best wishes Dmitry ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH v2 2/2] Bluetooth: hci_qca: Enable HFP hardware offload for WCN6855 2026-01-26 17:51 ` Dmitry Baryshkov @ 2026-01-27 2:32 ` Mengshi Wu 2026-01-27 15:06 ` Dmitry Baryshkov 0 siblings, 1 reply; 14+ messages in thread From: Mengshi Wu @ 2026-01-27 2:32 UTC (permalink / raw) To: Dmitry Baryshkov Cc: Bartosz Golaszewski, Marcel Holtmann, Luiz Augusto von Dentz, linux-arm-msm, linux-bluetooth, linux-kernel, shuai.zhang, cheng.jiang, chezhou, wei.deng, yiboz On 1/27/2026 1:51 AM, Dmitry Baryshkov wrote: > On Tue, Jan 27, 2026 at 12:24:44AM +0800, Mengshi Wu wrote: >> Add QCA_CAP_HFP_HW_OFFLOAD capability flag to WCN6855 device >> data structures to enable Hands-Free Profile (HFP) hardware >> offload support on these Qualcomm Bluetooth chipsets. >> >> Signed-off-by: Mengshi Wu <mengshi.wu@oss.qualcomm.com> >> --- >> drivers/bluetooth/hci_qca.c | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> > > Any other chips which would benefit from this flag? If you are setting > it for WCN6855, I'd assume that it also applies to WCN7850. Should it be > set for WCN6750? > Thanks for the reminder. This should also apply to WCN7850. WCN6750 is not considered at this time. ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH v2 2/2] Bluetooth: hci_qca: Enable HFP hardware offload for WCN6855 2026-01-27 2:32 ` Mengshi Wu @ 2026-01-27 15:06 ` Dmitry Baryshkov 2026-01-27 15:47 ` Luiz Augusto von Dentz 2026-01-28 3:17 ` Mengshi Wu 0 siblings, 2 replies; 14+ messages in thread From: Dmitry Baryshkov @ 2026-01-27 15:06 UTC (permalink / raw) To: Mengshi Wu Cc: Bartosz Golaszewski, Marcel Holtmann, Luiz Augusto von Dentz, linux-arm-msm, linux-bluetooth, linux-kernel, shuai.zhang, cheng.jiang, chezhou, wei.deng, yiboz On Tue, Jan 27, 2026 at 10:32:58AM +0800, Mengshi Wu wrote: > > > On 1/27/2026 1:51 AM, Dmitry Baryshkov wrote: > > On Tue, Jan 27, 2026 at 12:24:44AM +0800, Mengshi Wu wrote: > >> Add QCA_CAP_HFP_HW_OFFLOAD capability flag to WCN6855 device > >> data structures to enable Hands-Free Profile (HFP) hardware > >> offload support on these Qualcomm Bluetooth chipsets. > >> > >> Signed-off-by: Mengshi Wu <mengshi.wu@oss.qualcomm.com> > >> --- > >> drivers/bluetooth/hci_qca.c | 3 ++- > >> 1 file changed, 2 insertions(+), 1 deletion(-) > >> > > > > Any other chips which would benefit from this flag? If you are setting > > it for WCN6855, I'd assume that it also applies to WCN7850. Should it be > > set for WCN6750? > > > > Thanks for the reminder. This should also apply to WCN7850. WCN6750 is not > considered at this time. What does it mean? It either supports HFP ofload, or not. Does it? -- With best wishes Dmitry ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH v2 2/2] Bluetooth: hci_qca: Enable HFP hardware offload for WCN6855 2026-01-27 15:06 ` Dmitry Baryshkov @ 2026-01-27 15:47 ` Luiz Augusto von Dentz 2026-01-28 3:55 ` Mengshi Wu 2026-01-28 4:03 ` Mengshi Wu 2026-01-28 3:17 ` Mengshi Wu 1 sibling, 2 replies; 14+ messages in thread From: Luiz Augusto von Dentz @ 2026-01-27 15:47 UTC (permalink / raw) To: Dmitry Baryshkov Cc: Mengshi Wu, Bartosz Golaszewski, Marcel Holtmann, linux-arm-msm, linux-bluetooth, linux-kernel, shuai.zhang, cheng.jiang, chezhou, wei.deng, yiboz Hi, On Tue, Jan 27, 2026 at 10:06 AM Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com> wrote: > > On Tue, Jan 27, 2026 at 10:32:58AM +0800, Mengshi Wu wrote: > > > > > > On 1/27/2026 1:51 AM, Dmitry Baryshkov wrote: > > > On Tue, Jan 27, 2026 at 12:24:44AM +0800, Mengshi Wu wrote: > > >> Add QCA_CAP_HFP_HW_OFFLOAD capability flag to WCN6855 device > > >> data structures to enable Hands-Free Profile (HFP) hardware > > >> offload support on these Qualcomm Bluetooth chipsets. > > >> > > >> Signed-off-by: Mengshi Wu <mengshi.wu@oss.qualcomm.com> > > >> --- > > >> drivers/bluetooth/hci_qca.c | 3 ++- > > >> 1 file changed, 2 insertions(+), 1 deletion(-) > > >> > > > > > > Any other chips which would benefit from this flag? If you are setting > > > it for WCN6855, I'd assume that it also applies to WCN7850. Should it be > > > set for WCN6750? > > > > > > > Thanks for the reminder. This should also apply to WCN7850. WCN6750 is not > > considered at this time. > > What does it mean? It either supports HFP ofload, or not. Does it? Or does that mean offload is considered the default over HCI, and in that case does it actually work with the likes of Linux distros/Pipewire or it is Android only? The fact that it is mentioning HFP rather than SCO is already concerning to me, the kernel driver shouldn't be involved with profile layers other than core. > > -- > With best wishes > Dmitry -- Luiz Augusto von Dentz ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH v2 2/2] Bluetooth: hci_qca: Enable HFP hardware offload for WCN6855 2026-01-27 15:47 ` Luiz Augusto von Dentz @ 2026-01-28 3:55 ` Mengshi Wu 2026-01-28 4:03 ` Mengshi Wu 1 sibling, 0 replies; 14+ messages in thread From: Mengshi Wu @ 2026-01-28 3:55 UTC (permalink / raw) To: Luiz Augusto von Dentz, Dmitry Baryshkov Cc: Bartosz Golaszewski, Marcel Holtmann, linux-arm-msm, linux-bluetooth, linux-kernel, shuai.zhang, cheng.jiang, chezhou, wei.deng, yiboz Hi, On 1/27/2026 11:47 PM, Luiz Augusto von Dentz wrote: > Hi, > > On Tue, Jan 27, 2026 at 10:06 AM Dmitry Baryshkov > <dmitry.baryshkov@oss.qualcomm.com> wrote: >> >> On Tue, Jan 27, 2026 at 10:32:58AM +0800, Mengshi Wu wrote: >>> >>> >>> On 1/27/2026 1:51 AM, Dmitry Baryshkov wrote: >>>> On Tue, Jan 27, 2026 at 12:24:44AM +0800, Mengshi Wu wrote: >>>>> Add QCA_CAP_HFP_HW_OFFLOAD capability flag to WCN6855 device >>>>> data structures to enable Hands-Free Profile (HFP) hardware >>>>> offload support on these Qualcomm Bluetooth chipsets. >>>>> >>>>> Signed-off-by: Mengshi Wu <mengshi.wu@oss.qualcomm.com> >>>>> --- >>>>> drivers/bluetooth/hci_qca.c | 3 ++- >>>>> 1 file changed, 2 insertions(+), 1 deletion(-) >>>>> >>>> >>>> Any other chips which would benefit from this flag? If you are setting >>>> it for WCN6855, I'd assume that it also applies to WCN7850. Should it be >>>> set for WCN6750? >>>> >>> >>> Thanks for the reminder. This should also apply to WCN7850. WCN6750 is not >>> considered at this time. >> >> What does it mean? It either supports HFP ofload, or not. Does it? > > Or does that mean offload is considered the default over HCI, and in > that case does it actually work with the likes of Linux > distros/Pipewire or it is Android only? The fact that it is mentioning > HFP rather than SCO is already concerning to me, the kernel driver > shouldn't be involved with profile layers other than core. > Offloading over HCI is the default way for most use cases, but I don't mean it. Offloading over non-HCI ways (such as I2S, slimbus) need some other supports from software aspect, these supports for other chips are not ready yet. I use HFP because I notice it was used before, like qca_configure_hfp_offload(). Should I correct it if it is not proper here? > >> >> -- >> With best wishes >> Dmitry > > > ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH v2 2/2] Bluetooth: hci_qca: Enable HFP hardware offload for WCN6855 2026-01-27 15:47 ` Luiz Augusto von Dentz 2026-01-28 3:55 ` Mengshi Wu @ 2026-01-28 4:03 ` Mengshi Wu 1 sibling, 0 replies; 14+ messages in thread From: Mengshi Wu @ 2026-01-28 4:03 UTC (permalink / raw) To: Luiz Augusto von Dentz, Dmitry Baryshkov Cc: Bartosz Golaszewski, Marcel Holtmann, linux-arm-msm, linux-bluetooth, linux-kernel, shuai.zhang, cheng.jiang, chezhou, wei.deng, yiboz Hi, On 1/27/2026 11:47 PM, Luiz Augusto von Dentz wrote: > Hi, > > On Tue, Jan 27, 2026 at 10:06 AM Dmitry Baryshkov > <dmitry.baryshkov@oss.qualcomm.com> wrote: >> >> On Tue, Jan 27, 2026 at 10:32:58AM +0800, Mengshi Wu wrote: >>> >>> >>> On 1/27/2026 1:51 AM, Dmitry Baryshkov wrote: >>>> On Tue, Jan 27, 2026 at 12:24:44AM +0800, Mengshi Wu wrote: >>>>> Add QCA_CAP_HFP_HW_OFFLOAD capability flag to WCN6855 device >>>>> data structures to enable Hands-Free Profile (HFP) hardware >>>>> offload support on these Qualcomm Bluetooth chipsets. >>>>> >>>>> Signed-off-by: Mengshi Wu <mengshi.wu@oss.qualcomm.com> >>>>> --- >>>>> drivers/bluetooth/hci_qca.c | 3 ++- >>>>> 1 file changed, 2 insertions(+), 1 deletion(-) >>>>> >>>> >>>> Any other chips which would benefit from this flag? If you are setting >>>> it for WCN6855, I'd assume that it also applies to WCN7850. Should it be >>>> set for WCN6750? >>>> >>> >>> Thanks for the reminder. This should also apply to WCN7850. WCN6750 is not >>> considered at this time. >> >> What does it mean? It either supports HFP ofload, or not. Does it? > > Or does that mean offload is considered the default over HCI, and in > that case does it actually work with the likes of Linux > distros/Pipewire or it is Android only? The fact that it is mentioning > HFP rather than SCO is already concerning to me, the kernel driver > shouldn't be involved with profile layers other than core. > > Offload over HCI is the default way in most cases, but I don't mean it here. Offload over non-HCI ways (such as I2S, Slimbus) need other supports from software aspect, but these supports are not ready for other chips yet. I use HFP because I noticed that it was used before, like qca_configure_hfp_offload(). Should I change to use SCO if HFP is not proper here? >> >> -- >> With best wishes >> Dmitry > > > ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH v2 2/2] Bluetooth: hci_qca: Enable HFP hardware offload for WCN6855 2026-01-27 15:06 ` Dmitry Baryshkov 2026-01-27 15:47 ` Luiz Augusto von Dentz @ 2026-01-28 3:17 ` Mengshi Wu 2026-01-30 2:31 ` Dmitry Baryshkov 1 sibling, 1 reply; 14+ messages in thread From: Mengshi Wu @ 2026-01-28 3:17 UTC (permalink / raw) To: Dmitry Baryshkov Cc: Bartosz Golaszewski, Marcel Holtmann, Luiz Augusto von Dentz, linux-arm-msm, linux-bluetooth, linux-kernel, shuai.zhang, cheng.jiang, chezhou, wei.deng, yiboz Hi, On 1/27/2026 11:06 PM, Dmitry Baryshkov wrote: > On Tue, Jan 27, 2026 at 10:32:58AM +0800, Mengshi Wu wrote: >> >> >> On 1/27/2026 1:51 AM, Dmitry Baryshkov wrote: >>> On Tue, Jan 27, 2026 at 12:24:44AM +0800, Mengshi Wu wrote: >>>> Add QCA_CAP_HFP_HW_OFFLOAD capability flag to WCN6855 device >>>> data structures to enable Hands-Free Profile (HFP) hardware >>>> offload support on these Qualcomm Bluetooth chipsets. >>>> >>>> Signed-off-by: Mengshi Wu <mengshi.wu@oss.qualcomm.com> >>>> --- >>>> drivers/bluetooth/hci_qca.c | 3 ++- >>>> 1 file changed, 2 insertions(+), 1 deletion(-) >>>> >>> >>> Any other chips which would benefit from this flag? If you are setting >>> it for WCN6855, I'd assume that it also applies to WCN7850. Should it be >>> set for WCN6750? >>> >> >> Thanks for the reminder. This should also apply to WCN7850. WCN6750 is not >> considered at this time. > > What does it mean? It either supports HFP ofload, or not. Does it? > We have not yet enabled the WCN6750 hardware offload feature from the software side. Other chips will support this feature subsequently. If I add the flag too early, it may be kind of misleading since the feature is not really ready yet. ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH v2 2/2] Bluetooth: hci_qca: Enable HFP hardware offload for WCN6855 2026-01-28 3:17 ` Mengshi Wu @ 2026-01-30 2:31 ` Dmitry Baryshkov 2026-02-02 2:33 ` Mengshi Wu 0 siblings, 1 reply; 14+ messages in thread From: Dmitry Baryshkov @ 2026-01-30 2:31 UTC (permalink / raw) To: Mengshi Wu Cc: Bartosz Golaszewski, Marcel Holtmann, Luiz Augusto von Dentz, linux-arm-msm, linux-bluetooth, linux-kernel, shuai.zhang, cheng.jiang, chezhou, wei.deng, yiboz On Wed, Jan 28, 2026 at 11:17:49AM +0800, Mengshi Wu wrote: > Hi, > > On 1/27/2026 11:06 PM, Dmitry Baryshkov wrote: > > On Tue, Jan 27, 2026 at 10:32:58AM +0800, Mengshi Wu wrote: > >> > >> > >> On 1/27/2026 1:51 AM, Dmitry Baryshkov wrote: > >>> On Tue, Jan 27, 2026 at 12:24:44AM +0800, Mengshi Wu wrote: > >>>> Add QCA_CAP_HFP_HW_OFFLOAD capability flag to WCN6855 device > >>>> data structures to enable Hands-Free Profile (HFP) hardware > >>>> offload support on these Qualcomm Bluetooth chipsets. > >>>> > >>>> Signed-off-by: Mengshi Wu <mengshi.wu@oss.qualcomm.com> > >>>> --- > >>>> drivers/bluetooth/hci_qca.c | 3 ++- > >>>> 1 file changed, 2 insertions(+), 1 deletion(-) > >>>> > >>> > >>> Any other chips which would benefit from this flag? If you are setting > >>> it for WCN6855, I'd assume that it also applies to WCN7850. Should it be > >>> set for WCN6750? > >>> > >> > >> Thanks for the reminder. This should also apply to WCN7850. WCN6750 is not > >> considered at this time. > > > > What does it mean? It either supports HFP ofload, or not. Does it? > > > > We have not yet enabled the WCN6750 hardware offload feature from the > software side. Other chips will support this feature subsequently. If > I add the flag too early, it may be kind of misleading since the feature > is not really ready yet. By the software side do you mean BT firmware or something else? -- With best wishes Dmitry ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH v2 2/2] Bluetooth: hci_qca: Enable HFP hardware offload for WCN6855 2026-01-30 2:31 ` Dmitry Baryshkov @ 2026-02-02 2:33 ` Mengshi Wu 2026-02-04 2:44 ` Dmitry Baryshkov 0 siblings, 1 reply; 14+ messages in thread From: Mengshi Wu @ 2026-02-02 2:33 UTC (permalink / raw) To: Dmitry Baryshkov Cc: Bartosz Golaszewski, Marcel Holtmann, Luiz Augusto von Dentz, linux-arm-msm, linux-bluetooth, linux-kernel, shuai.zhang, cheng.jiang, chezhou, wei.deng, yiboz Hi, On 1/30/2026 10:31 AM, Dmitry Baryshkov wrote: > On Wed, Jan 28, 2026 at 11:17:49AM +0800, Mengshi Wu wrote: >> Hi, >> >> On 1/27/2026 11:06 PM, Dmitry Baryshkov wrote: >>> On Tue, Jan 27, 2026 at 10:32:58AM +0800, Mengshi Wu wrote: >>>> >>>> >>>> On 1/27/2026 1:51 AM, Dmitry Baryshkov wrote: >>>>> On Tue, Jan 27, 2026 at 12:24:44AM +0800, Mengshi Wu wrote: >>>>>> Add QCA_CAP_HFP_HW_OFFLOAD capability flag to WCN6855 device >>>>>> data structures to enable Hands-Free Profile (HFP) hardware >>>>>> offload support on these Qualcomm Bluetooth chipsets. >>>>>> >>>>>> Signed-off-by: Mengshi Wu <mengshi.wu@oss.qualcomm.com> >>>>>> --- >>>>>> drivers/bluetooth/hci_qca.c | 3 ++- >>>>>> 1 file changed, 2 insertions(+), 1 deletion(-) >>>>>> >>>>> >>>>> Any other chips which would benefit from this flag? If you are setting >>>>> it for WCN6855, I'd assume that it also applies to WCN7850. Should it be >>>>> set for WCN6750? >>>>> >>>> >>>> Thanks for the reminder. This should also apply to WCN7850. WCN6750 is not >>>> considered at this time. >>> >>> What does it mean? It either supports HFP ofload, or not. Does it? >>> >> >> We have not yet enabled the WCN6750 hardware offload feature from the >> software side. Other chips will support this feature subsequently. If >> I add the flag too early, it may be kind of misleading since the feature >> is not really ready yet. > > By the software side do you mean BT firmware or something else? > Yes, firmware. And we will update firmware later to support this feature. ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH v2 2/2] Bluetooth: hci_qca: Enable HFP hardware offload for WCN6855 2026-02-02 2:33 ` Mengshi Wu @ 2026-02-04 2:44 ` Dmitry Baryshkov 0 siblings, 0 replies; 14+ messages in thread From: Dmitry Baryshkov @ 2026-02-04 2:44 UTC (permalink / raw) To: Mengshi Wu Cc: Bartosz Golaszewski, Marcel Holtmann, Luiz Augusto von Dentz, linux-arm-msm, linux-bluetooth, linux-kernel, shuai.zhang, cheng.jiang, chezhou, wei.deng, yiboz On Mon, Feb 02, 2026 at 10:33:53AM +0800, Mengshi Wu wrote: > Hi, > > On 1/30/2026 10:31 AM, Dmitry Baryshkov wrote: > > On Wed, Jan 28, 2026 at 11:17:49AM +0800, Mengshi Wu wrote: > >> Hi, > >> > >> On 1/27/2026 11:06 PM, Dmitry Baryshkov wrote: > >>> On Tue, Jan 27, 2026 at 10:32:58AM +0800, Mengshi Wu wrote: > >>>> > >>>> > >>>> On 1/27/2026 1:51 AM, Dmitry Baryshkov wrote: > >>>>> On Tue, Jan 27, 2026 at 12:24:44AM +0800, Mengshi Wu wrote: > >>>>>> Add QCA_CAP_HFP_HW_OFFLOAD capability flag to WCN6855 device > >>>>>> data structures to enable Hands-Free Profile (HFP) hardware > >>>>>> offload support on these Qualcomm Bluetooth chipsets. > >>>>>> > >>>>>> Signed-off-by: Mengshi Wu <mengshi.wu@oss.qualcomm.com> > >>>>>> --- > >>>>>> drivers/bluetooth/hci_qca.c | 3 ++- > >>>>>> 1 file changed, 2 insertions(+), 1 deletion(-) > >>>>>> > >>>>> > >>>>> Any other chips which would benefit from this flag? If you are setting > >>>>> it for WCN6855, I'd assume that it also applies to WCN7850. Should it be > >>>>> set for WCN6750? > >>>>> > >>>> > >>>> Thanks for the reminder. This should also apply to WCN7850. WCN6750 is not > >>>> considered at this time. > >>> > >>> What does it mean? It either supports HFP ofload, or not. Does it? > >>> > >> > >> We have not yet enabled the WCN6750 hardware offload feature from the > >> software side. Other chips will support this feature subsequently. If > >> I add the flag too early, it may be kind of misleading since the feature > >> is not really ready yet. > > > > By the software side do you mean BT firmware or something else? > > > Yes, firmware. And we will update firmware later to support this feature. Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com> -- With best wishes Dmitry ^ permalink raw reply [flat|nested] 14+ messages in thread
end of thread, other threads:[~2026-02-04 2:44 UTC | newest] Thread overview: 14+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2026-01-26 16:24 [PATCH v2 0/2] Bluetooth: hci_qca: Refactor HFP hardware offload capability handling Mengshi Wu 2026-01-26 16:24 ` [PATCH v2 1/2] " Mengshi Wu 2026-01-26 17:49 ` Dmitry Baryshkov 2026-01-26 16:24 ` [PATCH v2 2/2] Bluetooth: hci_qca: Enable HFP hardware offload for WCN6855 Mengshi Wu 2026-01-26 17:51 ` Dmitry Baryshkov 2026-01-27 2:32 ` Mengshi Wu 2026-01-27 15:06 ` Dmitry Baryshkov 2026-01-27 15:47 ` Luiz Augusto von Dentz 2026-01-28 3:55 ` Mengshi Wu 2026-01-28 4:03 ` Mengshi Wu 2026-01-28 3:17 ` Mengshi Wu 2026-01-30 2:31 ` Dmitry Baryshkov 2026-02-02 2:33 ` Mengshi Wu 2026-02-04 2:44 ` Dmitry Baryshkov
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox