From: James Clark <james.clark@linaro.org>
To: Jie Gan <quic_jiegan@quicinc.com>
Cc: Jinlong Mao <quic_jinlmao@quicinc.com>,
coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
Tingwei Zhang <quic_tingweiz@quicinc.com>,
linux-arm-msm@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com,
Suzuki K Poulose <suzuki.poulose@arm.com>,
Mike Leach <mike.leach@linaro.org>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Alexandre Torgue <alexandre.torgue@foss.st.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>
Subject: Re: [PATCH v8 1/5] Coresight: Add support for new APB clock name
Date: Mon, 13 Jan 2025 11:33:37 +0000 [thread overview]
Message-ID: <7f342ebe-6c82-4ae6-b59d-399ec3018838@linaro.org> (raw)
In-Reply-To: <20241226011022.1477160-2-quic_jiegan@quicinc.com>
On 26/12/2024 1:10 am, Jie Gan wrote:
> Add support for new APB clock-name. If the function fails
> to obtain the clock with the name "apb_pclk", it will
> attempt to acquire the clock with the name "apb".
>
> Signed-off-by: Jie Gan <quic_jiegan@quicinc.com>
> ---
> include/linux/coresight.h | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/include/linux/coresight.h b/include/linux/coresight.h
> index 17276965ff1d..157c4bd009a1 100644
> --- a/include/linux/coresight.h
> +++ b/include/linux/coresight.h
> @@ -459,8 +459,11 @@ static inline struct clk *coresight_get_enable_apb_pclk(struct device *dev)
> int ret;
>
> pclk = clk_get(dev, "apb_pclk");
> - if (IS_ERR(pclk))
> - return NULL;
> + if (IS_ERR(pclk)) {
> + pclk = clk_get(dev, "apb");
> + if (IS_ERR(pclk))
> + return NULL;
> + }
>
> ret = clk_prepare_enable(pclk);
> if (ret) {
Reviewed-by: James Clark <james.clark@linaro.org>
next prev parent reply other threads:[~2025-01-13 11:33 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-26 1:10 [PATCH v8 0/5] Coresight: Add Coresight TMC Control Unit driver Jie Gan
2024-12-26 1:10 ` [PATCH v8 1/5] Coresight: Add support for new APB clock name Jie Gan
2025-01-13 11:33 ` James Clark [this message]
2024-12-26 1:10 ` [PATCH v8 2/5] Coresight: Add trace_id function to retrieving the trace ID Jie Gan
2025-01-13 12:02 ` James Clark
2025-01-14 2:51 ` Jie Gan
2025-01-14 10:07 ` James Clark
2025-01-15 1:44 ` Jie Gan
2025-01-15 12:29 ` James Clark
2025-01-16 3:01 ` Jie Gan
2025-01-16 10:17 ` James Clark
2025-01-17 2:31 ` Jie Gan
2025-01-23 6:28 ` Jie Gan
2025-01-23 9:47 ` James Clark
2025-01-23 10:03 ` Jie Gan
2024-12-26 1:10 ` [PATCH v8 3/5] dt-bindings: arm: Add Coresight TMC Control Unit hardware Jie Gan
2024-12-26 1:10 ` [PATCH v8 4/5] Coresight: Add Coresight TMC Control Unit driver Jie Gan
2025-01-13 12:05 ` James Clark
2025-01-14 1:50 ` Jie Gan
2024-12-26 1:10 ` [PATCH v8 5/5] arm64: dts: qcom: sa8775p: Add CTCU and ETR nodes Jie Gan
2025-01-09 7:22 ` [PATCH v8 0/5] Coresight: Add Coresight TMC Control Unit driver Jie Gan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7f342ebe-6c82-4ae6-b59d-399ec3018838@linaro.org \
--to=james.clark@linaro.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=alexandre.torgue@foss.st.com \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=coresight@lists.linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=mike.leach@linaro.org \
--cc=quic_jiegan@quicinc.com \
--cc=quic_jinlmao@quicinc.com \
--cc=quic_tingweiz@quicinc.com \
--cc=robh@kernel.org \
--cc=suzuki.poulose@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox