From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Jie Luo <quic_luoj@quicinc.com>,
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Cc: andersson@kernel.org, konrad.dybcio@linaro.org,
robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
conor+dt@kernel.org, linux-arm-msm@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org, quic_kkumarcs@quicinc.com,
quic_suruchia@quicinc.com, quic_soni@quicinc.com,
quic_pavir@quicinc.com, quic_souravp@quicinc.com,
quic_linchen@quicinc.com, quic_leiwei@quicinc.com
Subject: Re: [PATCH 1/6] arm64: dts: qcom: ipq9574: Add PPE device tree node
Date: Fri, 12 Jan 2024 15:51:36 +0100 [thread overview]
Message-ID: <84366aa2-e51e-4bce-a9d5-2420f1d9db0c@linaro.org> (raw)
In-Reply-To: <6fc9e65a-709a-4923-b0b3-7c460199417a@quicinc.com>
On 12/01/2024 15:40, Jie Luo wrote:
>>
>> From the first glance, the bindings do not follow upstream principles.
>> You have all the settings (tdm, port config, etc) in the DT, while
>> they should instead go to the driver. Well, unless you expect that the
>> board might need to override them.
>>
> Hi Dmitry,
> The TDM configuration varies per SoC type, since the ethernet port
> capabilities of the SoCs vary. So we will have two different TDM
> configurations for IPQ5332 and IPQ9574 SoC. The driver also will
> need to support future SoC, so we choose to configure this from the
> DTSI. The same reason applies to the port scheduler config as well.
Your statements here confirm Dmitry suggestion, so these are not board
specific and should go to the driver. Please read again Dmitry's sentences.
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-01-12 14:51 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-10 11:20 [PATCH 0/6] Add PPE device tree node for Qualcomm IPQ SoC Luo Jie
2024-01-10 11:20 ` [PATCH 1/6] arm64: dts: qcom: ipq9574: Add PPE device tree node Luo Jie
2024-01-10 11:40 ` Krzysztof Kozlowski
2024-01-11 15:30 ` Jie Luo
2024-01-11 16:06 ` Dmitry Baryshkov
2024-01-12 14:40 ` Jie Luo
2024-01-12 14:51 ` Krzysztof Kozlowski [this message]
2024-01-22 12:58 ` Jie Luo
2024-01-12 15:03 ` Dmitry Baryshkov
2024-01-17 15:10 ` Jie Luo
2024-01-10 11:20 ` [PATCH 2/6] arm64: dts: qcom: ipq5332: " Luo Jie
2024-01-10 11:20 ` [PATCH 3/6] arm64: dts: qcom: ipq5332: Add MDIO device tree Luo Jie
2024-01-10 11:56 ` Krzysztof Kozlowski
2024-01-12 16:11 ` Jie Luo
2024-01-10 13:35 ` Andrew Lunn
2024-01-11 15:59 ` Jie Luo
2024-01-11 16:13 ` Dmitry Baryshkov
2024-01-12 15:58 ` Jie Luo
2024-01-11 16:30 ` Andrew Lunn
2024-01-12 16:05 ` Jie Luo
2024-01-16 22:56 ` Andrew Lunn
2024-01-17 15:10 ` Jie Luo
2024-01-11 16:43 ` Krzysztof Kozlowski
2024-01-10 11:20 ` [PATCH 4/6] arm64: dts: qcom: ipq9574: " Luo Jie
2024-01-10 11:20 ` [PATCH 5/6] arm64: dts: qcom: ipq5332: Add RDP441 board " Luo Jie
2024-01-10 11:57 ` Krzysztof Kozlowski
2024-01-17 15:16 ` Lei Wei
2024-01-10 11:20 ` [PATCH 6/6] arm64: dts: qcom: ipq9574: Add RDP433 " Luo Jie
2024-01-12 15:05 ` Dmitry Baryshkov
2024-01-17 15:12 ` Lei Wei
2024-01-10 11:32 ` [PATCH 0/6] Add PPE device tree node for Qualcomm IPQ SoC Konrad Dybcio
2024-01-12 14:55 ` Jie Luo
2024-01-10 12:13 ` Krzysztof Kozlowski
2024-01-12 15:00 ` Jie Luo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=84366aa2-e51e-4bce-a9d5-2420f1d9db0c@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=quic_kkumarcs@quicinc.com \
--cc=quic_leiwei@quicinc.com \
--cc=quic_linchen@quicinc.com \
--cc=quic_luoj@quicinc.com \
--cc=quic_pavir@quicinc.com \
--cc=quic_soni@quicinc.com \
--cc=quic_souravp@quicinc.com \
--cc=quic_suruchia@quicinc.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox