Linux ARM-MSM sub-architecture
 help / color / mirror / Atom feed
From: Jie Luo <quic_luoj@quicinc.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: <andersson@kernel.org>, <konrad.dybcio@linaro.org>,
	<robh+dt@kernel.org>, <krzysztof.kozlowski+dt@linaro.org>,
	<conor+dt@kernel.org>, <linux-arm-msm@vger.kernel.org>,
	<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<netdev@vger.kernel.org>, <quic_kkumarcs@quicinc.com>,
	<quic_suruchia@quicinc.com>, <quic_soni@quicinc.com>,
	<quic_pavir@quicinc.com>, <quic_souravp@quicinc.com>,
	<quic_linchen@quicinc.com>, <quic_leiwei@quicinc.com>
Subject: Re: [PATCH 3/6] arm64: dts: qcom: ipq5332: Add MDIO device tree
Date: Wed, 17 Jan 2024 23:10:07 +0800	[thread overview]
Message-ID: <efe398ff-825b-4959-bcfc-ff0870d1932b@quicinc.com> (raw)
In-Reply-To: <6975e79a-67eb-46d7-8445-92610b8b5198@lunn.ch>



On 1/17/2024 6:56 AM, Andrew Lunn wrote:
>> Another one is the MDIO slave(gpio25, 26), which is dedicated
>> for receiving the back pressure signal from the connected Ethernet switch
>> device QCA8386.
>>
>> There is a MDIO master block integrated in QCA8386 switch device, this
>> integrated MDIO master is dedicated for generating the back
>> pressure signal to IPQ5332 SoC.
>>
>> This MDIO slave block of IPQ5322 just needs to configure these PIN
>> mux for MDC and MDIO PINs. No additional driver is needed for this MDIO
>> slave block of IPQ5332.
> 
> So there is a proprietary protocol running over the MDIO bus? And its
> completely implemented in hardware in the slave block? Is this even
> MDIO? Does it use c22 or c45 bus transactions? How is the slave
> address configured, or is that also hard coded?
> 
> 	Andrew
> 

Hi Andrew,
Yes, this is a custom HW mechanism using the MDIO C22 frame, to enable 
back pressure from the QCA8386 switch to the IPQ5332 SoC. The slave 
block in the IPQ5332 SoC implements the back pressure function. There is 
no configuration for the MDIO slave address of IPQ5332 required, since 
the connection is one to one between slave and master.

However upon further review, we believe this node definition belongs to
the board DTS file, since the switch configuration is a board property.
We will move out this MDIO slave config from the patch series to
avoid the confusion. We will also rename the node from 'mdio0-state' to 
'backpressure-state' to make this clear.

Thanks.

  reply	other threads:[~2024-01-17 15:10 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-10 11:20 [PATCH 0/6] Add PPE device tree node for Qualcomm IPQ SoC Luo Jie
2024-01-10 11:20 ` [PATCH 1/6] arm64: dts: qcom: ipq9574: Add PPE device tree node Luo Jie
2024-01-10 11:40   ` Krzysztof Kozlowski
2024-01-11 15:30     ` Jie Luo
2024-01-11 16:06       ` Dmitry Baryshkov
2024-01-12 14:40         ` Jie Luo
2024-01-12 14:51           ` Krzysztof Kozlowski
2024-01-22 12:58             ` Jie Luo
2024-01-12 15:03           ` Dmitry Baryshkov
2024-01-17 15:10             ` Jie Luo
2024-01-10 11:20 ` [PATCH 2/6] arm64: dts: qcom: ipq5332: " Luo Jie
2024-01-10 11:20 ` [PATCH 3/6] arm64: dts: qcom: ipq5332: Add MDIO device tree Luo Jie
2024-01-10 11:56   ` Krzysztof Kozlowski
2024-01-12 16:11     ` Jie Luo
2024-01-10 13:35   ` Andrew Lunn
2024-01-11 15:59     ` Jie Luo
2024-01-11 16:13       ` Dmitry Baryshkov
2024-01-12 15:58         ` Jie Luo
2024-01-11 16:30       ` Andrew Lunn
2024-01-12 16:05         ` Jie Luo
2024-01-16 22:56           ` Andrew Lunn
2024-01-17 15:10             ` Jie Luo [this message]
2024-01-11 16:43       ` Krzysztof Kozlowski
2024-01-10 11:20 ` [PATCH 4/6] arm64: dts: qcom: ipq9574: " Luo Jie
2024-01-10 11:20 ` [PATCH 5/6] arm64: dts: qcom: ipq5332: Add RDP441 board " Luo Jie
2024-01-10 11:57   ` Krzysztof Kozlowski
2024-01-17 15:16     ` Lei Wei
2024-01-10 11:20 ` [PATCH 6/6] arm64: dts: qcom: ipq9574: Add RDP433 " Luo Jie
2024-01-12 15:05   ` Dmitry Baryshkov
2024-01-17 15:12     ` Lei Wei
2024-01-10 11:32 ` [PATCH 0/6] Add PPE device tree node for Qualcomm IPQ SoC Konrad Dybcio
2024-01-12 14:55   ` Jie Luo
2024-01-10 12:13 ` Krzysztof Kozlowski
2024-01-12 15:00   ` Jie Luo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=efe398ff-825b-4959-bcfc-ff0870d1932b@quicinc.com \
    --to=quic_luoj@quicinc.com \
    --cc=andersson@kernel.org \
    --cc=andrew@lunn.ch \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=konrad.dybcio@linaro.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=quic_kkumarcs@quicinc.com \
    --cc=quic_leiwei@quicinc.com \
    --cc=quic_linchen@quicinc.com \
    --cc=quic_pavir@quicinc.com \
    --cc=quic_soni@quicinc.com \
    --cc=quic_souravp@quicinc.com \
    --cc=quic_suruchia@quicinc.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox