Linux ARM-MSM sub-architecture
 help / color / mirror / Atom feed
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Md Sadre Alam <quic_mdalam@quicinc.com>,
	 broonie@kernel.org, robh@kernel.org,  krzk+dt@kernel.org,
	 conor+dt@kernel.org, richard@nod.at,  vigneshr@ti.com,
	 linux-arm-msm@vger.kernel.org, linux-spi@vger.kernel.org,
	 devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	 linux-mtd@lists.infradead.org
Subject: Re: [PATCH v15 2/2] spi: spi-qpic: add driver for QCOM SPI NAND flash Interface
Date: Wed, 26 Mar 2025 15:49:37 +0100	[thread overview]
Message-ID: <874izfrgn2.fsf@bootlin.com> (raw)
In-Reply-To: <CAMuHMdUOt8PxbRt-vGfeD5=uEtMVV0TLPUridu=nCkzX9iP24Q@mail.gmail.com> (Geert Uytterhoeven's message of "Wed, 26 Mar 2025 15:24:03 +0100")


>> Change in [v11]
>>
>> * Changed "depends on MTD" to "select MTD" in
>>   drivers/spi/Kconfig file
>
> Why? This is the only driver that selects MTD instead of depending on it.
>
>> Change in [v7]
>>
>> * Made CONFIG_SPI_QPIC_SNAND as bool
>
> Why? The driver uses MODULE_*, so a janitor may remove the latter.

Good catch, I agree on both comments.

Thanks,
Miquèl

  reply	other threads:[~2025-03-26 14:49 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-24 11:14 [PATCH v15 0/2] Add QPIC SPI NAND driver Md Sadre Alam
2025-02-24 11:14 ` [PATCH v15 1/2] spi: dt-bindings: Introduce qcom,spi-qpic-snand Md Sadre Alam
2025-02-24 11:14 ` [PATCH v15 2/2] spi: spi-qpic: add driver for QCOM SPI NAND flash Interface Md Sadre Alam
2025-03-26 14:24   ` Geert Uytterhoeven
2025-03-26 14:49     ` Miquel Raynal [this message]
2025-03-04 12:34 ` [PATCH v15 0/2] Add QPIC SPI NAND driver Mark Brown
2025-03-05 11:25   ` Md Sadre Alam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=874izfrgn2.fsf@bootlin.com \
    --to=miquel.raynal@bootlin.com \
    --cc=broonie@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=geert@linux-m68k.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=linux-spi@vger.kernel.org \
    --cc=quic_mdalam@quicinc.com \
    --cc=richard@nod.at \
    --cc=robh@kernel.org \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox