From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: Paul Sajna <sajattack@postmarketos.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
David Heidelberg <david@ixit.cz>
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, phone-devel@vger.kernel.org,
Amir Dahan <system64fumo@protonmail.com>,
Christopher Brown <crispybrown@gmail.com>
Subject: Re: [PATCH v4 09/12] arm64: dts: qcom: sdm845-lg-common: Add camera flash
Date: Fri, 5 Dec 2025 11:32:30 +0100 [thread overview]
Message-ID: <8ab2b4ea-6148-41e7-b700-559d34817a44@oss.qualcomm.com> (raw)
In-Reply-To: <2b03a898bf57cc87b78e3a90b210ed3d3f832efb@postmarketos.org>
On 12/4/25 7:37 PM, Paul Sajna wrote:
> December 4, 2025 at 9:17 AM, "Konrad Dybcio" <konrad.dybcio@oss.qualcomm.com mailto:konrad.dybcio@oss.qualcomm.com?to=%22Konrad%20Dybcio%22%20%3Ckonrad.dybcio%40oss.qualcomm.com%3E > wrote:
>
>> led-sources is parsed into a bitmap and written into REG_MODULE_EN,
>> this doesn't translate into anything that's userspace-visible
>>
>> That would instead be the case if you defined a pair of LEDs under
>> the device node (which is valid if there's two separate ones, such
>> as for some phones with a back and front LED flash)
>>
>> Konrad
>>
>
> so it should be led-sources = <1 2> or something? Under a single node?
Eh of course what I said is wrong, it does indeed parse it, but in the
end it's a !!mask (if any enabled, enable the module)
but for your purposes, try "led-sources = <0>, <1>;" under a single node
that you have right now - the count also matters and it may just resolve
the presumably-overcurrent issue
Konrad
next prev parent reply other threads:[~2025-12-05 10:32 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-25 8:12 [PATCH v4 00/12] arm64: dts: qcom: sdm845-lg-{common, judyln}: Improve HW support in dts Paul Sajna
2025-11-25 8:12 ` [PATCH v4 01/12] arm64: dts: qcom: sdm845-lg-common: Sort nodes and properties Paul Sajna
2025-11-25 8:12 ` [PATCH v4 02/12] arm64: dts: qcom: sdm845-lg-common: Add uarts and Bluetooth Paul Sajna
2025-11-25 8:12 ` [PATCH v4 03/12] arm64: dts: qcom: sdm845-lg-judyln: Add battery and charger Paul Sajna
2025-11-28 11:13 ` Konrad Dybcio
2025-11-25 8:12 ` [PATCH v4 04/12] arm64: dts: qcom: sdm845-lg-common: Add LEDs Paul Sajna
2025-11-28 11:14 ` Konrad Dybcio
2025-11-25 8:12 ` [PATCH v4 05/12] arm64: dts: qcom: sdm845-lg-judyln: Add display panel Paul Sajna
2025-12-01 12:44 ` Konrad Dybcio
2025-11-25 8:12 ` [PATCH v4 06/12] arm64: dts: qcom: sdm845-lg-judyln: Add firmware nodes, change path Paul Sajna
2025-11-25 9:29 ` David Heidelberg
2025-11-25 8:12 ` [PATCH v4 07/12] arm64: dts: qcom: sdm845-lg-{common, judyln}: Add wifi node Paul Sajna
2025-11-28 11:15 ` Konrad Dybcio
2025-11-25 8:12 ` [PATCH v4 08/12] arm64: dts: qcom: sdm845-lg-common: Add chassis-type Paul Sajna
2025-11-25 8:12 ` [PATCH v4 09/12] arm64: dts: qcom: sdm845-lg-common: Add camera flash Paul Sajna
2025-11-28 20:20 ` Paul Sajna
2025-12-01 11:42 ` Konrad Dybcio
2025-12-03 9:27 ` Paul Sajna
2025-12-04 9:17 ` Konrad Dybcio
2025-12-04 18:37 ` Paul Sajna
2025-12-05 10:32 ` Konrad Dybcio [this message]
2025-11-25 8:12 ` [PATCH v4 10/12] arm64: dts: qcom: sdm845-lg-judyln: Add lab/ibb Paul Sajna
2025-12-01 12:38 ` Konrad Dybcio
2025-12-02 4:21 ` Paul Sajna
2025-12-02 10:34 ` Konrad Dybcio
2025-11-25 8:12 ` [PATCH v4 11/12] arm64: dts: qcom: sdm845-lg-common: Change ipa gsi-loader to 'self' Paul Sajna
2025-11-25 8:12 ` [PATCH v4 12/12] arm64: dts: qcom: sdm845-lg-common: remove framebuffer reserved-mem Paul Sajna
2025-12-01 12:41 ` Konrad Dybcio
2025-12-02 4:41 ` Paul Sajna
2025-12-02 10:34 ` Konrad Dybcio
2025-12-03 8:42 ` Paul Sajna
2025-12-03 10:37 ` David Heidelberg
2025-12-03 10:45 ` David Heidelberg
2025-12-03 10:55 ` Konrad Dybcio
2025-11-25 18:09 ` [PATCH v4 00/12] arm64: dts: qcom: sdm845-lg-{common, judyln}: Improve HW support in dts Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8ab2b4ea-6148-41e7-b700-559d34817a44@oss.qualcomm.com \
--to=konrad.dybcio@oss.qualcomm.com \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=crispybrown@gmail.com \
--cc=david@ixit.cz \
--cc=devicetree@vger.kernel.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=phone-devel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sajattack@postmarketos.org \
--cc=system64fumo@protonmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox