Re: [PATCH v4 06/12] arm64: dts: qcom: sdm845-lg-judyln: Add firmware nodes, change path

[David Heidelberg <david@ixit.cz>]

On 25/11/2025 09:12, Paul Sajna wrote:
> Add paths for Qualcomm firmware, including:
> ipa, modem, bluetooth, venus, gpu
> 
> Enable adsp and cdsp nodes since their firmware is present
> 
> GPU and bluetooth are confirmed working, others may need more
> testing/fixes
> 
> But regardless they will need the firmware paths specified here
> and firmware added upstream before they will work, so might as well
> get started on it now.
> 
> Signed-off-by: Paul Sajna <sajattack@postmarketos.org>
> ---
>   arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi | 10 ++++++++++
>   arch/arm64/boot/dts/qcom/sdm845-lg-judyln.dts  | 23 ++++++++++++++++++-----
>   2 files changed, 28 insertions(+), 5 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi b/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi
> index 50921af83a51..315fdc5dc392 100644
> --- a/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi
> @@ -162,6 +162,10 @@ &adsp_pas {
>   	status = "okay";
>   };
>   
> +&cdsp_pas {
> +	status = "okay";
> +};
> +
>   &apps_rsc {
>   	regulators-0 {
>   		compatible = "qcom,pm8998-rpmh-regulators";
> @@ -464,6 +468,8 @@ &gpu {
>   
>   &ipa {
>   	qcom,gsi-loader = "modem";
> +	memory-region = <&ipa_fw_mem>;
> +
>   	status = "okay";
>   };
>   
> @@ -663,3 +669,7 @@ &wifi {
>   
>   	qcom,snoc-host-cap-skip-quirk;
>   };
> +
> +&venus {
> +	status = "okay";
> +};
> diff --git a/arch/arm64/boot/dts/qcom/sdm845-lg-judyln.dts b/arch/arm64/boot/dts/qcom/sdm845-lg-judyln.dts
> index 8e4214b83bf1..9ec2edf6134c 100644
> --- a/arch/arm64/boot/dts/qcom/sdm845-lg-judyln.dts
> +++ b/arch/arm64/boot/dts/qcom/sdm845-lg-judyln.dts
> @@ -35,7 +35,7 @@ battery: battery {
>   };
>   
>   &adsp_pas {
> -	firmware-name = "qcom/sdm845/judyln/adsp.mbn";
> +	firmware-name = "qcom/sdm845/lg/judyln/adsp.mbn";
>   };
>   
>   &bluetooth {
> @@ -47,11 +47,17 @@ &bluetooth {
>   };
>   
>   &cdsp_pas {
> -	firmware-name = "qcom/sdm845/judyln/cdsp.mbn";
> +	firmware-name = "qcom/sdm845/lg/judyln/cdsp.mbn";
>   };
>   
> -&gpu_zap_shader {
> -	firmware-name = "qcom/sdm845/judyln/a630_zap.mbn";
> +&gpu {
> +	zap-shader {
> +		firmware-name = "qcom/sdm845/lg/judyln/a630_zap.mbn";
> +	};
> +};
> +
> +&ipa {
> +	firmware-name = "qcom/sdm845/lg/judyln/ipa_fws.mbn";
>   };
>   
>   &mdss {
> @@ -96,7 +102,7 @@ &mdss_dsi0_out {
>   };
>   
>   &mss_pil {
> -	firmware-name = "qcom/sdm845/judyln/mba.mbn", "qcom/sdm845/judyln/modem.mbn";
> +	firmware-name = "qcom/sdm845/lg/judyln/mba.mbn", "qcom/sdm845/lg/judyln/modem.mbn";
>   };
>   
>   &pmi8998_charger {
> @@ -135,3 +141,10 @@ sde_te_active_sleep: sde-te-active-sleep-state {
>   		bias-pull-down;
>   	};
>   };
> +<<<<<<< HEAD
> +=======
> +
> +&venus {
> +	firmware-name = "qcom/sdm845/lg/judyln/venus.mbn";
> +};
> +>>>>>>> d58184825fa5 (arm64: dts: qcom: sdm845-lg-judyln: Add firmware nodes, change path)

Accidental rebase leftovers, please remove in this patch.

I see it been removed in followup patch, but it's always best walk 
trough your patches one by one before sending.

David

P.S. Happy to see the quirk is useful.
> 

-- 
David Heidelberg