* [PATCH] media: venus: core: Set up secure memory ranges for SC7180
@ 2023-06-15 23:36 Konrad Dybcio
2023-06-16 5:31 ` Nikita Travkin
2023-07-10 7:03 ` Vikash Garodia
0 siblings, 2 replies; 3+ messages in thread
From: Konrad Dybcio @ 2023-06-15 23:36 UTC (permalink / raw)
To: Stanimir Varbanov, Vikash Garodia, Bryan O'Donoghue,
Andy Gross, Bjorn Andersson, Mauro Carvalho Chehab
Cc: Marijn Suijten, Nikita Travkin, linux-media, linux-arm-msm,
linux-kernel, Konrad Dybcio
Not all SC7180 devices ship with ChromeOS firmware. WoA devices use
Android-like TZ, which uses PAS for image authentication. That requires
the predefined virtual address ranges to be passed via scm calls.
Define them to enable Venus on non-CrOS SC7180 devices.
Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
---
drivers/media/platform/qcom/venus/core.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/media/platform/qcom/venus/core.c b/drivers/media/platform/qcom/venus/core.c
index 2ae867cb4c48..bee1b4c98060 100644
--- a/drivers/media/platform/qcom/venus/core.c
+++ b/drivers/media/platform/qcom/venus/core.c
@@ -760,6 +760,10 @@ static const struct venus_resources sc7180_res = {
.vmem_size = 0,
.vmem_addr = 0,
.dma_mask = 0xe0000000 - 1,
+ .cp_start = 0,
+ .cp_size = 0x70800000,
+ .cp_nonpixel_start = 0x1000000,
+ .cp_nonpixel_size = 0x24800000,
.fwname = "qcom/venus-5.4/venus.mdt",
};
---
base-commit: 925294c9aa184801cc0a451b69a18dd0fe7d847d
change-id: 20230616-topic-sc7180_venus_lawp-965e5fd18c7a
Best regards,
--
Konrad Dybcio <konrad.dybcio@linaro.org>
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] media: venus: core: Set up secure memory ranges for SC7180
2023-06-15 23:36 [PATCH] media: venus: core: Set up secure memory ranges for SC7180 Konrad Dybcio
@ 2023-06-16 5:31 ` Nikita Travkin
2023-07-10 7:03 ` Vikash Garodia
1 sibling, 0 replies; 3+ messages in thread
From: Nikita Travkin @ 2023-06-16 5:31 UTC (permalink / raw)
To: Konrad Dybcio
Cc: Stanimir Varbanov, Vikash Garodia, Bryan O'Donoghue,
Andy Gross, Bjorn Andersson, Mauro Carvalho Chehab,
Marijn Suijten, linux-media, linux-arm-msm, linux-kernel
Konrad Dybcio писал(а) 16.06.2023 04:36:
> Not all SC7180 devices ship with ChromeOS firmware. WoA devices use
> Android-like TZ, which uses PAS for image authentication. That requires
> the predefined virtual address ranges to be passed via scm calls.
> Define them to enable Venus on non-CrOS SC7180 devices.
>
> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
This does indeed bring up the venus for me now. Thanks!
Tested-by: Nikita Travkin <nikita@trvn.ru> # Aspire 1
> ---
> drivers/media/platform/qcom/venus/core.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/media/platform/qcom/venus/core.c b/drivers/media/platform/qcom/venus/core.c
> index 2ae867cb4c48..bee1b4c98060 100644
> --- a/drivers/media/platform/qcom/venus/core.c
> +++ b/drivers/media/platform/qcom/venus/core.c
> @@ -760,6 +760,10 @@ static const struct venus_resources sc7180_res = {
> .vmem_size = 0,
> .vmem_addr = 0,
> .dma_mask = 0xe0000000 - 1,
> + .cp_start = 0,
> + .cp_size = 0x70800000,
> + .cp_nonpixel_start = 0x1000000,
> + .cp_nonpixel_size = 0x24800000,
> .fwname = "qcom/venus-5.4/venus.mdt",
> };
>
>
> ---
> base-commit: 925294c9aa184801cc0a451b69a18dd0fe7d847d
> change-id: 20230616-topic-sc7180_venus_lawp-965e5fd18c7a
>
> Best regards,
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] media: venus: core: Set up secure memory ranges for SC7180
2023-06-15 23:36 [PATCH] media: venus: core: Set up secure memory ranges for SC7180 Konrad Dybcio
2023-06-16 5:31 ` Nikita Travkin
@ 2023-07-10 7:03 ` Vikash Garodia
1 sibling, 0 replies; 3+ messages in thread
From: Vikash Garodia @ 2023-07-10 7:03 UTC (permalink / raw)
To: Konrad Dybcio, Stanimir Varbanov, Bryan O'Donoghue,
Andy Gross, Bjorn Andersson, Mauro Carvalho Chehab
Cc: Marijn Suijten, Nikita Travkin, linux-media, linux-arm-msm,
linux-kernel
On 6/16/2023 5:06 AM, Konrad Dybcio wrote:
> Not all SC7180 devices ship with ChromeOS firmware. WoA devices use
> Android-like TZ, which uses PAS for image authentication. That requires
> the predefined virtual address ranges to be passed via scm calls.
> Define them to enable Venus on non-CrOS SC7180 devices.
>
> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Reviewed-by: Vikash Garodia <quic_vgarodia@quicinc.com>
> ---
> drivers/media/platform/qcom/venus/core.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/media/platform/qcom/venus/core.c b/drivers/media/platform/qcom/venus/core.c
> index 2ae867cb4c48..bee1b4c98060 100644
> --- a/drivers/media/platform/qcom/venus/core.c
> +++ b/drivers/media/platform/qcom/venus/core.c
> @@ -760,6 +760,10 @@ static const struct venus_resources sc7180_res = {
> .vmem_size = 0,
> .vmem_addr = 0,
> .dma_mask = 0xe0000000 - 1,
> + .cp_start = 0,
> + .cp_size = 0x70800000,
> + .cp_nonpixel_start = 0x1000000,
> + .cp_nonpixel_size = 0x24800000,
> .fwname = "qcom/venus-5.4/venus.mdt",
> };
>
>
> ---
> base-commit: 925294c9aa184801cc0a451b69a18dd0fe7d847d
> change-id: 20230616-topic-sc7180_venus_lawp-965e5fd18c7a
>
> Best regards,
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-07-10 7:04 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-06-15 23:36 [PATCH] media: venus: core: Set up secure memory ranges for SC7180 Konrad Dybcio
2023-06-16 5:31 ` Nikita Travkin
2023-07-10 7:03 ` Vikash Garodia
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox