Re: [PATCH] clk: qcom: camcc-sc8280xp: Remove always-on GDSC hard-coding

["Satya Priya Kakitapalli (Temp)" <quic_skakitap@quicinc.com>]

On 7/23/2024 2:59 PM, Bryan O'Donoghue wrote:
> On 22/07/2024 09:57, Satya Priya Kakitapalli (Temp) wrote:
>>> I have no idea. Why does it matter ?
>>>
>>
>> This clock expected to be kept always ON, as per design, or else the 
>> GDSC transition form ON to OFF (vice versa) wont work.
>
> Yes, parking to XO per this patch works for me. So I guess its already 
> on and is left in that state by the park.
>

Parking RCG to XO doesn't keep the branch clock always-on. It just keeps 
the parent RCG at 19.2MHz, branch can still be disabled by clearing 
bit(0). So during late init, the CCF will disable this clock(in 
clk_disable_unused API) if modelled. Hence this clock shouldn't be modelled.


>> Want to know the clock status after bootup, to understand if the 
>> clock got turned off during the late init. May I know exactly what 
>> you have tested? Did you test the camera usecases as well?
>
> Of course.
>
> The camera works on x13s with this patch. That's what I mean by tested.
>
> ---
> bod