From: "Satya Priya Kakitapalli (Temp)" <quic_skakitap@quicinc.com>
To: Bryan O'Donoghue <bryan.odonoghue@linaro.org>,
Bjorn Andersson <andersson@kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>
Cc: <dmitry.baryshkov@linaro.org>, <stable@vger.kernel.org>,
<linux-arm-msm@vger.kernel.org>, <linux-clk@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] clk: qcom: camcc-sc8280xp: Remove always-on GDSC hard-coding
Date: Fri, 26 Jul 2024 12:31:16 +0530 [thread overview]
Message-ID: <fe44268d-76bb-bdbd-e54e-39a38e4e5a49@quicinc.com> (raw)
In-Reply-To: <a0ac4c3b-3c46-4c89-9947-d91ba06309f4@linaro.org>
On 7/23/2024 2:59 PM, Bryan O'Donoghue wrote:
> On 22/07/2024 09:57, Satya Priya Kakitapalli (Temp) wrote:
>>> I have no idea. Why does it matter ?
>>>
>>
>> This clock expected to be kept always ON, as per design, or else the
>> GDSC transition form ON to OFF (vice versa) wont work.
>
> Yes, parking to XO per this patch works for me. So I guess its already
> on and is left in that state by the park.
>
>> Want to know the clock status after bootup, to understand if the
>> clock got turned off during the late init. May I know exactly what
>> you have tested? Did you test the camera usecases as well?
>
> Of course.
>
> The camera works on x13s with this patch. That's what I mean by tested.
>
It might be working in your case, but it is not the HW design
recommended way to do. The same should not be propagated to other
target's camcc drivers, as I already observed it is not working on SM8150.
> ---
> bod
next prev parent reply other threads:[~2024-07-26 7:01 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-15 14:59 [PATCH] clk: qcom: camcc-sc8280xp: Remove always-on GDSC hard-coding Bryan O'Donoghue
2024-07-17 6:32 ` Satya Priya Kakitapalli (Temp)
2024-07-17 8:49 ` Bryan O'Donoghue
2024-07-17 11:08 ` Satya Priya Kakitapalli (Temp)
2024-07-17 11:11 ` Bryan O'Donoghue
2024-07-19 7:25 ` Satya Priya Kakitapalli (Temp)
2024-07-20 8:33 ` Bryan O'Donoghue
2024-07-22 8:57 ` Satya Priya Kakitapalli (Temp)
2024-07-23 9:29 ` Bryan O'Donoghue
2024-07-23 11:37 ` Satya Priya Kakitapalli (Temp)
2024-07-23 11:49 ` Dmitry Baryshkov
2024-07-26 7:01 ` Satya Priya Kakitapalli (Temp) [this message]
2024-07-26 20:31 ` Bryan O'Donoghue
2024-07-29 10:57 ` Satya Priya Kakitapalli (Temp)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fe44268d-76bb-bdbd-e54e-39a38e4e5a49@quicinc.com \
--to=quic_skakitap@quicinc.com \
--cc=andersson@kernel.org \
--cc=bryan.odonoghue@linaro.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=sboyd@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox