Re: [PATCH v2 2/2] arm64: dts: qcom: Enable secondary USB controller on QCS615 Ride

[Song Xue <quic_songxue@quicinc.com>]

On 12/13/2024 4:12 PM, Dmitry Baryshkov wrote:
> On Fri, 13 Dec 2024 at 08:59, Song Xue <quic_songxue@quicinc.com> wrote:
>>
>>
>>
>> On 12/13/2024 2:14 AM, Konrad Dybcio wrote:
>>> On 11.12.2024 9:26 AM, Song Xue wrote:
>>>> From: Krishna Kurapati <krishna.kurapati@oss.qualcomm.com>
>>>>
>>>> Enable secondary USB controller on QCS615 Ride platform. The secondary
>>>> USB controller is made "host", as it is a Type-A port.
>>>>
>>>> Signed-off-by: Krishna Kurapati <krishna.kurapati@oss.qualcomm.com>
>>>> Co-developed-by: Song Xue <quic_songxue@quicinc.com>
>>>> Signed-off-by: Song Xue <quic_songxue@quicinc.com>
>>>> ---
>>>>    arch/arm64/boot/dts/qcom/qcs615-ride.dts | 28 ++++++++++++++++++++++++++++
>>>>    1 file changed, 28 insertions(+)
>>>>
>>>> diff --git a/arch/arm64/boot/dts/qcom/qcs615-ride.dts b/arch/arm64/boot/dts/qcom/qcs615-ride.dts
>>>> index f41319ff47b983d771da52775fa78b4385c4e532..26ce0496d13ccbfea392c6d50d9edcab85fbc653 100644
>>>> --- a/arch/arm64/boot/dts/qcom/qcs615-ride.dts
>>>> +++ b/arch/arm64/boot/dts/qcom/qcs615-ride.dts
>>>> @@ -203,6 +203,15 @@ &gcc {
>>>>                <&sleep_clk>;
>>>>    };
>>>>
>>>> +&pm8150_gpios {
>>>> +    usb2_en_state: usb2-en-state {
>>>> +            pins = "gpio10";
>>>> +            function = "normal";
>>>> +            output-high;
>>>> +            power-source = <0>;
>>>> +    };
>>>
>>> Does this go to an enable pin of a vreg / switch?
>>
>> Thanks for comment.
>> We go to enable the pin of PMIC chip. The pin of PMIC is connecting to
>> host-enable pin of USB converter. Need pin of PMIC chip to be high
>> level, when USB is as host mode.
> 
> What kind of USB converter are we talking about?

It is like USB charging controller and Power Switch.

Thanks
Song
> 
>>>
>>> I think we settled on describing such cases as fixed regulators
>>> (that are always-on for now) - would you remember, +Dmitry?
>>>
>>> The rest looks good.
>>>
>>> Konrad
>>
> 
>