Re: [Freedreno] [PATCH] Revert "drm/msm/dp: Remove INIT_SETUP delay"

[Abhinav Kumar <quic_abhinavk@quicinc.com>]

Hi Leonard

On 5/24/2023 5:58 AM, Leonard Lausen wrote:
>>>>>>> [  275.025497] [drm:dpu_encoder_phys_vid_wait_for_commit_done:488]
>>>>>>> [dpu error]vblank timeout
>>>>>>> [  275.025514] [drm:dpu_kms_wait_for_commit_done:510] [dpu error]wait
>>>>>>> for commit done returned -110
>>>>>>> [  275.064141] [drm:dpu_encoder_frame_done_timeout:2382] [dpu
>>>>>>> error]enc33 frame done timeout
>>>>>
>>>>> This is a different crash but the root-cause of both the issues is the
>>>>> bridge hpd_enable/disable series.
>>>>>
>>>>> https://patchwork.freedesktop.org/patch/514414/
>>>
>>> Yes, the new patch to fix this issue is here
>>>
>>> https://patchwork.freedesktop.org/patch/538601/?series=118148&rev=3
>>>
>>> Apologies if you were not CCed on this, if a next version is CCed,
>>> will ask kuogee to cc you.
>>>
>>> Meanwhile, will be great if you can verify if it works for you and
>>> provide Tested-by tags.
>>
>> Hi Leonard,
>>
>> I had  cc you with v5 patches.
>>
>> Would you please verify it.
> 
> Hi Kuogee,
> 
> thank you. Verified the v6 patch fixes the regression when ported to
> 6.3.3. One non-fatal issue remains: Suspending and resuming the system
> while USB-C DP monitor is connected triggers an error, though the system
> recovers within a second without the need to unplug the cable.
> 
> [drm:drm_mode_config_helper_resume] *ERROR* Failed to resume (-107)
> 

We are not able to recreate this on sc7280 chromebooks , will need to 
check on sc7180. This does not seem directly related to any of the 
hotplug changes though so needs to be checked separately. So please feel 
free to raise a gitlab bug for this and assign to me.