Linux ARM-MSM sub-architecture
 help / color / mirror / Atom feed
From: "Leonard Lausen" <leonard@lausen.nl>
To: regressions@lists.linux.dev,
	"Bjorn Andersson" <quic_bjorande@quicinc.com>,
	"Dmitry Baryshkov" <dmitry.baryshkov@linaro.org>,
	"Rob Clark" <robdclark@gmail.com>,
	"Abhinav Kumar" <quic_abhinavk@quicinc.com>,
	"Stephen Boyd" <swboyd@chromium.org>,
	"Kuogee Hsieh" <quic_khsieh@quicinc.com>,
	"Johan Hovold" <johan+linaro@kernel.org>,
	"Sankeerth Billakanti" <quic_sbillaka@quicinc.com>
Cc: "Sean Paul" <sean@poorly.run>, "David Airlie" <airlied@gmail.com>,
	"Daniel Vetter" <daniel@ffwll.ch>,
	linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org,
	freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org,
	"Nikita Travkin" <nikita@trvn.ru>
Subject: [PATCH] Revert "drm/msm/dp: Remove INIT_SETUP delay"
Date: Mon, 08 May 2023 01:06:13 +0000	[thread overview]
Message-ID: <ebbcd56ac883d3c3d3024d368fab63d26e02637a@lausen.nl> (raw)

This reverts commit e17af1c9d861dc177e5b56009bd4f71ace688d97.

Removing the delay of 100 units broke hot plug detection for USB-C displays on
qcom sc7180 lazor devices. Lazor uses mdss for hot plug detection and declares
dp_hot_plug_det in the dts. Other sc7180 based devices like aspire1 were not
affected by the regression, as they do not rely on mdss and dp_hot_plug_det for
hot plug detection.

Signed-off-by: Leonard Lausen <leonard@lausen.nl>
Tested-by: Leonard Lausen <leonard@lausen.nl> # Trogdor (sc7180)
Suggested-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>

---
 drivers/gpu/drm/msm/dp/dp_display.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/msm/dp/dp_display.c b/drivers/gpu/drm/msm/dp/dp_display.c
index bde1a7ce442f..db9783ffd5cf 100644
--- a/drivers/gpu/drm/msm/dp/dp_display.c
+++ b/drivers/gpu/drm/msm/dp/dp_display.c
@@ -1506,7 +1506,7 @@ void msm_dp_irq_postinstall(struct msm_dp *dp_display)
        dp = container_of(dp_display, struct dp_display_private, dp_display);
 
        if (!dp_display->is_edp)
-               dp_add_event(dp, EV_HPD_INIT_SETUP, 0, 0);
+               dp_add_event(dp, EV_HPD_INIT_SETUP, 0, 100);
 }
 
 bool msm_dp_wide_bus_available(const struct msm_dp *dp_display)
-- 
2.30.2

             reply	other threads:[~2023-05-08  1:06 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-08  1:06 Leonard Lausen [this message]
2023-05-08  2:15 ` [PATCH] Revert "drm/msm/dp: Remove INIT_SETUP delay" Bjorn Andersson
2023-05-08  4:25   ` Abhinav Kumar
2023-05-08 11:02     ` Leonard Lausen
2023-05-08 11:30       ` Dmitry Baryshkov
2023-05-09 19:15         ` Abhinav Kumar
2023-05-23  2:39           ` Leonard Lausen
2023-05-23 18:56             ` [Freedreno] " Abhinav Kumar
2023-05-23 19:53               ` Kuogee Hsieh
2023-05-24 12:58                 ` Leonard Lausen
2023-05-25 17:57                   ` Kuogee Hsieh
2023-05-25 18:10                     ` Abhinav Kumar
2023-06-01 19:20                   ` Abhinav Kumar
2023-06-02  1:36                     ` Leonard Lausen
2023-06-22 13:05                       ` Leonard Lausen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ebbcd56ac883d3c3d3024d368fab63d26e02637a@lausen.nl \
    --to=leonard@lausen.nl \
    --cc=airlied@gmail.com \
    --cc=daniel@ffwll.ch \
    --cc=dmitry.baryshkov@linaro.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=freedreno@lists.freedesktop.org \
    --cc=johan+linaro@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nikita@trvn.ru \
    --cc=quic_abhinavk@quicinc.com \
    --cc=quic_bjorande@quicinc.com \
    --cc=quic_khsieh@quicinc.com \
    --cc=quic_sbillaka@quicinc.com \
    --cc=regressions@lists.linux.dev \
    --cc=robdclark@gmail.com \
    --cc=sean@poorly.run \
    --cc=swboyd@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox