From: Krzysztof Kozlowski <krzk@kernel.org>
To: Raviteja Laggyshetty <quic_rlaggysh@quicinc.com>,
Georgi Djakov <djakov@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>
Cc: Odelu Kukatla <quic_okukatla@quicinc.com>,
Mike Tipton <quic_mdtipton@quicinc.com>,
Sibi Sankar <quic_sibis@quicinc.com>,
linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH V6 3/4] dt-bindings: interconnect: Add generic compatible qcom,epss-l3-perf
Date: Mon, 25 Nov 2024 19:00:36 +0100 [thread overview]
Message-ID: <936fc52e-95a7-48f6-85bb-13dbc10ddb71@kernel.org> (raw)
In-Reply-To: <20241125174511.45-4-quic_rlaggysh@quicinc.com>
On 25/11/2024 18:45, Raviteja Laggyshetty wrote:
> EPSS instance on sc7280, sm8250 SoCs, use PERF_STATE register instead of
This should explain that these devices are actually 100% compatible.
> REG_L3_VOTE to scale L3 clocks, hence adding a new generic
> compatible "qcom,epss-l3-perf" for these targets.
Not the best reason... You add one more generic compatible, because
devices are different? With such reason answer is: no, do not add
generic compatibles, because they are not generic.
The entire point of having generic compatibles is that they really are
generic. Here you prove that they are not generic, so why creating one
more generic compatible which might not be generic at all?
I already expressed above concerns multiple times:
1. In previous versions of this patchset
2. In other threads
I am not against this change, but I am not going to Ack it. Get acks
from other maintainers, I am not happy with multiple
generic-but-actually-not-generic compatibles. I think that is poor approach.
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-11-25 18:00 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-25 17:45 [PATCH V6 0/4] Add EPSS L3 provider support on SA8775P SoC Raviteja Laggyshetty
2024-11-25 17:45 ` [PATCH V6 1/4] interconnect: qcom: Add multidev EPSS L3 support Raviteja Laggyshetty
2024-11-30 12:49 ` Konrad Dybcio
2024-11-30 15:09 ` Dmitry Baryshkov
2024-11-30 15:12 ` Konrad Dybcio
2024-11-30 15:32 ` Dmitry Baryshkov
2024-12-26 16:13 ` Raviteja Laggyshetty
2024-12-29 1:23 ` Dmitry Baryshkov
2025-01-03 14:07 ` Raviteja Laggyshetty
2025-01-03 17:46 ` Dmitry Baryshkov
2024-11-25 17:45 ` [PATCH V6 2/4] interconnect: qcom: osm-l3: Add generic compatible for epss-l3-perf Raviteja Laggyshetty
2024-11-25 17:45 ` [PATCH V6 3/4] dt-bindings: interconnect: Add generic compatible qcom,epss-l3-perf Raviteja Laggyshetty
2024-11-25 18:00 ` Krzysztof Kozlowski [this message]
2024-11-27 14:23 ` Rob Herring
2024-11-27 16:53 ` Dmitry Baryshkov
2024-11-27 18:27 ` Krzysztof Kozlowski
2024-11-27 18:49 ` Dmitry Baryshkov
2024-11-27 19:22 ` Krzysztof Kozlowski
2024-11-27 19:45 ` Dmitry Baryshkov
2024-12-26 15:56 ` Raviteja Laggyshetty
2024-11-25 17:45 ` [PATCH V6 4/4] arm64: dts: qcom: sa8775p: add EPSS l3 interconnect provider Raviteja Laggyshetty
2024-11-27 19:21 ` Krzysztof Kozlowski
2024-11-30 12:51 ` Konrad Dybcio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=936fc52e-95a7-48f6-85bb-13dbc10ddb71@kernel.org \
--to=krzk@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=djakov@kernel.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=quic_mdtipton@quicinc.com \
--cc=quic_okukatla@quicinc.com \
--cc=quic_rlaggysh@quicinc.com \
--cc=quic_sibis@quicinc.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox