Linux ARM-MSM sub-architecture
 help / color / mirror / Atom feed
* [PATCH 1/2] drm/ci: pick up -external-fixes from the merge target repo
@ 2023-10-08 13:23 Dmitry Baryshkov
  2023-10-08 13:23 ` [PATCH 2/2] drm/ci: force-enable CONFIG_MSM_MMCC_8996 as built-in Dmitry Baryshkov
                   ` (2 more replies)
  0 siblings, 3 replies; 5+ messages in thread
From: Dmitry Baryshkov @ 2023-10-08 13:23 UTC (permalink / raw)
  To: Thierry Reding, Sam Ravnborg, Maarten Lankhorst, Maxime Ripard,
	Thomas Zimmermann, David Airlie, Daniel Vetter
  Cc: Rob Clark, Abhinav Kumar, dri-devel, freedreno, linux-arm-msm

In case of the merge requests it might be useful to push repo-specific
fixes which have not yet propagated to the -external-fixes branch in the
main UPSTREAM_REPO. For example, in case of drm/msm development, we are
staging fixes locally for testing, before pushing them to the drm/drm
repo. Thus, if the CI run was triggered by merge request, also pick up
the -external fixes basing on the the CI_MERGE target repo / and branch.

Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
---
 drivers/gpu/drm/ci/build.sh | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/drivers/gpu/drm/ci/build.sh b/drivers/gpu/drm/ci/build.sh
index 7b014287a041..20a6ba8a7b04 100644
--- a/drivers/gpu/drm/ci/build.sh
+++ b/drivers/gpu/drm/ci/build.sh
@@ -64,10 +64,15 @@ if [ "$(git ls-remote --exit-code --heads ${UPSTREAM_REPO} ${TARGET_BRANCH}-exte
 fi
 
 # Try to merge fixes from local repo if this isn't a merge request
+# otherwise try merging the fixes from the merge target
 if [ -z "$CI_MERGE_REQUEST_PROJECT_PATH" ]; then
     if [ "$(git ls-remote --exit-code --heads origin ${TARGET_BRANCH}-external-fixes)" ]; then
         git pull origin ${TARGET_BRANCH}-external-fixes
     fi
+else
+    if [ "$(git ls-remote --exit-code --heads ${CI_MERGE_REQUEST_PROJECT_URL} ${CI_MERGE_REQUEST_TARGET_BRANCH_NAME}-external-fixes)" ]; then
+        git pull ${CI_MERGE_REQUEST_PROJECT_URL} ${CI_MERGE_REQUEST_TARGET_BRANCH_NAME}-external-fixes
+    fi
 fi
 
 for opt in $ENABLE_KCONFIGS; do
-- 
2.40.1


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [PATCH 2/2] drm/ci: force-enable CONFIG_MSM_MMCC_8996 as built-in
  2023-10-08 13:23 [PATCH 1/2] drm/ci: pick up -external-fixes from the merge target repo Dmitry Baryshkov
@ 2023-10-08 13:23 ` Dmitry Baryshkov
  2023-10-09  0:22   ` Helen Koike
  2023-10-20  1:10 ` [PATCH 1/2] drm/ci: pick up -external-fixes from the merge target repo Helen Koike
  2023-10-26 13:26 ` Maxime Ripard
  2 siblings, 1 reply; 5+ messages in thread
From: Dmitry Baryshkov @ 2023-10-08 13:23 UTC (permalink / raw)
  To: Thierry Reding, Sam Ravnborg, Maarten Lankhorst, Maxime Ripard,
	Thomas Zimmermann, David Airlie, Daniel Vetter
  Cc: Rob Clark, Abhinav Kumar, dri-devel, freedreno, linux-arm-msm

Enable CONFIG_MSM_MMCC_8996, the multimedia clock controller on Qualcomm
MSM8996 to prevent the the board from hitting the probe deferral
timeouts in CI run.

Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
---
 drivers/gpu/drm/ci/arm64.config | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/ci/arm64.config b/drivers/gpu/drm/ci/arm64.config
index 45f9deb7c4f6..b4f653417883 100644
--- a/drivers/gpu/drm/ci/arm64.config
+++ b/drivers/gpu/drm/ci/arm64.config
@@ -62,6 +62,7 @@ CONFIG_PHY_QCOM_QUSB2=y
 CONFIG_PHY_QCOM_QMP=y
 CONFIG_MSM_GCC_8996=y
 CONFIG_QCOM_CLK_APCC_MSM8996=y
+CONFIG_MSM_MMCC_8996=y
 CONFIG_QCOM_LLCC=y
 CONFIG_QCOM_LMH=y
 CONFIG_QCOM_SPMI_TEMP_ALARM=y
-- 
2.40.1


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH 2/2] drm/ci: force-enable CONFIG_MSM_MMCC_8996 as built-in
  2023-10-08 13:23 ` [PATCH 2/2] drm/ci: force-enable CONFIG_MSM_MMCC_8996 as built-in Dmitry Baryshkov
@ 2023-10-09  0:22   ` Helen Koike
  0 siblings, 0 replies; 5+ messages in thread
From: Helen Koike @ 2023-10-09  0:22 UTC (permalink / raw)
  To: Dmitry Baryshkov, Thierry Reding, Sam Ravnborg, Maarten Lankhorst,
	Maxime Ripard, Thomas Zimmermann, David Airlie, Daniel Vetter
  Cc: linux-arm-msm, freedreno, Abhinav Kumar, dri-devel



On 08/10/2023 10:23, Dmitry Baryshkov wrote:
> Enable CONFIG_MSM_MMCC_8996, the multimedia clock controller on Qualcomm
> MSM8996 to prevent the the board from hitting the probe deferral
> timeouts in CI run.
> 
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>

Tested-by: Helen Koike <helen.koike@collabora.com>

Pipeline: 
https://gitlab.freedesktop.org/helen.fornazier/linux/-/jobs/50031700

I saw that msm:apq8096 driver wasn't loading without this patch, thanks!

Acked-by: Helen Koike <helen.koike@collabora.com>

> ---
>   drivers/gpu/drm/ci/arm64.config | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/gpu/drm/ci/arm64.config b/drivers/gpu/drm/ci/arm64.config
> index 45f9deb7c4f6..b4f653417883 100644
> --- a/drivers/gpu/drm/ci/arm64.config
> +++ b/drivers/gpu/drm/ci/arm64.config
> @@ -62,6 +62,7 @@ CONFIG_PHY_QCOM_QUSB2=y
>   CONFIG_PHY_QCOM_QMP=y
>   CONFIG_MSM_GCC_8996=y
>   CONFIG_QCOM_CLK_APCC_MSM8996=y
> +CONFIG_MSM_MMCC_8996=y
>   CONFIG_QCOM_LLCC=y
>   CONFIG_QCOM_LMH=y
>   CONFIG_QCOM_SPMI_TEMP_ALARM=y

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH 1/2] drm/ci: pick up -external-fixes from the merge target repo
  2023-10-08 13:23 [PATCH 1/2] drm/ci: pick up -external-fixes from the merge target repo Dmitry Baryshkov
  2023-10-08 13:23 ` [PATCH 2/2] drm/ci: force-enable CONFIG_MSM_MMCC_8996 as built-in Dmitry Baryshkov
@ 2023-10-20  1:10 ` Helen Koike
  2023-10-26 13:26 ` Maxime Ripard
  2 siblings, 0 replies; 5+ messages in thread
From: Helen Koike @ 2023-10-20  1:10 UTC (permalink / raw)
  To: Dmitry Baryshkov, Thierry Reding, Sam Ravnborg, Maarten Lankhorst,
	Maxime Ripard, Thomas Zimmermann, David Airlie, Daniel Vetter
  Cc: linux-arm-msm, freedreno, Abhinav Kumar, dri-devel



On 08/10/2023 10:23, Dmitry Baryshkov wrote:
> In case of the merge requests it might be useful to push repo-specific
> fixes which have not yet propagated to the -external-fixes branch in the
> main UPSTREAM_REPO. For example, in case of drm/msm development, we are
> staging fixes locally for testing, before pushing them to the drm/drm
> repo. Thus, if the CI run was triggered by merge request, also pick up
> the -external fixes basing on the the CI_MERGE target repo / and branch.
> 
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>

Acked-by: Helen Koike <helen.koike@collabora.com>

Thanks!

> ---
>   drivers/gpu/drm/ci/build.sh | 5 +++++
>   1 file changed, 5 insertions(+)
> 
> diff --git a/drivers/gpu/drm/ci/build.sh b/drivers/gpu/drm/ci/build.sh
> index 7b014287a041..20a6ba8a7b04 100644
> --- a/drivers/gpu/drm/ci/build.sh
> +++ b/drivers/gpu/drm/ci/build.sh
> @@ -64,10 +64,15 @@ if [ "$(git ls-remote --exit-code --heads ${UPSTREAM_REPO} ${TARGET_BRANCH}-exte
>   fi
>   
>   # Try to merge fixes from local repo if this isn't a merge request
> +# otherwise try merging the fixes from the merge target
>   if [ -z "$CI_MERGE_REQUEST_PROJECT_PATH" ]; then
>       if [ "$(git ls-remote --exit-code --heads origin ${TARGET_BRANCH}-external-fixes)" ]; then
>           git pull origin ${TARGET_BRANCH}-external-fixes
>       fi
> +else
> +    if [ "$(git ls-remote --exit-code --heads ${CI_MERGE_REQUEST_PROJECT_URL} ${CI_MERGE_REQUEST_TARGET_BRANCH_NAME}-external-fixes)" ]; then
> +        git pull ${CI_MERGE_REQUEST_PROJECT_URL} ${CI_MERGE_REQUEST_TARGET_BRANCH_NAME}-external-fixes
> +    fi
>   fi
>   
>   for opt in $ENABLE_KCONFIGS; do

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH 1/2] drm/ci: pick up -external-fixes from the merge target repo
  2023-10-08 13:23 [PATCH 1/2] drm/ci: pick up -external-fixes from the merge target repo Dmitry Baryshkov
  2023-10-08 13:23 ` [PATCH 2/2] drm/ci: force-enable CONFIG_MSM_MMCC_8996 as built-in Dmitry Baryshkov
  2023-10-20  1:10 ` [PATCH 1/2] drm/ci: pick up -external-fixes from the merge target repo Helen Koike
@ 2023-10-26 13:26 ` Maxime Ripard
  2 siblings, 0 replies; 5+ messages in thread
From: Maxime Ripard @ 2023-10-26 13:26 UTC (permalink / raw)
  To: Thierry Reding, Sam Ravnborg, Maarten Lankhorst,
	Thomas Zimmermann, David Airlie, Daniel Vetter, Dmitry Baryshkov
  Cc: Rob Clark, Abhinav Kumar, dri-devel, freedreno, linux-arm-msm

On Sun, 08 Oct 2023 16:23:19 +0300, Dmitry Baryshkov wrote:
> In case of the merge requests it might be useful to push repo-specific
> fixes which have not yet propagated to the -external-fixes branch in the
> main UPSTREAM_REPO. For example, in case of drm/msm development, we are
> staging fixes locally for testing, before pushing them to the drm/drm
> repo. Thus, if the CI run was triggered by merge request, also pick up
> the -external fixes basing on the the CI_MERGE target repo / and branch.
> 
> [...]

Applied to drm/drm-misc (drm-misc-next).

Thanks!
Maxime


^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2023-10-26 13:26 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-10-08 13:23 [PATCH 1/2] drm/ci: pick up -external-fixes from the merge target repo Dmitry Baryshkov
2023-10-08 13:23 ` [PATCH 2/2] drm/ci: force-enable CONFIG_MSM_MMCC_8996 as built-in Dmitry Baryshkov
2023-10-09  0:22   ` Helen Koike
2023-10-20  1:10 ` [PATCH 1/2] drm/ci: pick up -external-fixes from the merge target repo Helen Koike
2023-10-26 13:26 ` Maxime Ripard

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox