From: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
To: Yuan Can <yuancan@huawei.com>,
agross@kernel.org, andersson@kernel.org,
konrad.dybcio@somainline.org, kishon@ti.com, vkoul@kernel.org,
linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org
Subject: Re: [PATCH 6/7] phy: qcom-qusb2: Use dev_err_probe() to simplify code
Date: Thu, 22 Sep 2022 21:05:21 +0300 [thread overview]
Message-ID: <96ce54ed-a6d1-7b06-1eff-c153965637f4@linaro.org> (raw)
In-Reply-To: <20220922111228.36355-7-yuancan@huawei.com>
On 22/09/2022 14:12, Yuan Can wrote:
> In the probe path, dev_err() can be replaced with dev_err_probe()
> which will check if error code is -EPROBE_DEFER and prints the
> error name. It also sets the defer probe reason which can be
> checked later through debugfs.
>
> Signed-off-by: Yuan Can <yuancan@huawei.com>
> ---
> drivers/phy/qualcomm/phy-qcom-qusb2.c | 27 +++++++++------------------
> 1 file changed, 9 insertions(+), 18 deletions(-)
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
--
With best wishes
Dmitry
next prev parent reply other threads:[~2022-09-22 18:05 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-22 11:12 [PATCH 0/7] Use dev_err_probe() to simplify code Yuan Can
2022-09-22 11:12 ` [PATCH 1/7] phy: qcom-qmp-combo: " Yuan Can
2022-09-22 18:03 ` Dmitry Baryshkov
2022-09-22 11:12 ` [PATCH 2/7] phy: qcom-qmp-pcie-msm8996: " Yuan Can
2022-09-22 18:03 ` Dmitry Baryshkov
2022-09-22 11:12 ` [PATCH 3/7] phy: qcom-qmp-pcie: " Yuan Can
2022-09-22 12:46 ` Neil Armstrong
2022-09-22 18:03 ` Dmitry Baryshkov
2022-09-22 11:12 ` [PATCH 4/7] phy: qcom-qmp-ufs: " Yuan Can
2022-09-22 18:03 ` Dmitry Baryshkov
2022-09-22 11:12 ` [PATCH 5/7] phy: qcom-qmp-usb: " Yuan Can
2022-09-22 12:46 ` Neil Armstrong
2022-09-22 18:04 ` Dmitry Baryshkov
2022-09-22 11:12 ` [PATCH 6/7] phy: qcom-qusb2: " Yuan Can
2022-09-22 12:49 ` Neil Armstrong
2022-09-22 18:05 ` Dmitry Baryshkov [this message]
2022-09-22 11:12 ` [PATCH 7/7] phy: qcom-snps: " Yuan Can
2022-09-22 18:05 ` Dmitry Baryshkov
2022-09-22 14:26 ` [PATCH 0/7] " Andrew Halaney
2022-09-24 6:38 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=96ce54ed-a6d1-7b06-1eff-c153965637f4@linaro.org \
--to=dmitry.baryshkov@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=kishon@ti.com \
--cc=konrad.dybcio@somainline.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=vkoul@kernel.org \
--cc=yuancan@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox