From: Krzysztof Kozlowski <krzk@kernel.org>
To: weifu wu <wwfu06@163.com>, andersson@kernel.org, konradybcio@kernel.org
Cc: robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/2] dt-bindings: arm: qcom: add Acer Swift SFA14-11
Date: Mon, 5 Jan 2026 13:01:43 +0100 [thread overview]
Message-ID: <96e317a1-d564-4c66-b71c-ea03acc20ce7@kernel.org> (raw)
In-Reply-To: <20260105110431.2596253-3-wwfu06@163.com>
On 05/01/2026 12:04, weifu wu wrote:
> Add DT binding documentation for Acer Swift SFA14-11 laptop based on Qualcomm X1E78100 SoC.
Can you please slow down and address the feedback? EACH one.
> This introduces a new compatible string for the Acer Swift SFA14-11 board.
Drop, redundant.
>
> Eliminate duplicate data and add the device model to the compatible entry.
Not relevant.
>
> Signed-off-by: weifu wu <wwfu06@163.com>
> ---
> Documentation/devicetree/bindings/arm/qcom.yaml | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
> index 55d4afa9a70e..09c488973961 100644
> --- a/Documentation/devicetree/bindings/arm/qcom.yaml
> +++ b/Documentation/devicetree/bindings/arm/qcom.yaml
> @@ -1068,12 +1068,6 @@ properties:
> - items:
> - enum:
> - acer,swift-sfa14-11
> - - const: acer,swift-sfa14-11
> - - const: qcom,x1e78100
> - - const: qcom,x1e80100
There is no such hunk.
Please organize the patch documenting the compatible (DT bindings)
before the patch using that compatible.
See also:
https://elixir.bootlin.com/linux/v6.14-rc6/source/Documentation/devicetree/bindings/submitting-patches.rst#L46
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-01-05 12:01 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-05 11:04 [PATCH v2 0/2] Add Acer Swift SFA14-11 DT and bindings weifu wu
2026-01-05 11:04 ` [PATCH v2 1/2] arm64: dts: qcom: add Acer Swift SFA14-11 device tree weifu wu
2026-01-05 12:04 ` Krzysztof Kozlowski
2026-01-05 15:05 ` Bjorn Andersson
2026-01-05 11:04 ` [PATCH v2 2/2] dt-bindings: arm: qcom: add Acer Swift SFA14-11 weifu wu
2026-01-05 12:01 ` Krzysztof Kozlowski [this message]
2026-01-05 12:08 ` [PATCH v2 0/2] Add Acer Swift SFA14-11 DT and bindings Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=96e317a1-d564-4c66-b71c-ea03acc20ce7@kernel.org \
--to=krzk@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=wwfu06@163.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox