Re: [PATCH 2/2] arm64: dts: qcom: qcs8300-ride: Enable Display Port

[Yongxing Mou <quic_yongmou@quicinc.com>]

On 2024/12/6 5:46, Konrad Dybcio wrote:
> On 27.11.2024 11:45 AM, Yongxing Mou wrote:
>> Enable DPTX0 along with their corresponding PHYs for
>> qcs8300-ride platform.
>>
>> Signed-off-by: Yongxing Mou <quic_yongmou@quicinc.com>
>> ---
> 
> [...]
> 
>> +
>> +	dp0-connector {
>> +		compatible = "dp-connector";
>> +		label = "DP0";
>> +		type = "full-size";
> 
> I was surprised to see it but yeah this is real
> 
>> +
>> +		port {
>> +			dp0_connector_in: endpoint {
>> +				remote-endpoint = <&mdss_dp0_out>;
>> +			};
>> +		};
>> +	};
>>   };
>>   
>>   &apps_rsc {
>> @@ -223,6 +235,30 @@ &gcc {
>>   		 <0>;
>>   };
>>   
>> +&mdss {
>> +	status = "okay";
>> +};
>> +
>> +&mdss_dp0 {
>> +	status = "okay";
> status should be the last property
> 
got it. thanks for ponit it.
>> +
>> +	pinctrl-0 = <&dp_hot_plug_det>;
>> +	pinctrl-names = "default";
>> +};
>> +
>> +&mdss_dp0_out {
>> +	data-lanes = <0 1 2 3>;
>> +	link-frequencies = /bits/ 64 <1620000000 2700000000 5400000000 8100000000>;
>> +	remote-endpoint = <&dp0_connector_in>;
>> +};
>> +
>> +&mdss_dp0_phy {
>> +	status = "okay";
>> +
>> +	vdda-phy-supply = <&vreg_l5a>;
>> +	vdda-pll-supply = <&vreg_l4a>;
> I couldn't find the reference for these, so I have to trust you
> 
yes, this two power can work for qcs8300.and we verify it.status also 
should be last property?
> Konrad
>