* [PATCH v2] arm64: dts: qcom: qrb4210-rb2: Correct PMI632 VBUS ampere
@ 2024-07-01 10:24 Dang Huynh
2024-07-01 10:28 ` Luca Weiss
2024-07-01 21:25 ` Dmitry Baryshkov
0 siblings, 2 replies; 3+ messages in thread
From: Dang Huynh @ 2024-07-01 10:24 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley
Cc: Dmitry Baryshkov, Luca Weiss, linux-arm-msm, devicetree,
linux-kernel, Dang Huynh
According to downstream sources, PMI632 maximum VBUS ampere is
1A.
Taken from msm-4.19 (631561973a034e46ccacd0e53ef65d13a40d87a4)
Line 685-687 in drivers/power/supply/qcom/qpnp-smb5.c
Signed-off-by: Dang Huynh <danct12@riseup.net>
---
In previous patch series, there's a suggestion to correct
PMI632's VBUS ampere.
Unfortunately it didn't make it and probably forgotten.
----
Changes in v2:
- Fixed typo (voltage -> ampere)
- Link to v1: https://lore.kernel.org/r/20240701-qrd4210rb2-vbus-volt-v1-1-5c06f8358436@riseup.net
---
arch/arm64/boot/dts/qcom/qrb4210-rb2.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/qcom/qrb4210-rb2.dts b/arch/arm64/boot/dts/qcom/qrb4210-rb2.dts
index 1c7de7f2db79..1888d99d398b 100644
--- a/arch/arm64/boot/dts/qcom/qrb4210-rb2.dts
+++ b/arch/arm64/boot/dts/qcom/qrb4210-rb2.dts
@@ -305,7 +305,7 @@ pmi632_ss_in: endpoint {
&pmi632_vbus {
regulator-min-microamp = <500000>;
- regulator-max-microamp = <3000000>;
+ regulator-max-microamp = <1000000>;
status = "okay";
};
---
base-commit: 642a16ca7994a50d7de85715996a8ce171a5bdfb
change-id: 20240701-qrd4210rb2-vbus-volt-822764c7cfca
Best regards,
--
Dang Huynh <danct12@riseup.net>
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2] arm64: dts: qcom: qrb4210-rb2: Correct PMI632 VBUS ampere
2024-07-01 10:24 [PATCH v2] arm64: dts: qcom: qrb4210-rb2: Correct PMI632 VBUS ampere Dang Huynh
@ 2024-07-01 10:28 ` Luca Weiss
2024-07-01 21:25 ` Dmitry Baryshkov
1 sibling, 0 replies; 3+ messages in thread
From: Luca Weiss @ 2024-07-01 10:28 UTC (permalink / raw)
To: Dang Huynh, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, Conor Dooley
Cc: Dmitry Baryshkov, linux-arm-msm, devicetree, linux-kernel
On Mon Jul 1, 2024 at 12:24 PM CEST, Dang Huynh wrote:
> According to downstream sources, PMI632 maximum VBUS ampere is
> 1A.
>
> Taken from msm-4.19 (631561973a034e46ccacd0e53ef65d13a40d87a4)
> Line 685-687 in drivers/power/supply/qcom/qpnp-smb5.c
>
> Signed-off-by: Dang Huynh <danct12@riseup.net>
Fixes: a06a2f12f9e2 ("arm64: dts: qcom: qrb4210-rb2: enable USB-C port handling")
Reviewed-by: Luca Weiss <luca.weiss@fairphone.com>
> ---
> In previous patch series, there's a suggestion to correct
> PMI632's VBUS ampere.
>
> Unfortunately it didn't make it and probably forgotten.
Could've included a link for easier context:
https://lore.kernel.org/linux-arm-msm/CYMDEAJZ0TJK.K31XZB3E9QOG@fairphone.com/
>
> ----
> Changes in v2:
> - Fixed typo (voltage -> ampere)
> - Link to v1: https://lore.kernel.org/r/20240701-qrd4210rb2-vbus-volt-v1-1-5c06f8358436@riseup.net
> ---
> arch/arm64/boot/dts/qcom/qrb4210-rb2.dts | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/qrb4210-rb2.dts b/arch/arm64/boot/dts/qcom/qrb4210-rb2.dts
> index 1c7de7f2db79..1888d99d398b 100644
> --- a/arch/arm64/boot/dts/qcom/qrb4210-rb2.dts
> +++ b/arch/arm64/boot/dts/qcom/qrb4210-rb2.dts
> @@ -305,7 +305,7 @@ pmi632_ss_in: endpoint {
>
> &pmi632_vbus {
> regulator-min-microamp = <500000>;
> - regulator-max-microamp = <3000000>;
> + regulator-max-microamp = <1000000>;
> status = "okay";
> };
>
>
> ---
> base-commit: 642a16ca7994a50d7de85715996a8ce171a5bdfb
> change-id: 20240701-qrd4210rb2-vbus-volt-822764c7cfca
>
> Best regards,
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] arm64: dts: qcom: qrb4210-rb2: Correct PMI632 VBUS ampere
2024-07-01 10:24 [PATCH v2] arm64: dts: qcom: qrb4210-rb2: Correct PMI632 VBUS ampere Dang Huynh
2024-07-01 10:28 ` Luca Weiss
@ 2024-07-01 21:25 ` Dmitry Baryshkov
1 sibling, 0 replies; 3+ messages in thread
From: Dmitry Baryshkov @ 2024-07-01 21:25 UTC (permalink / raw)
To: Dang Huynh
Cc: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Luca Weiss, linux-arm-msm, devicetree, linux-kernel
On Mon, Jul 01, 2024 at 05:24:39PM GMT, Dang Huynh wrote:
> According to downstream sources, PMI632 maximum VBUS ampere is
s/ampere/current/
Also in the subject, please.
> 1A.
>
> Taken from msm-4.19 (631561973a034e46ccacd0e53ef65d13a40d87a4)
> Line 685-687 in drivers/power/supply/qcom/qpnp-smb5.c
>
> Signed-off-by: Dang Huynh <danct12@riseup.net>
> ---
> In previous patch series, there's a suggestion to correct
> PMI632's VBUS ampere.
>
> Unfortunately it didn't make it and probably forgotten.
>
> ----
> Changes in v2:
> - Fixed typo (voltage -> ampere)
> - Link to v1: https://lore.kernel.org/r/20240701-qrd4210rb2-vbus-volt-v1-1-5c06f8358436@riseup.net
> ---
> arch/arm64/boot/dts/qcom/qrb4210-rb2.dts | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/qrb4210-rb2.dts b/arch/arm64/boot/dts/qcom/qrb4210-rb2.dts
> index 1c7de7f2db79..1888d99d398b 100644
> --- a/arch/arm64/boot/dts/qcom/qrb4210-rb2.dts
> +++ b/arch/arm64/boot/dts/qcom/qrb4210-rb2.dts
> @@ -305,7 +305,7 @@ pmi632_ss_in: endpoint {
>
> &pmi632_vbus {
> regulator-min-microamp = <500000>;
> - regulator-max-microamp = <3000000>;
> + regulator-max-microamp = <1000000>;
> status = "okay";
> };
>
>
> ---
> base-commit: 642a16ca7994a50d7de85715996a8ce171a5bdfb
> change-id: 20240701-qrd4210rb2-vbus-volt-822764c7cfca
>
> Best regards,
> --
> Dang Huynh <danct12@riseup.net>
>
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-07-01 21:25 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-07-01 10:24 [PATCH v2] arm64: dts: qcom: qrb4210-rb2: Correct PMI632 VBUS ampere Dang Huynh
2024-07-01 10:28 ` Luca Weiss
2024-07-01 21:25 ` Dmitry Baryshkov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox